Re: regression caused by: "amlogic: mmc: meson-gx: add signal resampling"

From: Neil Armstrong <narmstrong@baylibre.com>
To: Andreas Fenkart <afenkart@gmail.com>,
	Jerome Brunet <jbrunet@baylibre.com>
Cc: "open list:ARM/Amlogic Meson..."
	<linux-amlogic@lists.infradead.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	krzysztof.michonski@digitalstrom.com,
	Kevin Hilman <khilman@baylibre.com>
Subject: Re: regression caused by: "amlogic: mmc: meson-gx: add signal resampling"
Date: Thu, 17 Jan 2019 13:42:41 +0100	[thread overview]
Message-ID: <11102cad-b1bc-fe1c-3b37-fb20e0cfaab3@baylibre.com> (raw)
In-Reply-To: <CALtMJECrsHDHxYRHMFfOCCoymGudGiVxjtK2f2T6ZK8mfNZ6_g@mail.gmail.com>

Hi Andreas,

On 17/01/2019 13:35, Andreas Fenkart wrote:
> Hi Jerome
>> There an actual s905x p212 in kernelci which is not showing any issue, AFAIK.
>>
>> https://kernelci.org/boot/meson-gxl-s905x-p212/
>>
>> Have a look a this recent boot of mainline/arm64:
>> https://storage.kernelci.org/mainline/master/v5.0-rc2-36-gfe76fc6aaf53/arm64/defconfig/lab-baylibre-seattle/boot-meson-gxl-s905x-p212.txt
> 
> thanks, great way to compare with my local output messages
> 
> already wondered about this:
> [    1.195173] meson_vid_pll_div_recalc_rate: Invalid config value for
> vid_pll_div

This is a warning I should put in dbg, the vid_pll config at reset is unknown and we can't calc a rate...

> 
>> Has the p212 is ref design of the s905x, we often see the related DT used on
>> other device.
>>
>> Is your board actually a p212 ?
>> If yes, could you tell us about any of the marking on PCB, such as the board
>> revision ?
>> If not, could you tell us more about your device ?
> 
> it's a "BeeLink Mini M8 SII"
> 
> pasted the output here
> https://pastebin.com/UCnR25mK
> 
> should I try with another dtb?

Devices derivative from P212 are not 100% same as the reference design, by using different components
and with maybe less good pcb routing, so high speed clocks & modes could not work at all.

You should add a dts for you device based on p212 with some changes in the mmc capabilities.

since we can't have access to the source changes for these devices, it's only based on guess..

Neil

> 
>> We proposing this series, I flagged that this patch and the other one (on
>> phase settings) needed broader testing. It could possibly cause regression for
>> tunning and high speed modes ... this typically show with error -5 (tunning
>> failed)
>>
>> Here your eMMC timedout during init, so even before an attempt is made to tune
>> which is odd. Could you try to enable signal resampling only when going forhigh speed modes ?
> 
> huh, need to look into how to do that.
> 
> /Andi
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
> 

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic