From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9357BC169C4 for ; Tue, 29 Jan 2019 18:09:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6902D21848 for ; Tue, 29 Jan 2019 18:09:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UdPTQbSt"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="f9qXvm99" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6902D21848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Message-ID:In-Reply-To:From: References:Subject:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1tliSY/BLPM6hndNPF6Pi/rOMPvIle2DDhygP8R2pas=; b=UdPTQbStDhuhix R47H4NUQRB2O1Tlo6UwyLbLnwZ8G6DSEAu9TA8uEqYcS0CdH+oB95otxllJAVrcMYOfBULh+eacNL 7YdT1WO8vlffrAk8ySKQxF9ifzCfQPNM+Z67cqFvg+39fA6rlE5qxEusbyFOjoC4w1Z8zr77qhj3b 4Am9Y7D46bmeU1hNTHw4PHe6iEvHESSpYTTKTB2MTQcWRJgdY3v+HW6OZnBjBFMNM1r6fk7ldYGBd zhA+rYzhmvJgQyTinRNVWcVfpHyfGe1KeVZkk5hF4faf7eBjbGJ3Xgs424BUq9yf/zz3dT/J6WMFD zFAuURsB+ASEQtH8DcMw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1goXp1-0005TB-D4; Tue, 29 Jan 2019 18:09:19 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1goXoy-0005Si-64; Tue, 29 Jan 2019 18:09:17 +0000 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C00DC2084A; Tue, 29 Jan 2019 18:09:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548785355; bh=VkDWohIUenCSmi9fACRiHhRgqBorJR6nclSPdr+2RTs=; h=Subject:References:Cc:From:In-Reply-To:To:Date:From; b=f9qXvm99ZMZhTWgYI1q+gleMChm6HixUeTL9EhMS7/Ws+3CqA28jh6ILM43noIppx VFIXZ1qDRS5A8Xmdux7V/zADLocuzbQcRjGuVSbZiGcH54yidfAdTD8R+pzpyRN4d1 nlmX2oStBM3gx99tICOIhZHDiYUDIoap8uWseBmM= MIME-Version: 1.0 Subject: Re: [PATCH 14/14] clk: meson: rework and clean drivers dependencies References: <20190128180430.28689-1-jbrunet@baylibre.com> <20190128180430.28689-15-jbrunet@baylibre.com> User-Agent: alot/0.8 From: Stephen Boyd In-Reply-To: <20190128180430.28689-15-jbrunet@baylibre.com> Message-ID: <154878535502.136743.7217447718652873910@swboyd.mtv.corp.google.com> To: Jerome Brunet , Michael Turquette , Neil Armstrong Date: Tue, 29 Jan 2019 10:09:15 -0800 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190129_100916_256874_68894587 X-CRM114-Status: GOOD ( 13.56 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Hilman , linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Quoting Jerome Brunet (2019-01-28 10:04:30) > Initially, the meson clock directory only hosted 2 controllers drivers, > for meson8 and gxbb. At the time, both used the same set of clock drivers > so managing the dependencies was not a big concern. > > Since this ancient time, entropy did its job, controllers with different > requirement and specific clock drivers have been added. Unfortunately, we > did not do a great job at managing the dependencies between the > controllers and the different clock drivers. Some drivers, such as > clk-phase or vid-pll-div, are compiled even if they are useless on the > target (meson8). As we are adding new controllers, we need to be able to > pick a driver w/o pulling the whole thing. > > The patch aims to clean things up by: > * providing a dedicated CONFIG_ for each clock drivers > * allowing clock drivers to be compiled as a modules, if possible > * stating explicitly which drivers are required by each controller. > > Signed-off-by: Jerome Brunet Sounds good to me. > diff --git a/drivers/clk/meson/Makefile b/drivers/clk/meson/Makefile > index 2b9490dd9878..8baec10a49a1 100644 > --- a/drivers/clk/meson/Makefile > +++ b/drivers/clk/meson/Makefile > @@ -2,12 +2,17 @@ > # Makefile for Meson specific clk > # > Add a comment here that these are all the clk library parts or something like that? > -obj-$(CONFIG_COMMON_CLK_AMLOGIC) += clk-pll.o clk-mpll.o clk-phase.o vid-pll-div.o > -obj-$(CONFIG_COMMON_CLK_AMLOGIC) += clk-input.o clk-dualdiv.o > -obj-$(CONFIG_COMMON_CLK_AMLOGIC_AUDIO) += sclk-div.o > -obj-$(CONFIG_COMMON_CLK_MESON_AO) += meson-aoclk.o > +obj-$(CONFIG_COMMON_CLK_MESON_INPUT) += clk-input.o > +obj-$(CONFIG_COMMON_CLK_MESON_REGMAP) += clk-regmap.o > +obj-$(CONFIG_COMMON_CLK_MESON_DUALDIV) += clk-dualdiv.o > +obj-$(CONFIG_COMMON_CLK_MESON_MPLL) += clk-mpll.o > +obj-$(CONFIG_COMMON_CLK_MESON_PHASE) += clk-phase.o > +obj-$(CONFIG_COMMON_CLK_MESON_PLL) += clk-pll.o > +obj-$(CONFIG_COMMON_CLK_MESON_SCLK_DIV) += sclk-div.o > +obj-$(CONFIG_COMMON_CLK_MESON_VID_PLL_DIV) += vid-pll-div.o > +obj-$(CONFIG_COMMON_CLK_MESON_AO_CLKC) += meson-aoclk.o > + And maybe add a comment here indicating that SoC drivers go below? > obj-$(CONFIG_COMMON_CLK_MESON8B) += meson8b.o > -obj-$(CONFIG_COMMON_CLK_GXBB) += gxbb.o gxbb-aoclk.o > -obj-$(CONFIG_COMMON_CLK_AXG) += axg.o axg-aoclk.o > -obj-$(CONFIG_COMMON_CLK_AXG_AUDIO) += axg-audio.o > -obj-$(CONFIG_COMMON_CLK_REGMAP_MESON) += clk-regmap.o > +obj-$(CONFIG_COMMON_CLK_GXBB) += gxbb.o gxbb-aoclk.o > +obj-$(CONFIG_COMMON_CLK_AXG) += axg.o axg-aoclk.o > +obj-$(CONFIG_COMMON_CLK_AXG_AUDIO) += axg-audio.o And sort them by config name alphanumerically? _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic