From: Stephen Boyd <sboyd@kernel.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH 1/4] clk: meson: mpll: add init callback and regs
Date: Mon, 25 Mar 2019 10:10:18 -0700 [thread overview]
Message-ID: <155353381842.20095.17915880223118004926@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20190325111200.15940-2-jbrunet@baylibre.com>
Quoting Jerome Brunet (2019-03-25 04:11:57)
> @@ -138,6 +129,27 @@ static int mpll_set_rate(struct clk_hw *hw,
> return 0;
> }
>
> +static void mpll_init(struct clk_hw *hw)
> +{
> + struct clk_regmap *clk = to_clk_regmap(hw);
> + struct meson_clk_mpll_data *mpll = meson_clk_mpll_data(clk);
> +
> + if (mpll->init_count)
> + regmap_multi_reg_write(clk->map, mpll->init_regs,
> + mpll->init_count);
> +
> + /* Enable the fractional part */
> + meson_parm_write(clk->map, &mpll->sdm_en, 1);
> +
> + /* Set additional fractional part enable if required */
> + if (MESON_PARM_APPLICABLE(&mpll->ssen))
> + meson_parm_write(clk->map, &mpll->ssen, 1);
> +
> + /* Set the magic misc bit if required */
> + if (MESON_PARM_APPLICABLE(&mpll->misc))
> + meson_parm_write(clk->map, &mpll->misc, 1);
> +}
> +
> const struct clk_ops meson_clk_mpll_ro_ops = {
> .recalc_rate = mpll_recalc_rate,
> .round_rate = mpll_round_rate,
> @@ -148,6 +160,7 @@ const struct clk_ops meson_clk_mpll_ops = {
> .recalc_rate = mpll_recalc_rate,
> .round_rate = mpll_round_rate,
> .set_rate = mpll_set_rate,
> + .init = mpll_init,
We actively discourage using init callbacks. Can you do this some other
way?
> };
> EXPORT_SYMBOL_GPL(meson_clk_mpll_ops);
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-03-25 17:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 11:11 [PATCH 0/4] clk: meson: fixup g12a mpll Jerome Brunet
2019-03-25 11:11 ` [PATCH 1/4] clk: meson: mpll: add init callback and regs Jerome Brunet
2019-03-25 17:10 ` Stephen Boyd [this message]
2019-03-26 7:53 ` Jerome Brunet
2019-03-29 22:14 ` Stephen Boyd
2019-03-29 22:58 ` Jerome Brunet
2019-04-05 13:21 ` Jerome Brunet
2019-04-05 15:43 ` Michael Turquette
2019-04-05 20:43 ` Stephen Boyd
2019-04-08 7:38 ` Jerome Brunet
2019-04-23 17:34 ` Michael Turquette
2019-04-23 23:19 ` Stephen Boyd
2019-03-25 11:11 ` [PATCH 2/4] clk: meson: g12a: add mpll register init sequences Jerome Brunet
2019-03-25 11:11 ` [PATCH 3/4] clk: meson: eeclk: add init regs Jerome Brunet
2019-03-25 11:12 ` [PATCH 4/4] clk: meson: g12a: add controller register init Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155353381842.20095.17915880223118004926@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).