linux-amlogic.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm: meson: Remove unneeded semicolon
@ 2019-12-16  3:58 zhengbin
  2020-01-06 14:56 ` Neil Armstrong
  0 siblings, 1 reply; 2+ messages in thread
From: zhengbin @ 2019-12-16  3:58 UTC (permalink / raw)
  To: narmstrong, airlied, daniel, khilman, linux-amlogic, dri-devel,
	linux-arm-kernel
  Cc: zhengbin13

Fixes coccicheck warning:

drivers/gpu/drm/meson/meson_crtc.c:360:3-4: Unneeded semicolon
drivers/gpu/drm/meson/meson_plane.c:181:2-3: Unneeded semicolon

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/meson/meson_crtc.c  | 2 +-
 drivers/gpu/drm/meson/meson_plane.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/meson/meson_crtc.c b/drivers/gpu/drm/meson/meson_crtc.c
index 57ae1c1..eefefc4 100644
--- a/drivers/gpu/drm/meson/meson_crtc.c
+++ b/drivers/gpu/drm/meson/meson_crtc.c
@@ -357,7 +357,7 @@ void meson_crtc_irq(struct meson_drm *priv)
 					    MESON_CANVAS_WRAP_NONE,
 					    MESON_CANVAS_BLKMODE_LINEAR,
 					    MESON_CANVAS_ENDIAN_SWAP64);
-		};
+		}

 		writel_relaxed(priv->viu.vd1_if0_gen_reg,
 				priv->io_base + meson_crtc->viu_offset +
diff --git a/drivers/gpu/drm/meson/meson_plane.c b/drivers/gpu/drm/meson/meson_plane.c
index ed54322..b96fa43 100644
--- a/drivers/gpu/drm/meson/meson_plane.c
+++ b/drivers/gpu/drm/meson/meson_plane.c
@@ -178,7 +178,7 @@ static void meson_plane_atomic_update(struct drm_plane *plane,
 		priv->viu.osd1_blk0_cfg[0] |= OSD_BLK_MODE_16 |
 					      OSD_COLOR_MATRIX_16_RGB565;
 		break;
-	};
+	}

 	/* Default scaler parameters */
 	vsc_bot_rcv_num = 0;
--
2.7.4


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm: meson: Remove unneeded semicolon
  2019-12-16  3:58 [PATCH] drm: meson: Remove unneeded semicolon zhengbin
@ 2020-01-06 14:56 ` Neil Armstrong
  0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2020-01-06 14:56 UTC (permalink / raw)
  To: zhengbin, airlied, daniel, khilman, linux-amlogic, dri-devel,
	linux-arm-kernel

On 16/12/2019 04:58, zhengbin wrote:
> Fixes coccicheck warning:
> 
> drivers/gpu/drm/meson/meson_crtc.c:360:3-4: Unneeded semicolon
> drivers/gpu/drm/meson/meson_plane.c:181:2-3: Unneeded semicolon
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
>  drivers/gpu/drm/meson/meson_crtc.c  | 2 +-
>  drivers/gpu/drm/meson/meson_plane.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/meson/meson_crtc.c b/drivers/gpu/drm/meson/meson_crtc.c
> index 57ae1c1..eefefc4 100644
> --- a/drivers/gpu/drm/meson/meson_crtc.c
> +++ b/drivers/gpu/drm/meson/meson_crtc.c
> @@ -357,7 +357,7 @@ void meson_crtc_irq(struct meson_drm *priv)
>  					    MESON_CANVAS_WRAP_NONE,
>  					    MESON_CANVAS_BLKMODE_LINEAR,
>  					    MESON_CANVAS_ENDIAN_SWAP64);
> -		};
> +		}
> 
>  		writel_relaxed(priv->viu.vd1_if0_gen_reg,
>  				priv->io_base + meson_crtc->viu_offset +
> diff --git a/drivers/gpu/drm/meson/meson_plane.c b/drivers/gpu/drm/meson/meson_plane.c
> index ed54322..b96fa43 100644
> --- a/drivers/gpu/drm/meson/meson_plane.c
> +++ b/drivers/gpu/drm/meson/meson_plane.c
> @@ -178,7 +178,7 @@ static void meson_plane_atomic_update(struct drm_plane *plane,
>  		priv->viu.osd1_blk0_cfg[0] |= OSD_BLK_MODE_16 |
>  					      OSD_COLOR_MATRIX_16_RGB565;
>  		break;
> -	};
> +	}
> 
>  	/* Default scaler parameters */
>  	vsc_bot_rcv_num = 0;
> --
> 2.7.4
> 

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

and applied to drm-misc-next

Thanks,
Neil

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-01-06 14:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-16  3:58 [PATCH] drm: meson: Remove unneeded semicolon zhengbin
2020-01-06 14:56 ` Neil Armstrong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).