From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: khilman@baylibre.com,
Christian Hewitt <christianshewitt@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 6/6] arm64: dts: meson-g12b-khadas-vim3: add initial device-tree
Date: Tue, 6 Aug 2019 17:48:55 +0200 [thread overview]
Message-ID: <198d9d59-78bd-1092-69dd-9dde62915ac5@baylibre.com> (raw)
In-Reply-To: <CAFBinCAD6F=bEE8Z2MvNZLJVKZ3siPqdJ36GuCYkp=DuY3AecQ@mail.gmail.com>
On 03/08/2019 20:50, Martin Blumenstingl wrote:
> On Wed, Jul 31, 2019 at 2:44 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
> [...]
>> + memory@0 {
>> + device_type = "memory";
>> + reg = <0x0 0x0 0x0 0x40000000>;
> nit-pick: we typically use the memory size used in the board size with
> the lowest amount of RAM - 2GiB in this case. so I would change it to
> 0x80000000
Right
>
> [...]
>> + leds {
>> + compatible = "gpio-leds";
>> +
>> + white {
>> + label = "vim3:white";
> downstream sources use label="sys_led"
> should we call it vim3:white:sys?
>
OK, no problem
Thanks for the review.
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-08-06 15:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 12:39 [PATCH 0/6] arm64: add support for the Khadas VIM3 Neil Armstrong
2019-07-31 12:39 ` [PATCH 1/6] soc: amlogic: meson-gx-socinfo: add A311D id Neil Armstrong
2019-08-05 21:47 ` Kevin Hilman
2019-07-31 12:39 ` [PATCH 2/6] dt-bindings: arm: amlogic: add bindings for G12B based S922X SoC Neil Armstrong
2019-07-31 16:54 ` Rob Herring
2019-08-05 21:46 ` Kevin Hilman
2019-08-05 22:21 ` Rob Herring
2019-08-05 22:26 ` Rob Herring
2019-08-08 3:02 ` Kevin Hilman
2019-07-31 12:39 ` [PATCH 3/6] dt-bindings: arm: amlogic: add bindings for the Amlogic G12B based A311D SoC Neil Armstrong
2019-07-31 16:55 ` Rob Herring
2019-07-31 12:39 ` [PATCH 4/6] dt-bindings: arm: amlogic: add support for the Khadas VIM3 Neil Armstrong
2019-07-31 16:55 ` Rob Herring
2019-07-31 12:39 ` [PATCH 5/6] arm64: dts: meson-g12b: support a311d and s922x cpu operating points Neil Armstrong
2019-07-31 12:40 ` [PATCH 6/6] arm64: dts: meson-g12b-khadas-vim3: add initial device-tree Neil Armstrong
2019-08-03 18:50 ` Martin Blumenstingl
2019-08-06 15:48 ` Neil Armstrong [this message]
2019-08-08 17:57 ` [PATCH 0/6] arm64: add support for the Khadas VIM3 Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=198d9d59-78bd-1092-69dd-9dde62915ac5@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=christianshewitt@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).