From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFADFC3A5A6 for ; Mon, 23 Sep 2019 08:35:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B195A2064A for ; Mon, 23 Sep 2019 08:35:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s4xpmlh0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="iweD1MXs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B195A2064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vtZXe06vKW52tMljSMiK0E5feqS4k1YxoxS4CJlOFYc=; b=s4xpmlh0OGMKoZ BCNSALXZ6zMGR4KldChNEwVyp+Dk+NZYskSTDOlKcQ3sXYIRc0+qp6xIKoQvORGMKeVWEJvYsPpdm Tye5BfRw+l5O2vhauUWh4VuOWlHo8Vy8IhamMayPPDRlu//hLTGA9W30R54xUUmIfXelVlngvqdj0 /7e1WmAfLWEGdSdpOWgBQe3fci1rNxvIr5FrlCkhXcr9OFbc5m5nT4A8h/Eg2s8ekKmoSw7BUlZyY caHbZlg3n6Bk2ucoI/R26AM+OU9POxZG1NN5ivWpT9C7uE9AJjlBZlfzuq3g5FfG/b5bObKiX8wJR PLkJchuLbHb0UOSGlSaA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCJox-0000u1-Sc; Mon, 23 Sep 2019 08:35:47 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCJop-0000k6-Ga for linux-amlogic@lists.infradead.org; Mon, 23 Sep 2019 08:35:41 +0000 Received: by mail-wr1-x442.google.com with SMTP id l11so12878304wrx.5 for ; Mon, 23 Sep 2019 01:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=DonLaU+ALkUO4XcKRBTGh6tkB6YDwuQS1LIpYKsRKI0=; b=iweD1MXsqfvUS94mRK6CuoKUGcj8JkfPP+1CofV6Ctqi9Zgrez1OViiWsNU4+5c9b3 1v+Wlc6urwR5u48jExvDWPNV+b3xTmp577z0x9kdXFBVyFQUebSuMf8E1et5vWygC0wh BGMI+Q+gK2RunsyXNXM/I2ECIP6ap5PQQ7tlDaI6PWhk+9y+/59I2ld9Hl5Ce53t0s5n WMnZyjd6MyeGecXc+z8N8DfSowIX3WoHhi+euxfLNBkWSNJdv+aX7jtMW49/86y3zCOg XrPPRlfpPeHWL/GRo/wLm827Cc9vJJJ0CxfzJN1eBxB8tUI1uGbW6TfE5JcNWgejWrbv JIUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=DonLaU+ALkUO4XcKRBTGh6tkB6YDwuQS1LIpYKsRKI0=; b=Lr+tviC5+lz5K8hFWcfJn6DeEXjEVqklj7TgVNzlJmyoVYiZTVNx8rrOyt6FFsI80n Ezy+wn+sW/6vXcHJrDseV2IKe7oUAlTkBgIkM9pLGm+J9Cemp+v4e1Snj+++VGWKefU6 A7B39/m0Njnls7sc73dFJC8ANnYMoPNyk6v0S9C5j+zNH5hLaG4eFED43Mo++Hr6wJo4 WKxMyfCmCZNtGIsnNMrHPG5Tx8SABt+qgeVEXZQgh3H7tQOxxWvNUkB3FU4VJmJz6H8w pRQzrLcje0EFP1KCtdHKiQXyfn8khSwG49/CknuGlF+t4ambdxsxEHExDufehAsS2sIk 8WOQ== X-Gm-Message-State: APjAAAUMSNY4FzJ5BmQZtW0L3h0ujHn0Ok9Wl5T3qAGJtzcscJP7Kv+u i0JXyNUdYnp0xiEOZI7+ILL9cw== X-Google-Smtp-Source: APXvYqxJcD4Iva8LjauXdRv7MdXdwAKMDkOV0VwKKJWiJJiS8vUfgnWZhmg47YeFRhHeSnOuDhR7JQ== X-Received: by 2002:adf:fac3:: with SMTP id a3mr20173795wrs.24.1569227737278; Mon, 23 Sep 2019 01:35:37 -0700 (PDT) Received: from localhost (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id r6sm9279229wmh.38.2019.09.23.01.35.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2019 01:35:36 -0700 (PDT) From: Jerome Brunet To: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.3 034/203] ASoC: meson: g12a-tohdmitx: override codec2codec params In-Reply-To: <20190922184350.30563-34-sashal@kernel.org> References: <20190922184350.30563-1-sashal@kernel.org> <20190922184350.30563-34-sashal@kernel.org> Date: Mon, 23 Sep 2019 10:35:35 +0200 Message-ID: <1j7e5ztnoo.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190923_013539_728515_361B0DB1 X-CRM114-Status: UNSURE ( 8.35 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , linux-amlogic@lists.infradead.org, Mark Brown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sun 22 Sep 2019 at 14:41, Sasha Levin wrote: > From: Jerome Brunet > > [ Upstream commit 2c4956bc1e9062e5e3c5ea7612294f24e6d4fbdd ] > > So far, forwarding the hw_params of the input to output relied on the > .hw_params() callback of the cpu side of the codec2codec link to be called > first. This is a bit weak. > > Instead, override the stream params of the codec2codec to link to set it up > correctly. Hi Sasha This change depends on the following series in ASoC: https://lore.kernel.org/r/20190725165949.29699-1-jbrunet@baylibre.com which has also been merged in this merge window. With this change, things are done (IMO) in a better way but there was no known issue before that. I don't think it is worth backporting the mentioned ASoC series to 5.3. I would suggest to just drop this change from stable. Regards Jerome > > Signed-off-by: Jerome Brunet > Link: https://lore.kernel.org/r/20190729080139.32068-1-jbrunet@baylibre.com > Signed-off-by: Mark Brown > Signed-off-by: Sasha Levin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic