From: Jerome Brunet <jbrunet@baylibre.com>
To: Hyeonki Hong <hhk7734@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
khilman@baylibre.com
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] pinctrl: meson: fix drive strength register and bit calculation
Date: Wed, 17 Jun 2020 15:59:35 +0200 [thread overview]
Message-ID: <1jeeqd3i9k.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20200611053958.GA3687@home-desktop>
On Thu 11 Jun 2020 at 07:40, Hyeonki Hong <hhk7734@gmail.com> wrote:
> On Wed, Jun 10, 2020 at 03:09:42PM +0200, Jerome Brunet wrote:
>>
>> On Wed 10 Jun 2020 at 06:13, hhk7734@gmail.com wrote:
>>
>> > From: Hyeonki Hong <hhk7734@gmail.com>
>> >
>> > If a GPIO bank has greater than 16 pins, PAD_DS_REG is split into two
>> > registers. However, when register and bit were calculated, the first
>> > register defined in the bank was used, and the bit was calculated based
>> > on the first pin. This causes problems in setting the driving strength.
>> >
>> > Solved the problem by changing the bit using a mask and selecting the
>> > next register when the bit exceeds 15.
>>
>> This fixes the case of GPIOX on g12 which goes up to 18 yes but the same
>> problem will happen again a if bank ever goes past 31 pins. In such case
>> the problem would apply to all reg types.
>>
>> I would prefer if it was solved in a more generic fashion, like defining
>> a "stride" table with the values of each reg type. This table can common
>> to all aml SoCs for now but eventually it probably need to be SoC
>> specific.
>>
>> This would allow to :
>> A) handle the case you are reporting in a generic (future proof) way
>> B) remove the weird "bit = bit << 1;" calc in place in the get/set of
>> the drive strengh pinconf
>
> If all amlogic SoC has same register style, I think the code below is fine.
>
> static const unsigned int meson_bit_strides[] = {
> 0, 0, 0, 0, 0, 1, 0
> };
the table above is the shift, not the stride.
Maybe 'width' is a better description
I would prefer if it was { 1, 1, 1, 1, 1, 2, 1 } and adjust the caculation
A part from this, your proposition is exactly what I meant :) Thx
>
> static void meson_calc_reg_and_bit(struct meson_bank *bank, unsigned int pin,
> enum meson_reg_type reg_type,
> unsigned int *reg, unsigned int *bit)
> {
> struct meson_reg_desc *desc = &bank->regs[reg_type];
>
> *bit = (desc->bit + pin - bank->first) << meson_bit_strides[reg_type];
> *reg = (desc->reg + (*bit / 32)) * 4;
> *bit &= 0x1f;
> }
>
> How about this?
>
>> >
>> > Signed-off-by: Hyeonki Hong <hhk7734@gmail.com>
>> > ---
>> > drivers/pinctrl/meson/pinctrl-meson.c | 7 +++++++
>> > 1 file changed, 7 insertions(+)
>> >
>> > diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
>> > index bbc919bef2bf..ef66239b7df5 100644
>> > --- a/drivers/pinctrl/meson/pinctrl-meson.c
>> > +++ b/drivers/pinctrl/meson/pinctrl-meson.c
>> > @@ -98,6 +98,13 @@ static void meson_calc_reg_and_bit(struct meson_bank *bank, unsigned int pin,
>> >
>> > *reg = desc->reg * 4;
>> > *bit = desc->bit + pin - bank->first;
>> > +
>> > + if (reg_type == REG_DS) {
>> > + if (*bit > 15) {
>> > + *bit &= 0xf;
>> > + *reg += 4;
>> > + }
>> > + }
>> > }
>> >
>> > static int meson_get_groups_count(struct pinctrl_dev *pcdev)
>>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2020-06-17 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 4:13 [PATCH] pinctrl: meson: fix drive strength register and bit calculation hhk7734
2020-06-10 13:09 ` Jerome Brunet
2020-06-11 5:40 ` Hyeonki Hong
2020-06-17 13:59 ` Jerome Brunet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jeeqd3i9k.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=hhk7734@gmail.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).