linux-amlogic.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Jerome Brunet <jbrunet@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
	linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH 7/7] clk: meson: axg_audio: add sm1 support
Date: Fri, 27 Sep 2019 16:01:42 +0200	[thread overview]
Message-ID: <1jftkh25yx.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <22415bc6-2550-d927-93e0-88f6aa2bee9d@baylibre.com>


On Fri 27 Sep 2019 at 11:36, Neil Armstrong <narmstrong@baylibre.com> wrote:

>>  
>>  static struct clk_regmap spdifout_clk_sel =
>>  	AUD_MST_MCLK_MUX(spdifout_clk, AUDIO_CLK_SPDIFOUT_CTRL);
>> @@ -502,7 +522,6 @@ static struct clk_regmap tdmout_c_lrclk =
>>  	AUD_TDM_LRLCK(out_c, AUDIO_CLK_TDMOUT_C_CTRL);
>>  
>>  /* AXG/G12A Clocks */
>> -
>
> Spurious line remove

Oops, I'll migrate that to the appropriate change, Thx

>
>>  static struct clk_hw axg_aud_top = {
>>  	.init = &(struct clk_init_data) {
>>  		/* Provide aud_top signal name on axg and g12a */
>> @@ -573,7 +592,185 @@ static struct clk_regmap g12a_tdm_sclk_pad_2 = AUD_TDM_PAD_CTRL(
>
> Small nit, but:
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

      reply	other threads:[~2019-09-27 14:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24 15:33 [PATCH 0/7] clk: meson: axg-audio: add sm1 support Jerome Brunet
2019-09-24 15:33 ` [PATCH 1/7] dt-bindings: clk: axg-audio: add sm1 bindings Jerome Brunet
2019-09-27  9:10   ` Neil Armstrong
2019-09-24 15:33 ` [PATCH 2/7] dt-bindings: clock: meson: add sm1 resets to the axg-audio controller Jerome Brunet
2019-09-27  9:10   ` Neil Armstrong
2019-09-24 15:33 ` [PATCH 3/7] clk: meson: axg-audio: remove useless defines Jerome Brunet
2019-09-27  9:10   ` Neil Armstrong
2019-09-24 15:33 ` [PATCH 4/7] clk: meson: axg-audio: fix regmap last register Jerome Brunet
2019-09-27  9:11   ` Neil Armstrong
2019-09-24 15:33 ` [PATCH 5/7] clk: meson: axg-audio: prepare sm1 addition Jerome Brunet
2019-09-27  9:13   ` Neil Armstrong
2019-09-24 15:33 ` [PATCH 6/7] clk: meson: axg-audio: provide clk top signal name Jerome Brunet
2019-09-27  9:14   ` Neil Armstrong
2019-09-27  9:37     ` Neil Armstrong
2019-09-27 13:58       ` Jerome Brunet
2019-09-27 14:07         ` Neil Armstrong
2019-09-24 15:33 ` [PATCH 7/7] clk: meson: axg_audio: add sm1 support Jerome Brunet
2019-09-27  9:36   ` Neil Armstrong
2019-09-27 14:01     ` Jerome Brunet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1jftkh25yx.fsf@starbuckisacylon.baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).