From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B470C76195 for ; Mon, 27 Mar 2023 10:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C+d49btPok2vFlyrJE8e2qYk1YZNtKidy3Eb8SFMhMQ=; b=rb7rMWtFqqXICC phkjvhTkU6O9oWKZIkmCWrzylV46/x8YSseBNpI7GatWFqFqwTCgxjQcv0iiAAY+o/Q3HY0t/cluZ 7j7qAWpLcG3swRspUiDVB08Mw1mw105/7qSzOAqgzND8zZ2GAcJDEpIy0wuGPtm0ixa7VM2r3EQaw Y52mEqdHcJVOYb3B45c6q5U6pqFuEVaOS7xrid28qTuCDLbO6bdJbbKDnTLftE/WeG98VmcSPVwDy TmqFbgmGxk/PulXb74jYm7wtM5FApixcVAIAn5znnOlJpynlnUdchWkRFDtpxeAa891rJ++abtyTR 8e5126WRWIQTCQRuWUJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgjxh-00AcYm-0o; Mon, 27 Mar 2023 10:20:25 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgjxe-00AcXj-2S for linux-amlogic@lists.infradead.org; Mon, 27 Mar 2023 10:20:24 +0000 Received: by mail-wm1-x329.google.com with SMTP id o24-20020a05600c511800b003ef59905f26so4842216wms.2 for ; Mon, 27 Mar 2023 03:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; t=1679912421; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=j0+1oYuXm7BJjPeE4MUkuJBSiJWTL5a+EppFIuNb5vg=; b=nRUJPwIpuWJC/QeZyVPrcpgncILzPdTy+iFY8Qag96pNIrqtndXxzrv2a/fyLd9osB dKnLAPPcY0YR+cG8KsAjboYGzp4vW2lv15djJ11qu8X7GZ2/nJSHyprCsV5BVjSe6w4v z8N3WySseIxqE85jv/ujiEpZl0+rme5j1k1U9f++joukENIBf3Xav+neaZXpVreR6uRt tzwSDQ5RHAWbtlMGXTZN/svqXxdMYyfCBkgM0bP2BW/xXbARX0SdVJA3Sh9XXjgi6jZT QiOG4sxPfbXxxhUEAsJxZqAnYbpl0UTSS64wCQHZG5at1kJDmUk11plaTEFvewFZ+z4U 0hHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679912421; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j0+1oYuXm7BJjPeE4MUkuJBSiJWTL5a+EppFIuNb5vg=; b=oC9AJOYnDUjwCqGudOsr26bw61ZxEnYMSQB34U6+w97ZTONFPLwD1U2oSZtFO4QnnH SwEqGoDVwNtlj76yQ0TRTwgUC+Pf63syv8834DgsYjqB93GtdIFIgQfCabFOW5dAJi9w Si+UahMwYOiGWhPkhb61HO1jh1ykC1COeYf4kGV0ihIiWGLJ8KdWeFhpvWHiyKdRgPQo QR6FbTO00Wc0Mg55lfp7VEa79lcGrNDqSYbUPE2XbwPg2ClyOoHwVp0TMx3gqtpn2iAv UOIdjqvBRhGRZqg32NwKBF6Y8tW41ic7zqHXO+t54IdZF51ipoxqOhcXZGGbw46K92PZ Pk0g== X-Gm-Message-State: AO0yUKXEKU67mKHcmVgXJnlZqDOG/486vwjXeJ0yfZj2VPqtITtV2nSf bwkHt/+9M4vVEFg7RAjC+DNcIw== X-Google-Smtp-Source: AK7set9OVXr25yXitlIVGdLEcdaSgx7Pmgggfqqg0gs+halm3xWhSdrDrHSPfjSs9f/EeUOUciBplg== X-Received: by 2002:a1c:790b:0:b0:3ee:7022:5eda with SMTP id l11-20020a1c790b000000b003ee70225edamr8948305wme.7.1679912420729; Mon, 27 Mar 2023 03:20:20 -0700 (PDT) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id f6-20020a05600c154600b003ef7058ea02sm1776253wmg.29.2023.03.27.03.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 03:20:20 -0700 (PDT) References: <20230321193014.26349-1-ddrokosov@sberdevices.ru> <20230321193014.26349-4-ddrokosov@sberdevices.ru> User-agent: mu4e 1.8.13; emacs 28.2 From: Jerome Brunet To: Dmitry Rokosov , neil.armstrong@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, khilman@baylibre.com, martin.blumenstingl@googlemail.com Cc: jian.hu@amlogic.com, kernel@sberdevices.ru, rockosov@gmail.com, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v11 3/5] dt-bindings: clock: meson: add A1 PLL and Peripherals clkcs bindings Date: Mon, 27 Mar 2023 11:51:21 +0200 In-reply-to: <20230321193014.26349-4-ddrokosov@sberdevices.ru> Message-ID: <1jmt3yo5r0.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230327_032022_799585_C695DC63 X-CRM114-Status: GOOD ( 16.89 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue 21 Mar 2023 at 22:30, Dmitry Rokosov wrote: > Add the documentation for Amlogic A1 PLL and Amlogic A1 Peripherals > clock drivers. > Introduce Amlogic A1 PLL and Amlogic A1 Peripherals device tree > bindings and include them to MAINTAINERS. > > Signed-off-by: Jian Hu > Signed-off-by: Dmitry Rokosov > --- > .../bindings/clock/amlogic,a1-clkc.yaml | 73 +++++++++++ > .../bindings/clock/amlogic,a1-pll-clkc.yaml | 59 +++++++++ > MAINTAINERS | 1 + > include/dt-bindings/clock/amlogic,a1-clkc.h | 113 ++++++++++++++++++ > .../dt-bindings/clock/amlogic,a1-pll-clkc.h | 21 ++++ > 5 files changed, 267 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml > create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml There is two drivers (and 2 independent patches). There should be 2 bindings patches as well. > create mode 100644 include/dt-bindings/clock/amlogic,a1-clkc.h > create mode 100644 include/dt-bindings/clock/amlogic,a1-pll-clkc.h > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml > new file mode 100644 > index 000000000000..cb6d8f4eb959 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-clkc.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/amlogic,a1-clkc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic Meson A/C serials Peripheral Clock Control Unit > + > +maintainers: > + - Neil Armstrong > + - Jerome Brunet > + - Jian Hu > + - Dmitry Rokosov > + > +properties: > + compatible: > + const: amlogic,a1-clkc > + > + '#clock-cells': > + const: 1 > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: input fixed pll div2 > + - description: input fixed pll div3 > + - description: input fixed pll div5 > + - description: input fixed pll div7 > + - description: input hifi pll > + - description: input oscillator (usually at 24MHz) > + > + clock-names: > + items: > + - const: fclk_div2 > + - const: fclk_div3 > + - const: fclk_div5 > + - const: fclk_div7 > + - const: hifi_pll > + - const: xtal > + > +required: > + - compatible > + - '#clock-cells' > + - reg > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include > + apb { > + #address-cells = <2>; > + #size-cells = <2>; > + > + clock-controller@800 { > + compatible = "amlogic,a1-clkc"; > + reg = <0 0x800 0 0x104>; > + #clock-cells = <1>; > + clocks = <&clkc_pll CLKID_FCLK_DIV2>, > + <&clkc_pll CLKID_FCLK_DIV3>, > + <&clkc_pll CLKID_FCLK_DIV5>, > + <&clkc_pll CLKID_FCLK_DIV7>, > + <&clkc_pll CLKID_HIFI_PLL>, > + <&xtal>; > + clock-names = "fclk_div2", "fclk_div3", > + "fclk_div5", "fclk_div7", > + "hifi_pll", "xtal"; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml > new file mode 100644 > index 000000000000..77a13b1f9d5a > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/amlogic,a1-pll-clkc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic Meson A/C serials PLL Clock Control Unit > + > +maintainers: > + - Neil Armstrong > + - Jerome Brunet > + - Jian Hu > + - Dmitry Rokosov > + > +properties: > + compatible: > + const: amlogic,a1-pll-clkc > + > + '#clock-cells': > + const: 1 > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: input fixpll_in > + - description: input hifipll_in > + > + clock-names: > + items: > + - const: fixpll_in > + - const: hifipll_in > + > +required: > + - compatible > + - '#clock-cells' > + - reg > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include > + apb { > + #address-cells = <2>; > + #size-cells = <2>; > + > + clock-controller@7c80 { > + compatible = "amlogic,a1-pll-clkc"; > + reg = <0 0x7c80 0 0x18c>; > + #clock-cells = <1>; > + clocks = <&clkc_periphs CLKID_FIXPLL_IN>, > + <&clkc_periphs CLKID_HIFIPLL_IN>; > + clock-names = "fixpll_in", "hifipll_in"; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 39ff1a717625..8438bc9bd636 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1895,6 +1895,7 @@ L: linux-amlogic@lists.infradead.org > S: Maintained > F: Documentation/devicetree/bindings/clock/amlogic* > F: drivers/clk/meson/ > +F: include/dt-bindings/clock/a1* > F: include/dt-bindings/clock/gxbb* > F: include/dt-bindings/clock/meson* > > diff --git a/include/dt-bindings/clock/amlogic,a1-clkc.h b/include/dt-bindings/clock/amlogic,a1-clkc.h > new file mode 100644 > index 000000000000..95131779982c > --- /dev/null > +++ b/include/dt-bindings/clock/amlogic,a1-clkc.h > @@ -0,0 +1,113 @@ > +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */ > +/* > + * Copyright (c) 2019 Amlogic, Inc. All rights reserved. > + * Author: Jian Hu > + * > + * Copyright (c) 2023, SberDevices. All Rights Reserved. > + * Author: Dmitry Rokosov > + */ > + > +#ifndef __A1_CLKC_H > +#define __A1_CLKC_H > + > +#define CLKID_FIXPLL_IN 0 > +#define CLKID_USB_PHY_IN 1 > +#define CLKID_USB_CTRL_IN 2 > +#define CLKID_HIFIPLL_IN 3 > +#define CLKID_SYSPLL_IN 4 > +#define CLKID_DDS_IN 5 > +#define CLKID_SYS 6 > +#define CLKID_CLKTREE 7 > +#define CLKID_RESET_CTRL 8 > +#define CLKID_ANALOG_CTRL 9 > +#define CLKID_PWR_CTRL 10 > +#define CLKID_PAD_CTRL 11 > +#define CLKID_SYS_CTRL 12 > +#define CLKID_TEMP_SENSOR 13 > +#define CLKID_AM2AXI_DIV 14 > +#define CLKID_SPICC_B 15 > +#define CLKID_SPICC_A 16 > +#define CLKID_MSR 17 > +#define CLKID_AUDIO 18 > +#define CLKID_JTAG_CTRL 19 > +#define CLKID_SARADC_EN 20 > +#define CLKID_PWM_EF 21 > +#define CLKID_PWM_CD 22 > +#define CLKID_PWM_AB 23 > +#define CLKID_CEC 24 > +#define CLKID_I2C_S 25 > +#define CLKID_IR_CTRL 26 > +#define CLKID_I2C_M_D 27 > +#define CLKID_I2C_M_C 28 > +#define CLKID_I2C_M_B 29 > +#define CLKID_I2C_M_A 30 > +#define CLKID_ACODEC 31 > +#define CLKID_OTP 32 > +#define CLKID_SD_EMMC_A 33 > +#define CLKID_USB_PHY 34 > +#define CLKID_USB_CTRL 35 > +#define CLKID_SYS_DSPB 36 > +#define CLKID_SYS_DSPA 37 > +#define CLKID_DMA 38 > +#define CLKID_IRQ_CTRL 39 > +#define CLKID_NIC 40 > +#define CLKID_GIC 41 > +#define CLKID_UART_C 42 > +#define CLKID_UART_B 43 > +#define CLKID_UART_A 44 > +#define CLKID_SYS_PSRAM 45 > +#define CLKID_RSA 46 > +#define CLKID_CORESIGHT 47 > +#define CLKID_AM2AXI_VAD 48 > +#define CLKID_AUDIO_VAD 49 > +#define CLKID_AXI_DMC 50 > +#define CLKID_AXI_PSRAM 51 > +#define CLKID_RAMB 52 > +#define CLKID_RAMA 53 > +#define CLKID_AXI_SPIFC 54 > +#define CLKID_AXI_NIC 55 > +#define CLKID_AXI_DMA 56 > +#define CLKID_CPU_CTRL 57 > +#define CLKID_ROM 58 > +#define CLKID_PROC_I2C 59 > +#define CLKID_DSPA_EN 60 > +#define CLKID_DSPA_EN_NIC 61 > +#define CLKID_DSPB_EN 62 > +#define CLKID_DSPB_EN_NIC 63 > +#define CLKID_RTC 64 > +#define CLKID_CECA_32K 65 > +#define CLKID_CECB_32K 66 > +#define CLKID_24M 67 > +#define CLKID_12M 68 > +#define CLKID_FCLK_DIV2_DIVN 69 > +#define CLKID_GEN 70 > +#define CLKID_SARADC 71 > +#define CLKID_PWM_A 72 > +#define CLKID_PWM_B 73 > +#define CLKID_PWM_C 74 > +#define CLKID_PWM_D 75 > +#define CLKID_PWM_E 76 > +#define CLKID_PWM_F 77 > +#define CLKID_SPICC 78 > +#define CLKID_TS 79 > +#define CLKID_SPIFC 80 > +#define CLKID_USB_BUS 81 > +#define CLKID_SD_EMMC 82 > +#define CLKID_PSRAM 83 > +#define CLKID_DMC 84 > +#define CLKID_GEN_SEL 85 > +#define CLKID_PWM_A_SEL 86 > +#define CLKID_PWM_B_SEL 87 > +#define CLKID_PWM_C_SEL 88 > +#define CLKID_PWM_D_SEL 89 > +#define CLKID_PWM_E_SEL 90 > +#define CLKID_PWM_F_SEL 91 > +#define CLKID_DSPA_A_SEL 92 > +#define CLKID_DSPA_B_SEL 93 > +#define CLKID_DSPB_A_SEL 94 > +#define CLKID_DSPB_B_SEL 95 > +#define CLKID_CECA_32K_SEL 96 > +#define CLKID_CECB_32K_SEL 97 > +#define NR_CLKS 98 > + > +#endif /* __A1_CLKC_H */ > diff --git a/include/dt-bindings/clock/amlogic,a1-pll-clkc.h b/include/dt-bindings/clock/amlogic,a1-pll-clkc.h > new file mode 100644 > index 000000000000..740fe8c4db5d > --- /dev/null > +++ b/include/dt-bindings/clock/amlogic,a1-pll-clkc.h > @@ -0,0 +1,21 @@ > +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */ > +/* > + * Copyright (c) 2019 Amlogic, Inc. All rights reserved. > + * Author: Jian Hu > + * > + * Copyright (c) 2023, SberDevices. All Rights Reserved. > + * Author: Dmitry Rokosov > + */ > + > +#ifndef __A1_PLL_CLKC_H > +#define __A1_PLL_CLKC_H > + > +#define CLKID_FIXED_PLL 0 > +#define CLKID_FCLK_DIV2 1 > +#define CLKID_FCLK_DIV3 2 > +#define CLKID_FCLK_DIV5 3 > +#define CLKID_FCLK_DIV7 4 > +#define CLKID_HIFI_PLL 5 > +#define NR_PLL_CLKS 6 > + > +#endif /* __A1_PLL_CLKC_H */ _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic