Re: [PATCH] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string

From: "Richter, Robert" <Robert.Richter@cavium.com>
To: Rob Herring <robh@kernel.org>
Cc: "Nishanth Menon" <nm@ti.com>, "Andrew Lunn" <andrew@lunn.ch>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Maxime Ripard" <maxime.ripard@bootlin.com>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"Liviu Dudau" <liviu.dudau@arm.com>,
	"David Brown" <david.brown@linaro.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Wei Xu" <xuwei5@hisilicon.com>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"Nair, Jayachandran" <Jayachandran.Nair@cavium.com>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	"linux-rockchip@lists.infradead.org"
	<linux-rockchip@lists.infradead.org>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Gregory Clement" <gregory.clement@bootlin.com>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	"Chen-Yu Tsai" <wens@csie.org>, "arm@kernel.org" <arm@kernel.org>,
	"bcm-kernel-feedback-list@broadcom.com"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Baolin Wang" <baolin.wang@linaro.org>,
	"Andy Gross" <andy.gross@linaro.org>,
	"Orson Zhai" <orsonzhai@gmail.com>,
	"Tsahee Zidenberg" <tsahee@annapurnalabs.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"Jason Cooper" <jason@lakedaemon.net>,
	"Antoine Tenart" <antoine.tenart@bootlin.com>,
	"Ray Jui" <rjui@broadcom.com>,
	"Simon Horman" <horms@verge.net.au>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"linux-amlogic@lists.infradead.org"
	<linux-amlogic@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Will Deacon" <will.deacon@arm.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Masahiro Yamada" <yamada.masahiro@socionext.com>,
	"Chunyan Zhang" <zhang.lyra@gmail.com>,
	"Chanho Min" <chanho.min@lge.com>, "Duc Dang" <dhdang@apm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Tero Kristo" <t-kristo@ti.com>,
	"Dinh Nguyen" <dinguyen@kernel.org>,
	"Jisheng Zhang" <Jisheng.Zhang@synaptics.com>,
	"Kukjin Kim" <kgene@kernel.org>,
	"Sudeep Holla" <sudeep.holla@arm.com>,
	"Jun Nie" <jun.nie@linaro.org>,
	"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [PATCH] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string
Date: Tue, 15 Jan 2019 08:45:53 +0000	[thread overview]
Message-ID: <20190115084537.3hedrtkowg3elzca@rric.localdomain> (raw)
In-Reply-To: <CAL_JsqKMYY5RsCjzp4eMnW0YrohcqwmhVj0hfUEVrbGJEFx05w@mail.gmail.com>

On 11.01.19 07:57:12, Rob Herring wrote:
> On Thu, Jan 10, 2019 at 8:18 PM Richter, Robert
> <Robert.Richter@cavium.com> wrote:
> >
> > Rob,
> >
> > On 09.01.19 14:29:34, Rob Herring wrote:
> > > The 'arm,armv8' compatible string is only for software models. It adds
> > > little value otherwise and is inconsistently used as a fallback on some
> > > platforms. Remove it from those platforms.
> > >
> > > This fixes warnings generated by the DT schema.
> > >
> > > Reported-by: Michal Simek <michal.simek@xilinx.com>
> > > Cc: Mark Rutland <mark.rutland@arm.com>
> > > Cc: Will Deacon <will.deacon@arm.com>
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > ---
> > > armsoc folks, Please apply directly.
> >
> > > diff --git a/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi b/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi
> > > index ff5c4c47b22b..c616132f7d6d 100644
> > > --- a/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi
> > > +++ b/arch/arm64/boot/dts/cavium/thunder2-99xx.dtsi
> > > @@ -27,28 +27,28 @@
> > >
> > >                 cpu@0 {
> > >                         device_type = "cpu";
> > > -                       compatible = "cavium,thunder2", "brcm,vulcan", "arm,armv8";
> > > +                       compatible = "cavium,thunder2";
> >
> > We are just checking if removing the "brcm,vulcan" string has any
> > impact on early silicon revisions we want to support (see also
> > BRCM_CPU_PART_VULCAN).
> >
> > Maybe you make this a separate change?
> 
> Dropping brcm,vulcan was unintentional (regex fail). Though keeping it
> means we need a schema change as it was not documented to be a
> fallback.

We have checked this and brcm,vulcan can be dropped too. Sending an
ack in a separate mail.

Thanks,

-Robert

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic