From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66EF0C43387 for ; Thu, 17 Jan 2019 16:46:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3758620856 for ; Thu, 17 Jan 2019 16:46:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pgKqryUY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="XpIqV969" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3758620856 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LghBaTQXvVex70qQcwpb2WhTILes8VVE8U2vBJFpXhY=; b=pgKqryUY+8vPMT a++jkgtlm3vpKex/8QyllS4yQjJCCJ4VdSNdtbZIrnwFK7iaJXaXqaikE6gHk32ed93aYYjy7KpU1 L2mT8E9FcAUrL6SdfIyp+l9AmNtQV0dlWmcROpI7qiUR3MOpeWkOO2sosP2FcE5VeivfNge+UesT9 QXr9jyIa77fznJhhxiQyk5ItNJq7YNQXc+uHmTfQmtjyVDkVyp8lzWDw5T18EtAET3Tfrsuf2NvcA FmPmAI6cQwD6KcC4FcTVbCQS6D9Es4UZGxdRTudYj+xBumsIN9B9DHqV7nrYZ95fpdevZPw7bJolc Nq+hpvw7gFNqbEVXQvqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkAng-00085W-30; Thu, 17 Jan 2019 16:45:52 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkAnb-00083l-IF for linux-amlogic@lists.infradead.org; Thu, 17 Jan 2019 16:45:49 +0000 Received: by mail-ed1-x544.google.com with SMTP id d39so8833368edb.12 for ; Thu, 17 Jan 2019 08:45:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G44vzWv8v93dtiLWgCKhFpfQv+w1VJ2+/PDzCiGfXJg=; b=XpIqV969SvphAZ4y55B9XsKLgH5TOJSk0+trqqG8gDbFtpm4Avk64xaCR7WNFFsl5S JMleF9lJImURSKKsp62Ic+TwgHzTXVrtXdZPwnZwJH3YhEsrURl89JNSvJGmelZGHx2G 5Z521lKbdU6z8w08x0T017vudJpBi/+iK7KBk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=G44vzWv8v93dtiLWgCKhFpfQv+w1VJ2+/PDzCiGfXJg=; b=m3DrXDcPhvu47BbFUx4zQy571KlJYDDGKK5BJgX8TXUxOV/V31QUDweoXj7Md+K8C/ FaRctpTmmPrA5Nb879MexxkqS7DH7mHq1rCwbJY5sSVDXa4lflP2jBTvP2Qyq+jRgXk0 kEo4+ByZtuDAbBFeHcxxdahVxOsYIXXKbN9XBYRunulpfT5sAfoGchS4+ZfRmdxwviwO tQSioXafgRxecLNtU/T/io8Ofo1IyF61CMGzlrB9kiG5ndnbPGplci4V2Rp+EZ+v8U/5 4nBwjNhlCo6X3gE7XfcAUsEBHyg3uFt3kwOMTY06ueLPbNKFHEnKR5Jv78h3CkD9zZ2p +cug== X-Gm-Message-State: AJcUukciAu8Fxo3d6GrQMR0dmu+kwxPrDWjKsBZojNGysLDu+e0o9pU1 UygTkAnorMmoPmOa1sTH+yr7Fg== X-Google-Smtp-Source: ALg8bN48Ho/mM8Q7a3cuSaUxZAOeetJgITKLeb5lpfoqSNcRkQ2JHWoWIcrUFnFvvuK4Y1nyvIf4ig== X-Received: by 2002:a17:906:3105:: with SMTP id 5-v6mr11397796ejx.122.1547743544951; Thu, 17 Jan 2019 08:45:44 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id g37sm6730501edb.85.2019.01.17.08.45.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jan 2019 08:45:44 -0800 (PST) Date: Thu, 17 Jan 2019 17:45:41 +0100 From: Daniel Vetter To: Sam Ravnborg Subject: Re: [PATCH] drm: Split out drm_probe_helper.h Message-ID: <20190117164541.GE3271@phenom.ffwll.local> References: <20190116163442.12622-1-daniel.vetter@ffwll.ch> <20190116181018.GA27364@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190116181018.GA27364@ravnborg.org> X-Operating-System: Linux phenom 4.19.0-1-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190117_084547_687543_AD713328 X-CRM114-Status: GOOD ( 16.91 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Daniel Vetter , Liviu Dudau , DRI Development , virtualization@lists.linux-foundation.org, Laurent Pinchart , Benjamin Gaignard , Daniel Vetter , linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, Oleksandr Andrushchenko , amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, nouveau@lists.freedesktop.org, CK Hu , spice-devel@lists.freedesktop.org, Jani Nikula , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, etnaviv@lists.freedesktop.org, Jani Nikula , linux-mediatek@lists.infradead.org, Rodrigo Vivi , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xen.org, linux-renesas-soc@vger.kernel.org, Alex Deucher , freedreno@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed, Jan 16, 2019 at 07:10:18PM +0100, Sam Ravnborg wrote: > Hi Daniel. > > > v5: Actually try to sort them, and while at it, sort all the ones I > > touch. > > Applied this variant on top of drm-misc and did a build test. > Looked good for ia64, x86 and alpha. > > Took a closer look at the changes to atmel_hlcd - and they looked OK. > > But I noticed that atmel_hlcdc uses only drm_kms_helper_poll_init() and > drm_kms_helper_poll_fini(). > But there are no hits on DRM_CONNECTOR_POLL - so I think we maybe > have a driver here where we have plugged the drm_poll infrastructure, > but it is not in use. > > > include/drm/drm_crtc_helper.h | 16 ----------- > > The list of include files in this file could be dropped and replaced by: > struct drm_connector; > struct drm_device; > struct drm_display_mode; > struct drm_encoder; > struct drm_framebuffer; > struct drm_mode_set; > struct drm_modeset_acquire_ctx; > > I tried to do so on top of your patch. > But there were too many build errros and I somehow lost the motivation. Yeah the drm_crtc_helper.h header is a bit the miniature drmP.h for legacy kms drivers. Just removing it from all the atomic drivers caused lots of fallout, I expect even more if you entirely remove the includes it has. Maybe a todo, care to pls create that patch since it's your idea? -Daniel > > > > include/drm/drm_probe_helper.h | 27 +++++++++++++++++++ > This on the other hand is fine - as expected as this is a new file. > > But the above is just some random comments so: > > Acked-by: Sam Ravnborg -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic