From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D22EC282C7 for ; Tue, 29 Jan 2019 10:26:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EEB721473 for ; Tue, 29 Jan 2019 10:26:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dvUElDhi"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tT6HRKwN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EEB721473 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XID6RM/eDZKRhEPHFvRvIySbr4KPz6JOWpRsnEEINCI=; b=dvUElDhi70TTEX rffRCmE6TOlLPjDZP7b5hMLyksH+dLRhcmWg09NmvA4BDGhkVsEefejTiiLlvh9yZ80miZ8PLr41T wgDqQnGo9ahcT4B0AFqup54vj7tFfn+aWMM9r+RUQ26bqXJuiJDUBKSzsx//UZ25/89FRX/JzNPVG GuFOQ8yg95RRQNeDvNhMCQ0n4clVNGLyBa9lVs0p8Ac3UknwyzGmIw/nkTd61ntSURbDeIxEkt5K0 UK8X+LHuZg3rSSujxn4Y/UlCq6ZnXSXwCBmHQNE1JAwY9eIHcZ+qyR0fDSDreXrG7OslTzAmhglpG mbAUogTaP97KIqiM5IEw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1goQan-0002bt-VC; Tue, 29 Jan 2019 10:26:10 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1goQaQ-0002K5-B4; Tue, 29 Jan 2019 10:25:50 +0000 Received: by mail-pg1-x543.google.com with SMTP id v28so8555449pgk.10; Tue, 29 Jan 2019 02:25:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/mz1GCPGNj2WDwAfONjKQvSJS/qM5Bd+vzAaodwt2AI=; b=tT6HRKwNFozta4dPNaoKCXZVZ3/a8J5kz+UHuPAKNVPSJkjVBnKG5suITfhCKmXWUA KESYT55yTxiftdKTmQXEKbRcd0Azt+jsJ6mKTHv5ECUqraHcV7Y1b7KhY0YAgIFuIjxd U5lxXMj9zzc3D/Lx5E2UCiWWNNSbTCMejYrAlyVU+HS2A4EavUh5YXljQ5alxeCXJ5F5 rktJ8dANr27oJQm43UI8C/G/qj66bqu7rH7KLya2PbGmA0Hr4Pp7AVVtIWQ1l4T5BoC2 UbJw48nYSTe9NHzMmT5Cv3jURPS0h9Ur5mb4aHZsXdsEj33wlkPiK66bm7jI4leu7jDs gDRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/mz1GCPGNj2WDwAfONjKQvSJS/qM5Bd+vzAaodwt2AI=; b=rPlDF21YZfV+I609dhZBpFWngxwZaVM1lwTVJinn2kQmhEzHdCEJI1nVPvXfOg7/sH M3T+tYyjng7j7kc3iAPFcQ7gTMKCgri6n3i4yGnvKnujdfKEIiBsbEIY0Xvpv06nbQVw 5ozYbar5YCm6waapSsTpW6AR/LXzVtLD7NLac9l19e6PcW6LKIfIAC77IV+bsRBqGbPX BjjIXL1fq9tR3kudnRMBHo/8k+OBv7ccaZitUKUBzbHR+N33AM7J0f+7b5+VMcV/dUg5 zUh2/jbWXwfRmynFXv7ZbHhG3qjhkojdWcQ95nd9lqABN3sBuye5SCrnUfE5J4JtDZLs 6O5w== X-Gm-Message-State: AJcUukfvOg+h2TDsbsnvSMKZ6Cfz5zqeiaNkLjK1Y26cVnAxaVUVT/2S ekj+Xu/nzcpzBrc4GpqVyOk= X-Google-Smtp-Source: ALg8bN5vuagWU/RXuxT+Iq+7gHnJnqjghN25vx+jYD/w93xXKGHap9CGmeyPN1v9ltBVefPfxS21Fg== X-Received: by 2002:a62:3006:: with SMTP id w6mr25829827pfw.258.1548757545262; Tue, 29 Jan 2019 02:25:45 -0800 (PST) Received: from localhost.localdomain ([103.51.74.149]) by smtp.gmail.com with ESMTPSA id d21sm47744462pfo.162.2019.01.29.02.25.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 02:25:44 -0800 (PST) From: Anand Moon To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCHv3 2/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy regulator power failed warning Date: Tue, 29 Jan 2019 10:25:21 +0000 Message-Id: <20190129102521.4141-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190129102521.4141-1-linux.amoon@gmail.com> References: <20190129102521.4141-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190129_022546_403620_D2FE1247 X-CRM114-Status: GOOD ( 12.17 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Martin Blumenstingl , Kevin Hilman , Rob Herring , Jerome Brunet , Neil Armstrong Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Override the dr_mode from "host" to "otg" for USB_HOST controller (usb0) changes help usb_phy0->usb0 initialization of OTG bus port. Changes fix the below warning. [ 1.183681] dwc2 c9000000.usb: c9000000.usb supply vusb_d not found, using dummy regulator [ 1.190627] dwc2 c9000000.usb: Linked as a consumer to regulator.0 [ 1.196696] dwc2 c9000000.usb: c9000000.usb supply vusb_a not found, using dummy regulator [ 1.206094] phy phy-c0000000.phy.0: USB ID detect failed! [ 1.210243] phy phy-c0000000.phy.0: phy poweron failed --> -22 [ 1.216072] WARNING: CPU: 0 PID: 78 at drivers/regulator/core.c:2054 _regulator_put.part.11+0xf0/0xf8 [ 1.225147] Modules linked in: [ 1.228169] CPU: 0 PID: 78 Comm: kworker/0:1 Not tainted 5.0.0-rc4-xc2ml #1 [ 1.235066] Hardware name: Hardkernel ODROID-C2 (DT) [ 1.239987] Workqueue: events deferred_probe_work_func [ 1.245072] pstate: 80000005 (Nzcv daif -PAN -UAO) [ 1.249816] pc : _regulator_put.part.11+0xf0/0xf8 [ 1.254473] lr : regulator_put+0x34/0x48 [ 1.258353] sp : ffff0000117b3b00 [ 1.261630] x29: ffff0000117b3b00 x28: 0000000000000000 [ 1.266891] x27: ffff80007ec1a7b8 x26: ffff000010eec280 [ 1.272153] x25: 0000000000000000 x24: 0000000000000009 [ 1.277414] x23: ffff0000117b3bc8 x22: ffff80007ecd3c00 [ 1.282675] x21: ffff0000111ad6c8 x20: ffff80007ecd3e00 [ 1.287936] x19: ffff80007ecd3e00 x18: 0000000000000124 [ 1.293198] x17: 0000000000000000 x16: 0000000000000000 [ 1.298459] x15: 0000000000000400 x14: 0000000000000400 [ 1.303720] x13: ff00000000000000 x12: ffffffffffffffff [ 1.308981] x11: 0000000000000038 x10: 0000000000000040 [ 1.314243] x9 : ffff0000111c58b0 x8 : ffff0000111c58a8 [ 1.319504] x7 : ffff80006b055200 x6 : ffff80007edd2880 [ 1.324765] x5 : ffff80007f400248 x4 : ffff80007fb92b00 [ 1.330026] x3 : ffff0000112c9d58 x2 : ffff80007edd2880 [ 1.335288] x1 : 0000000000000000 x0 : 0000000000000001 [ 1.340549] Call trace: [ 1.342966] _regulator_put.part.11+0xf0/0xf8 [ 1.347278] regulator_put+0x34/0x48 [ 1.350814] regulator_bulk_free+0x30/0x50 [ 1.354868] devm_regulator_bulk_release+0x18/0x20 [ 1.359612] release_nodes+0x1b0/0x220 [ 1.363320] devres_release_all+0x34/0x50 [ 1.367288] really_probe+0xec/0x290 [ 1.370824] driver_probe_device+0x54/0xe8 [ 1.374878] __device_attach_driver+0xb8/0xe8 [ 1.379190] bus_for_each_drv+0x78/0xc8 [ 1.382985] __device_attach+0xd4/0x130 [ 1.386780] device_initial_probe+0x10/0x18 [ 1.390920] bus_probe_device+0x90/0x98 [ 1.394715] deferred_probe_work_func+0x6c/0xa0 [ 1.399203] process_one_work+0x1e0/0x318 [ 1.403168] worker_thread+0x228/0x428 [ 1.406877] kthread+0x124/0x128 [ 1.410070] ret_from_fork+0x10/0x18 [ 1.413603] ---[ end trace 498aca4cb07e5377 ]--- [ 1.418251] WARNING: CPU: 0 PID: 78 at drivers/regulator/core.c:2054 _regulator_put.part.11+0xf0/0xf8 [ 1.427316] Modules linked in: [ 1.430338] CPU: 0 PID: 78 Comm: kworker/0:1 Tainted: G W 5.0.0-rc4-xc2ml #1 [ 1.438615] Hardware name: Hardkernel ODROID-C2 (DT) [ 1.443534] Workqueue: events deferred_probe_work_func [ 1.448621] pstate: 80000005 (Nzcv daif -PAN -UAO) [ 1.453366] pc : _regulator_put.part.11+0xf0/0xf8 [ 1.458023] lr : regulator_put+0x34/0x48 [ 1.461903] sp : ffff0000117b3b00 [ 1.465180] x29: ffff0000117b3b00 x28: 0000000000000000 [ 1.470441] x27: ffff80007ec1a7b8 x26: ffff000010eec280 [ 1.475703] x25: 0000000000000000 x24: 0000000000000009 [ 1.480964] x23: ffff0000117b3bc8 x22: ffff80007ecd3c00 [ 1.486225] x21: ffff0000111ad6c8 x20: ffff80007ecd3f00 [ 1.491486] x19: ffff80007ecd3f00 x18: 0000000000000007 [ 1.496748] x17: 0000000000000000 x16: 0000000000000000 [ 1.502009] x15: 0000000000000400 x14: ffff80000531da90 [ 1.507270] x13: ffff80007f4ae050 x12: 0000000000000000 [ 1.512531] x11: ffff80007f4adff0 x10: 0000000000000040 [ 1.517793] x9 : ffff80000531da98 x8 : 0000000040000000 [ 1.523054] x7 : ffff80006b054700 x6 : 0000000000000001 [ 1.528315] x5 : ffff0000105a868c x4 : ffff80007edd2880 [ 1.533576] x3 : ffff0000112c9d58 x2 : ffff80007edd2880 [ 1.538838] x1 : 0000000000000000 x0 : 0000000000000001 [ 1.544098] Call trace: [ 1.546516] _regulator_put.part.11+0xf0/0xf8 [ 1.550828] regulator_put+0x34/0x48 [ 1.554364] regulator_bulk_free+0x30/0x50 [ 1.558417] devm_regulator_bulk_release+0x18/0x20 [ 1.563161] release_nodes+0x1b0/0x220 [ 1.566870] devres_release_all+0x34/0x50 [ 1.570838] really_probe+0xec/0x290 [ 1.574374] driver_probe_device+0x54/0xe8 [ 1.578428] __device_attach_driver+0xb8/0xe8 [ 1.582740] bus_for_each_drv+0x78/0xc8 [ 1.586535] __device_attach+0xd4/0x130 [ 1.590330] device_initial_probe+0x10/0x18 [ 1.594470] bus_probe_device+0x90/0x98 [ 1.598265] deferred_probe_work_func+0x6c/0xa0 [ 1.602751] process_one_work+0x1e0/0x318 [ 1.606718] worker_thread+0x228/0x428 [ 1.610427] kthread+0x124/0x128 [ 1.613618] ret_from_fork+0x10/0x18 [ 1.617153] ---[ end trace 498aca4cb07e5378 ]--- [ 1.621778] dwc2: probe of c9000000.usb failed with error -22 Fixes: 5a0803bd5ae (ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes) Cc: Martin Blumenstingl Cc: Jerome Brunet Cc: Neil Armstrong Signed-off-by: Anand Moon --- Changes from previous patch change dr_mode from "peripheral" to "otg" Since usb_phy0 is otg port as per the shematic Fixed the commit messages with latest warning This patch depend on this below patch [0] https://patchwork.kernel.org/patch/10777359/ /: Bus 02.Port 1: Dev 1, Class=root_hub, Driver=dwc2/1p, 480M |__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/4p, 480M |__ Port 1: Dev 4, If 0, Class=Mass Storage, Driver=usb-storage, 480M |__ Port 3: Dev 3, If 0, Class=Video, Driver=uvcvideo, 480M |__ Port 3: Dev 3, If 1, Class=Video, Driver=uvcvideo, 480M |__ Port 3: Dev 3, If 2, Class=Audio, Driver=, 480M |__ Port 3: Dev 3, If 3, Class=Audio, Driver=, 480M /: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=dwc2/1p, 480M drop tested but from Kevin --- arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts index da729ed00408..5d81ad02483b 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts @@ -312,6 +312,7 @@ &usb0 { status = "okay"; + dr_mode = "otg"; }; &usb1 { -- 2.20.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic