* [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init
@ 2019-01-29 10:57 Colin King
2019-01-30 5:20 ` Liang Yang
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Colin King @ 2019-01-29 10:57 UTC (permalink / raw)
To: Liang Yang, Boris Brezillon, Miquel Raynal, Richard Weinberger,
David Woodhouse, Brian Norris, Marek Vasut, Kevin Hilman,
linux-mtd, linux-arm-kernel, linux-amlogic
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The call to meson_chip_buffer_init is not assigning ret, however, ret
is being checked for failure. Fix this by adding in the missing assignment.
Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mtd/nand/raw/meson_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
index e858d58d97b0..b9c543d1054c 100644
--- a/drivers/mtd/nand/raw/meson_nand.c
+++ b/drivers/mtd/nand/raw/meson_nand.c
@@ -1206,7 +1206,7 @@ static int meson_nand_attach_chip(struct nand_chip *nand)
dev_err(nfc->dev, "16bits bus width not supported");
return -EINVAL;
}
- meson_chip_buffer_init(nand);
+ ret = meson_chip_buffer_init(nand);
if (ret)
return -ENOMEM;
--
2.19.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init 2019-01-29 10:57 [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init Colin King @ 2019-01-30 5:20 ` Liang Yang 2019-01-30 9:26 ` Liang Yang 2019-02-05 19:05 ` Miquel Raynal 2 siblings, 0 replies; 7+ messages in thread From: Liang Yang @ 2019-01-30 5:20 UTC (permalink / raw) To: Colin King, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut, Kevin Hilman, linux-mtd, linux-arm-kernel, linux-amlogic Cc: kernel-janitors, linux-kernel Hello Colin, On 2019/1/29 18:57, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The call to meson_chip_buffer_init is not assigning ret, however, ret > is being checked for failure. Fix this by adding in the missing assignment. > ok. thanks for your time. > Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash controller") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/mtd/nand/raw/meson_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c > index e858d58d97b0..b9c543d1054c 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -1206,7 +1206,7 @@ static int meson_nand_attach_chip(struct nand_chip *nand) > dev_err(nfc->dev, "16bits bus width not supported"); > return -EINVAL; > } > - meson_chip_buffer_init(nand); > + ret = meson_chip_buffer_init(nand); > if (ret) > return -ENOMEM; > > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init 2019-01-29 10:57 [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init Colin King 2019-01-30 5:20 ` Liang Yang @ 2019-01-30 9:26 ` Liang Yang 2019-01-30 9:32 ` Miquel Raynal 2019-02-05 19:05 ` Miquel Raynal 2 siblings, 1 reply; 7+ messages in thread From: Liang Yang @ 2019-01-30 9:26 UTC (permalink / raw) To: Colin King, Boris Brezillon, Miquel Raynal, Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut, Kevin Hilman, linux-mtd, linux-arm-kernel, linux-amlogic Cc: kernel-janitors, linux-kernel Hi Colin, On 2019/1/29 18:57, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The call to meson_chip_buffer_init is not assigning ret, however, ret > is being checked for failure. Fix this by adding in the missing assignment. > > Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash controller") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/mtd/nand/raw/meson_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c > index e858d58d97b0..b9c543d1054c 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -1206,7 +1206,7 @@ static int meson_nand_attach_chip(struct nand_chip *nand) > dev_err(nfc->dev, "16bits bus width not supported"); > return -EINVAL; > } > - meson_chip_buffer_init(nand); > + ret = meson_chip_buffer_init(nand); Looks good to me: Acked-by: Liang Yang <liang.yang@amlogic.com> > if (ret) > return -ENOMEM; > > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init 2019-01-30 9:26 ` Liang Yang @ 2019-01-30 9:32 ` Miquel Raynal 2019-01-30 9:34 ` Colin Ian King 0 siblings, 1 reply; 7+ messages in thread From: Miquel Raynal @ 2019-01-30 9:32 UTC (permalink / raw) To: Liang Yang Cc: Boris Brezillon, Richard Weinberger, kernel-janitors, linux-kernel, Marek Vasut, linux-mtd, Kevin Hilman, Colin King, linux-amlogic, Brian Norris, David Woodhouse, linux-arm-kernel Hi Liang, Colin, Liang Yang <liang.yang@amlogic.com> wrote on Wed, 30 Jan 2019 17:26:49 +0800: > Hi Colin, > > On 2019/1/29 18:57, Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > The call to meson_chip_buffer_init is not assigning ret, however, ret > > is being checked for failure. Fix this by adding in the missing assignment. > > > > Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash controller") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > --- > > drivers/mtd/nand/raw/meson_nand.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c > > index e858d58d97b0..b9c543d1054c 100644 > > --- a/drivers/mtd/nand/raw/meson_nand.c > > +++ b/drivers/mtd/nand/raw/meson_nand.c > > @@ -1206,7 +1206,7 @@ static int meson_nand_attach_chip(struct nand_chip *nand) > > dev_err(nfc->dev, "16bits bus width not supported"); > > return -EINVAL; > > } > > - meson_chip_buffer_init(nand); > > + ret = meson_chip_buffer_init(nand); > > Looks good to me: > > Acked-by: Liang Yang <liang.yang@amlogic.com> This is nand/next material, so if you don't mind I would like to squash the two fixes you sent into the original commit inserting the driver. Thanks, Miquèl _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init 2019-01-30 9:32 ` Miquel Raynal @ 2019-01-30 9:34 ` Colin Ian King 2019-01-30 9:43 ` Liang Yang 0 siblings, 1 reply; 7+ messages in thread From: Colin Ian King @ 2019-01-30 9:34 UTC (permalink / raw) To: Miquel Raynal, Liang Yang Cc: Boris Brezillon, Richard Weinberger, kernel-janitors, linux-kernel, Marek Vasut, linux-mtd, Kevin Hilman, linux-amlogic, Brian Norris, David Woodhouse, linux-arm-kernel On 30/01/2019 09:32, Miquel Raynal wrote: > Hi Liang, Colin, > > Liang Yang <liang.yang@amlogic.com> wrote on Wed, 30 Jan 2019 17:26:49 > +0800: > >> Hi Colin, >> >> On 2019/1/29 18:57, Colin King wrote: >>> From: Colin Ian King <colin.king@canonical.com> >>> >>> The call to meson_chip_buffer_init is not assigning ret, however, ret >>> is being checked for failure. Fix this by adding in the missing assignment. >>> >>> Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash controller") >>> Signed-off-by: Colin Ian King <colin.king@canonical.com> >>> --- >>> drivers/mtd/nand/raw/meson_nand.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c >>> index e858d58d97b0..b9c543d1054c 100644 >>> --- a/drivers/mtd/nand/raw/meson_nand.c >>> +++ b/drivers/mtd/nand/raw/meson_nand.c >>> @@ -1206,7 +1206,7 @@ static int meson_nand_attach_chip(struct nand_chip *nand) >>> dev_err(nfc->dev, "16bits bus width not supported"); >>> return -EINVAL; >>> } >>> - meson_chip_buffer_init(nand); >>> + ret = meson_chip_buffer_init(nand); >> >> Looks good to me: >> >> Acked-by: Liang Yang <liang.yang@amlogic.com> > > This is nand/next material, so if you don't mind I would like to squash > the two fixes you sent into the original commit inserting the driver. Sure, ok with me, squashing them makes sense. Colin > > > Thanks, > Miquèl > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init 2019-01-30 9:34 ` Colin Ian King @ 2019-01-30 9:43 ` Liang Yang 0 siblings, 0 replies; 7+ messages in thread From: Liang Yang @ 2019-01-30 9:43 UTC (permalink / raw) To: Colin Ian King, Miquel Raynal Cc: Boris Brezillon, Richard Weinberger, kernel-janitors, linux-kernel, Marek Vasut, linux-mtd, Kevin Hilman, linux-amlogic, Brian Norris, David Woodhouse, linux-arm-kernel Hi Miquel, Colin, On 2019/1/30 17:34, Colin Ian King wrote: > On 30/01/2019 09:32, Miquel Raynal wrote: >> Hi Liang, Colin, >> >> Liang Yang <liang.yang@amlogic.com> wrote on Wed, 30 Jan 2019 17:26:49 >> +0800: >> >>> Hi Colin, >>> >>> On 2019/1/29 18:57, Colin King wrote: >>>> From: Colin Ian King <colin.king@canonical.com> >>>> >>>> The call to meson_chip_buffer_init is not assigning ret, however, ret >>>> is being checked for failure. Fix this by adding in the missing assignment. >>>> >>>> Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash controller") >>>> Signed-off-by: Colin Ian King <colin.king@canonical.com> >>>> --- >>>> drivers/mtd/nand/raw/meson_nand.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c >>>> index e858d58d97b0..b9c543d1054c 100644 >>>> --- a/drivers/mtd/nand/raw/meson_nand.c >>>> +++ b/drivers/mtd/nand/raw/meson_nand.c >>>> @@ -1206,7 +1206,7 @@ static int meson_nand_attach_chip(struct nand_chip *nand) >>>> dev_err(nfc->dev, "16bits bus width not supported"); >>>> return -EINVAL; >>>> } >>>> - meson_chip_buffer_init(nand); >>>> + ret = meson_chip_buffer_init(nand); >>> >>> Looks good to me: >>> >>> Acked-by: Liang Yang <liang.yang@amlogic.com> >> >> This is nand/next material, so if you don't mind I would like to squash >> the two fixes you sent into the original commit inserting the driver. > > Sure, ok with me, squashing them makes sense. > > Colin ok. >> >> >> Thanks, >> Miquèl >> > > . > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init 2019-01-29 10:57 [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init Colin King 2019-01-30 5:20 ` Liang Yang 2019-01-30 9:26 ` Liang Yang @ 2019-02-05 19:05 ` Miquel Raynal 2 siblings, 0 replies; 7+ messages in thread From: Miquel Raynal @ 2019-02-05 19:05 UTC (permalink / raw) To: Colin King Cc: Boris Brezillon, Richard Weinberger, kernel-janitors, linux-kernel, Marek Vasut, Liang Yang, linux-mtd, Kevin Hilman, linux-amlogic, Brian Norris, David Woodhouse, linux-arm-kernel Hi Colin, Colin King <colin.king@canonical.com> wrote on Tue, 29 Jan 2019 10:57:57 +0000: > From: Colin Ian King <colin.king@canonical.com> > > The call to meson_chip_buffer_init is not assigning ret, however, ret > is being checked for failure. Fix this by adding in the missing assignment. > > Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash controller") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/mtd/nand/raw/meson_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Merged in nand/next with the original commit. Thanks, Miquèl _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-02-05 19:06 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-01-29 10:57 [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init Colin King 2019-01-30 5:20 ` Liang Yang 2019-01-30 9:26 ` Liang Yang 2019-01-30 9:32 ` Miquel Raynal 2019-01-30 9:34 ` Colin Ian King 2019-01-30 9:43 ` Liang Yang 2019-02-05 19:05 ` Miquel Raynal
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).