From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F2C4C169C4 for ; Thu, 31 Jan 2019 16:45:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E1C82087F for ; Thu, 31 Jan 2019 16:45:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GdzCfAGR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Q2Sm5zwz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E1C82087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xf+xsNnOv7qHo6YGHLiAMMXE2zfpSBx1RhteK5fjiS8=; b=GdzCfAGRi2Z+Qs 3KwrSzHkDS5Xi0LmM37fwEUQvVMj3gW452WZrDWrCrl3Q8zNXjM8hkchmeuQI2PtRCyb4lwy5rvLz 77vZp6hRNnWsrudBoxfQVahUSayvChVniz1PXgylgjbGa2GywBxpKbfiyKb0F+8mswrvSNW7dKqHf 52t+jn+oCJU68xoOKY0EvcoCpY5fv1Ys4/WAGVFM1Gza1YZbfg8qyer7aYEjKMByNXKBtqGi+bQ0e nY9t43UHXr/z+87Z/wm4RCgcedIu47dDFUskvYyv/YLUCeX2bRtRsUWxWokLjF753hnxKKMRa5p1F WhLU9PdORDtvbslh/q8g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpFTM-0005Yr-Ga; Thu, 31 Jan 2019 16:45:52 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gpFTJ-0005X8-Ho for linux-amlogic@lists.infradead.org; Thu, 31 Jan 2019 16:45:51 +0000 Received: from pendragon.ideasonboard.com (85-76-34-136-nat.elisa-mobile.fi [85.76.34.136]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id ED13A41; Thu, 31 Jan 2019 17:45:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1548953139; bh=NrVecNyXK51VGu7P/mbRdvOqLoQktnXAnKwQ0R2KQmY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q2Sm5zwzUL5QyrHV+RAj+SOnqnXHvhLeq6tWHjzvFVRFcnEpcEC+Bdv6wWHnuxYA4 x/+rDGLRwo8Nf1tpAdxAW25o5as9aKUlDiue8UEPVdml1lyN5g0r0OL2BrSHP2+Wna doRPNoI9hIeYa093bYIY4p3HsmNWoBBjNw2C0gA4= Date: Thu, 31 Jan 2019 18:45:36 +0200 From: Laurent Pinchart To: Neil Armstrong Subject: Re: [PATCH 0/8] drm/meson: Add support for HDMI2.0 4k60 Message-ID: <20190131164536.GA4674@pendragon.ideasonboard.com> References: <20190115123315.11069-1-narmstrong@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190131_084549_911716_B6B1D487 X-CRM114-Status: GOOD ( 27.93 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko =?utf-8?Q?St=C3=BCbner?= , maxime.ripard@bootlin.com, Sandy Huang , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, a.hajda@samsung.com, Philipp Zabel , linux-amlogic@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Neil, On Thu, Jan 31, 2019 at 02:25:30PM +0100, Neil Armstrong wrote: > On 15/01/2019 13:33, Neil Armstrong wrote: > > This patchset aims to add support for the following HDMI2.0 4k60 modes: > > - 594Mhz TMDS frequency needing TMDS Scramling and 1/40 rate for RGB/YUV4:4:4 > > - 297MHz TMDS frequency with YUV4:2:0 encoding > > > > The first mode uses the SCDC helpers introduced by intel to : > > - discover where the monitor support SCDC > > - setup the SCDC parameters > > This is implemented in the dw-hdmi bridge driver by handling scrambling > > support during the bridge setup and by exporting an helper for the PHY > > setup to setup the SCDC configuration for the 1/40 TMDS rate. > > This code will only be active if the encoder support a TMDS rate > 340MHz. > > > > This patch could eventually break support on different SoC when connected > > on a 4k60 monitor with SCDC : > > - i.MX correctly discards pixel clocks > 216MHz > > - R-CAR discards discards pixel clocks > 297MHz since [1] > > - Rockchip discards invalid pixel clocks not in the rockchip_mpll_cfg table > > - sun8i correctly discards pixel clocks > 297MHz on a83t > > - sun8i discards discards pixel clocks > 594Mhz on h6, which is already broken > > > > First patch should fix support for Allwinner H6. > > > > The second mode is implemented by added the missing 4:2:0 bypass handling > > in the dw-hdmi bridge driver and adding a "mtmdsclock" separating the > > pixel clock from the tmds clock in the mode setup phase. > > We also enable support for these modes in the connector only if the platform > > glue code explicits the support. > > Do you think patches 1-4 could be applied ? I would have liked it if there could be a way to avoid exporting dw_hdmi_set_high_tmds_clock_ratio() in patch 1/8, but if that's not possible, so be it (I haven't researched that myself). No issue with patches 2/8 to 4/8. > Then we could focus on how we manage the bus format between the encoder > and the bridge ? > > Especially patch 5 linked to patch 7. > > Will one of you be at FOSDEM 2019 ? we could chat about this. I will be there on Sunday, likely from around 11:00. > Following subjects on the table will be : > - HDR metadata transmission aligned with the last patchset sent by intel-gfx > - Colorspace connector property aligned with the last patchset sent by intel-gfx > - HDCP 1.4 and 2.2 handling > > > Only the meson DRM dw_hdmi glue allows ycbcr420 modes, so no breakage > > is expected here. > > > > The remaining patches adds support for : > > - 1/40 TMDS rate aka DIV40 in the dw-hdmi meson PHY setup > > - 4:2:0 output and clock setup > > > > The dw-hdmi support re-uses the support done by Rockchip engineers on the > > Linux 4.4 BSP kernel. > > > > These modes has been validated using a MuxLab HDMI Signal Analyser in > > addition to different UHD TVs supporting full 4k60 or the 4:2:0 variant. > > > > Changes since RFC v2 at [3]: > > - Collected tested-by and reviewed-by tags > > - Changed if condition in "add HDMI div40 TMDS mode" > > - Updated "Add YUV420 output support" with the same if condition > > > > Changes since RFC v1 at [2]: > > - Fix all comments from Laurent : > > - Add define for HDMI 1.4 max tmds clock and SCDC supported version > > - Call dw_hdmi_set_high_tmds_clock_ratio() in dw_hdmi_phy_enable_powerdown() > > to unbreak Allwinner H6 > > - Pass in_t(u8, bytes, SCDC_MIN_SOURCE_VERSION) as SCDC version > > - Finally add comments for SCDC and Scrambling process > > > > [1] https://patchwork.freedesktop.org/patch/263616/ > > [2] https://patchwork.freedesktop.org/series/52950/#rev1 > > [3] https://patchwork.freedesktop.org/series/52950/#rev2 > > > > Neil Armstrong (7): > > drm/bridge: dw-hdmi: Add SCDC and TMDS Scrambling support > > drm/meson: add HDMI div40 TMDS mode > > drm/meson: add support for HDMI2.0 2160p modes > > drm/bridge: dw-hdmi: add support for YUV420 output > > drm/bridge: dw-hdmi: allow ycbcr420 modes for >= 0x200a > > drm/meson: Add YUV420 output support > > drm/meson: Output in YUV444 if sink supports it > > > > Zheng Yang (1): > > drm/bridge: dw-hdmi: support dynamically get input/out color info > > > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 182 +++++++++++++++++++--- > > drivers/gpu/drm/bridge/synopsys/dw-hdmi.h | 1 + > > drivers/gpu/drm/meson/meson_dw_hdmi.c | 128 ++++++++++++--- > > drivers/gpu/drm/meson/meson_vclk.c | 93 ++++++++--- > > drivers/gpu/drm/meson/meson_vclk.h | 7 +- > > drivers/gpu/drm/meson/meson_venc.c | 8 +- > > drivers/gpu/drm/meson/meson_venc.h | 11 ++ > > drivers/gpu/drm/meson/meson_venc_cvbs.c | 3 +- > > include/drm/bridge/dw_hdmi.h | 7 + > > 9 files changed, 374 insertions(+), 66 deletions(-) -- Regards, Laurent Pinchart _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic