From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it,
ccaione@baylibre.com, linux-kernel@vger.kernel.org,
ben.dooks@codethink.co.uk, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 2/2] rtc: support for the Amlogic Meson RTC
Date: Wed, 6 Feb 2019 23:38:55 +0100 [thread overview]
Message-ID: <20190206223855.GC4719@piout.net> (raw)
In-Reply-To: <20190119144332.11984-3-martin.blumenstingl@googlemail.com>
Hi,
On 19/01/2019 15:43:32+0100, Martin Blumenstingl wrote:
> +static int meson_rtc_probe(struct platform_device *pdev)
> +{
> + struct nvmem_config meson_rtc_nvmem_config = {
> + .name = "meson-rtc-regmem",
> + .word_size = 4,
> + .stride = 4,
> + .size = 4 * 4,
> + .reg_read = meson_rtc_regmem_read,
> + .reg_write = meson_rtc_regmem_write,
Not much to add but if those registers are battery backed, you could add
.type = NVMEM_TYPE_BATTERY_BACKED,
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2019-02-06 22:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 14:43 [PATCH v6 0/2] Amlogic Meson6/8/8b/8m2 SoC RTC driver Martin Blumenstingl
2019-01-19 14:43 ` [PATCH v6 1/2] dt-bindings: rtc: add device-tree bindings for the Amlogic Meson RTC Martin Blumenstingl
2019-02-06 22:30 ` Alexandre Belloni
2019-02-09 0:10 ` Martin Blumenstingl
2019-01-19 14:43 ` [PATCH v6 2/2] rtc: support " Martin Blumenstingl
2019-02-06 22:38 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206223855.GC4719@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=ben.dooks@codethink.co.uk \
--cc=ccaione@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).