Linux-Amlogic Archive on lore.kernel.org
 help / Atom feed
* [PATCH] mmc: meson-gx: fix interrupt name
@ 2019-02-09  0:58 Martin Blumenstingl
  2019-02-13  8:34 ` Ulf Hansson
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Blumenstingl @ 2019-02-09  0:58 UTC (permalink / raw)
  To: ulf.hansson, linux-mmc, linux-amlogic
  Cc: xademax, Martin Blumenstingl, repk, linux-arm-kernel, jbrunet

Commit bb364890323cca ("mmc: meson-gx: Free irq in release() callback")
changed the _probe code to use request_threaded_irq() instead of
devm_request_threaded_irq().
Unfortunately this removes a fallback for the interrupt name:
devm_request_threaded_irq() uses the device name as fallback if the
given IRQ name is NULL. request_threaded_irq() has no such fallback,
thus /proc/interrupts shows "(null)" instead.

Explicitly pass the dev_name() so we get the IRQ name shown in
/proc/interrupts again.
While here, also fix the indentation of the request_threaded_irq()
parameter list.

Fixes: bb364890323cca ("mmc: meson-gx: Free irq in release() callback")
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 drivers/mmc/host/meson-gx-mmc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index f19ec60bcbdc..2eba507790e4 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -1338,7 +1338,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
 	       host->regs + SD_EMMC_IRQ_EN);
 
 	ret = request_threaded_irq(host->irq, meson_mmc_irq,
-			meson_mmc_irq_thread, IRQF_SHARED, NULL, host);
+				   meson_mmc_irq_thread, IRQF_SHARED,
+				   dev_name(&pdev->dev), host);
 	if (ret)
 		goto err_init_clk;
 
-- 
2.20.1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mmc: meson-gx: fix interrupt name
  2019-02-09  0:58 [PATCH] mmc: meson-gx: fix interrupt name Martin Blumenstingl
@ 2019-02-13  8:34 ` Ulf Hansson
  0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2019-02-13  8:34 UTC (permalink / raw)
  To: Martin Blumenstingl
  Cc: Elie Roudninski, linux-mmc, Remi Pommarel,
	open list:ARM/Amlogic Meson...,
	Linux ARM, Jerome Brunet

On Sat, 9 Feb 2019 at 01:59, Martin Blumenstingl
<martin.blumenstingl@googlemail.com> wrote:
>
> Commit bb364890323cca ("mmc: meson-gx: Free irq in release() callback")
> changed the _probe code to use request_threaded_irq() instead of
> devm_request_threaded_irq().
> Unfortunately this removes a fallback for the interrupt name:
> devm_request_threaded_irq() uses the device name as fallback if the
> given IRQ name is NULL. request_threaded_irq() has no such fallback,
> thus /proc/interrupts shows "(null)" instead.
>
> Explicitly pass the dev_name() so we get the IRQ name shown in
> /proc/interrupts again.
> While here, also fix the indentation of the request_threaded_irq()
> parameter list.
>
> Fixes: bb364890323cca ("mmc: meson-gx: Free irq in release() callback")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Applied for fixes, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/meson-gx-mmc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index f19ec60bcbdc..2eba507790e4 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -1338,7 +1338,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
>                host->regs + SD_EMMC_IRQ_EN);
>
>         ret = request_threaded_irq(host->irq, meson_mmc_irq,
> -                       meson_mmc_irq_thread, IRQF_SHARED, NULL, host);
> +                                  meson_mmc_irq_thread, IRQF_SHARED,
> +                                  dev_name(&pdev->dev), host);
>         if (ret)
>                 goto err_init_clk;
>
> --
> 2.20.1
>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-09  0:58 [PATCH] mmc: meson-gx: fix interrupt name Martin Blumenstingl
2019-02-13  8:34 ` Ulf Hansson

Linux-Amlogic Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-amlogic/0 linux-amlogic/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-amlogic linux-amlogic/ https://lore.kernel.org/linux-amlogic \
		linux-amlogic@lists.infradead.org linux-amlogic@archiver.kernel.org
	public-inbox-index linux-amlogic


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-amlogic


AGPL code for this site: git clone https://public-inbox.org/ public-inbox