From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38BF5C169C4 for ; Mon, 11 Feb 2019 09:24:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F17B520869 for ; Mon, 11 Feb 2019 09:24:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YSUI3kQy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F17B520869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BWHMj5a5VFIECwBbvdIcMZLT55aZKgzs75nR80/x4wY=; b=YSUI3kQyonwbRw Ywo5P8fHPqkMXMEg+h0ODOySorueZhrYAm/SrWVgkPtXbMApWoPoKOE9pQG5tH6tZwJH5OBaYu3wO G61o69mmcw1Ya9PIJKkVYE5U8mLHub5GIbdSVZGjxiAFGtbE6lEHAgpCvfnrIpTXDh+y9i6cIazj9 sMBWxsTwmRpyScLKmQptAvVeJRL1QVyRkGvQdwZ3kYqr72w8o6CQawr5m45T3WXYUG96RDtNE/0e/ ylCMIVOee7Nb1t+VFWYscY2y2xMtAzfxrjvCjnTLaV4NNTK2n4iZ/5y2G+M2Shjh7Y/U/44q3ZQHQ B/ZlVj7n87M4lkk0/udQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gt7pP-0001Og-8w; Mon, 11 Feb 2019 09:24:39 +0000 Received: from mail-lj1-f195.google.com ([209.85.208.195]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gt7no-00007g-Pn; Mon, 11 Feb 2019 09:23:08 +0000 Received: by mail-lj1-f195.google.com with SMTP id a16so4001844ljb.11; Mon, 11 Feb 2019 01:23:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=57cf3Lc6S+hV34hW4qWkEqcWBtCzdKYSCNE88tgbwFY=; b=r1qU9DBjxeXAa1TV6CTXu9bVhb//BYHTT9RsnlauYk88B93i0uJnxxfru7DzFBU7K+ rHnZkSUY1qCoJ/x4tdTtX5ug45YxuXW6aef890Rm7iv+pmq+CRj4O8AM8G5d3YoMqbCS pvT4WCXWlAdgB1sfaDAs7HeZQbnprZ7oMX4MPoiBIChWc0ZdJOe1aZL+vh0o1QLm6Feq 5rovvdmnxSD3HWed1vAMLMvezWBIZ7U/7mrGYA6ZK+bjAXh5LwHu83xXTjrJsmC9EcPc s+F0ZU30wX9bEutDTP4A+X8EgACALztGiZVwIoqg3rAv35FxxgyxP+wFsHL69bibjFFo PFQg== X-Gm-Message-State: AHQUAubWMZJ4LAw634ZwGK0CnmZ89DDsv3Jsjr7mz8NVKk0T6Dc3dG7T xK/VURvHm7UDYGPvvhFAu+U= X-Google-Smtp-Source: AHgI3IZD1jEIfdMVWIhhGklrrMIe+2SC7DYFGzpUnfPu5MYxGNfkzXRHYwnnblKbLxcOwTdZ1dZ3RA== X-Received: by 2002:a05:651c:c4:: with SMTP id 4mr2988166ljr.45.1549876978579; Mon, 11 Feb 2019 01:22:58 -0800 (PST) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id a21sm1034696lfk.61.2019.02.11.01.22.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Feb 2019 01:22:57 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1gt7nf-00058B-Ak; Mon, 11 Feb 2019 10:22:51 +0100 Date: Mon, 11 Feb 2019 10:22:51 +0100 From: Johan Hovold To: Rob Herring Subject: Re: [PATCH v3 2/4] dt-bindings: gnss: add mediatek binding Message-ID: <20190211092251.GV4686@localhost> References: <1548693481-1162-1-git-send-email-lollivier@baylibre.com> <1548693481-1162-3-git-send-email-lollivier@baylibre.com> <20190130155016.GA26536@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190130155016.GA26536@bogus> User-Agent: Mutt/1.11.2 (2019-01-07) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190211_012306_764509_43150BEC X-CRM114-Status: GOOD ( 20.32 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Martin Blumenstingl , Kevin Hilman , Loys Ollivier , Johan Hovold , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed, Jan 30, 2019 at 09:50:16AM -0600, Rob Herring wrote: > On Mon, Jan 28, 2019 at 05:37:59PM +0100, Loys Ollivier wrote: > > Add binding for Mediatek-based GNSS receivers. > > > > Signed-off-by: Loys Ollivier > > --- > > > > v3: > > Removed the I2C and SPI interfaces references. > > Removed the "mediatek,mt3339" compatible line. > > Added the optional propertied (reset, fix) > > Added the pin names for the optional properties. > > > > v2: > > Renamed bindings from Globaltop/gtop to Mediatek/mtk. > > Moved current-speed as an optional propertie. > > Removed the status line in the example. > > Added "mediatek,mt3339" compatible. > > > > .../devicetree/bindings/gnss/mediatek.txt | 37 ++++++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gnss/mediatek.txt > > > > diff --git a/Documentation/devicetree/bindings/gnss/mediatek.txt b/Documentation/devicetree/bindings/gnss/mediatek.txt > > new file mode 100644 > > index 000000000000..00650d81c5c8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gnss/mediatek.txt > > @@ -0,0 +1,37 @@ > > +Mediatek-based GNSS Receiver DT binding > > + > > +Mediatek chipsets are used in GNSS-receiver modules produced by several > > +vendors and can use an UART interface. s/an/a/ > > + > > +Please see Documentation/devicetree/bindings/gnss/gnss.txt for generic > > +properties. > > + > > +Required properties: > > + > > +- compatible : Must be > > + > > + "globaltop,pa6h" > > + > > +- vcc-supply : Main voltage regulator (pin name: VCC) > > + > > +Optional properties: > > + > > +- gtop,reset-gpios : GPIO used to reset the device > > + (pin name: RESET, NRESET) > > reset-gpios is the standard name. > > > +- gtop,fix-gpios : GPIO used to determine device position fix state > > + (pin name: FIX, 3D_FIX) I'm thinking we might need a standard name for fix-gpios as well. This isn't a feature that is globaltop (or mediatek) specific, and other manufacturers provide similar functionality through pins named UI_FIX, or even LCKIND (lock indicator). The pin is typically used to drive an indicator LED AFAIU, but the characteristics of the signal varies from device to device (fw to fw), for example, pulse when no lock and low otherwise, or pulse when a 2d or 3d-fix is acquired, etc. I'm not sure how useful the pulsing would be for software, but someone might find a use for it in some form. Rob, is this something we want to keep in the binding, and if so, how about using a generic name such as "gnss-fix-gpios"? Johan _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic