From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, heiko@sntech.de,
sbranden@broadcom.com, khilman@baylibre.com,
richardcochran@gmail.com, linux-rockchip@lists.infradead.org,
netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
rjui@broadcom.com, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 net-next] net: phy: switch drivers to use dynamic feature detection
Date: Mon, 15 Apr 2019 17:20:17 -0700 (PDT) [thread overview]
Message-ID: <20190415.172017.1299396646743801898.davem@davemloft.net> (raw)
In-Reply-To: <3179601a-c58d-4df3-5d90-eb3598d2827b@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Fri, 12 Apr 2019 20:47:03 +0200
> Recently genphy_read_abilities() has been added that dynamically detects
> clause 22 PHY abilities. I *think* this detection should work with all
> supported PHY's, at least for the ones with basic features sets, i.e.
> PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these
> features explicitly and rely on phylib feature detection.
>
> I don't have access to most of these PHY's, therefore I'd appreciate
> regression testing.
>
> v2:
> - make the feature constant a comment so that readers know which
> features are supported by the respective PHY
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied, thanks Heiner.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2019-04-16 0:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 18:47 [PATCH v2 net-next] net: phy: switch drivers to use dynamic feature detection Heiner Kallweit
2019-04-12 22:47 ` Andrew Lunn
2019-04-16 0:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415.172017.1299396646743801898.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=heiko@sntech.de \
--cc=hkallweit1@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).