* [PATCH net] net: meson: fixup g12a glue ephy id
@ 2019-05-12 21:12 Jerome Brunet
2019-05-13 16:12 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jerome Brunet @ 2019-05-12 21:12 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, David S. Miller,
Kevin Hilman
Cc: netdev, linux-amlogic, linux-kernel, Qi Duan, Jerome Brunet
The phy id chosen by Amlogic is incorrectly set in the mdio mux and
does not match the phy driver.
It was not detected before because DT forces the use the correct driver
for the internal PHY.
Fixes: 7090425104db ("net: phy: add amlogic g12a mdio mux support")
Reported-by: Qi Duan <qi.duan@amlogic.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/net/phy/mdio-mux-meson-g12a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio-mux-meson-g12a.c b/drivers/net/phy/mdio-mux-meson-g12a.c
index 6fa29ea8e2a3..6644762ff2ab 100644
--- a/drivers/net/phy/mdio-mux-meson-g12a.c
+++ b/drivers/net/phy/mdio-mux-meson-g12a.c
@@ -33,7 +33,7 @@
#define ETH_PLL_CTL7 0x60
#define ETH_PHY_CNTL0 0x80
-#define EPHY_G12A_ID 0x33000180
+#define EPHY_G12A_ID 0x33010180
#define ETH_PHY_CNTL1 0x84
#define PHY_CNTL1_ST_MODE GENMASK(2, 0)
#define PHY_CNTL1_ST_PHYADD GENMASK(7, 3)
--
2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: meson: fixup g12a glue ephy id
2019-05-12 21:12 [PATCH net] net: meson: fixup g12a glue ephy id Jerome Brunet
@ 2019-05-13 16:12 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-05-13 16:12 UTC (permalink / raw)
To: jbrunet
Cc: andrew, f.fainelli, netdev, qi.duan, linux-kernel, khilman,
linux-amlogic, hkallweit1
From: Jerome Brunet <jbrunet@baylibre.com>
Date: Sun, 12 May 2019 23:12:37 +0200
> The phy id chosen by Amlogic is incorrectly set in the mdio mux and
> does not match the phy driver.
>
> It was not detected before because DT forces the use the correct driver
> for the internal PHY.
>
> Fixes: 7090425104db ("net: phy: add amlogic g12a mdio mux support")
> Reported-by: Qi Duan <qi.duan@amlogic.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Applied.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-13 16:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-12 21:12 [PATCH net] net: meson: fixup g12a glue ephy id Jerome Brunet
2019-05-13 16:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).