Linux-Amlogic Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/1] ARM: dts: meson8b: persistent MAC address for Odroid-C1
@ 2019-08-12 17:50 Martin Blumenstingl
  2019-08-12 17:50 ` [PATCH 1/1] ARM: dts: meson8b: odroidc1: use the MAC address stored in the eFuse Martin Blumenstingl
  2019-08-12 20:47 ` [PATCH 0/1] ARM: dts: meson8b: persistent MAC address for Odroid-C1 Kevin Hilman
  0 siblings, 2 replies; 3+ messages in thread
From: Martin Blumenstingl @ 2019-08-12 17:50 UTC (permalink / raw)
  To: linux-amlogic, khilman
  Cc: narmstrong, linux.amoon, ottuzzi, linux-kernel,
	Martin Blumenstingl, linux-arm-kernel

This series makes Odroid-C1 use the MAC address which is programmed into
the eFuse.

build-time dependencies:
none

runtime dependencies (without these a random MAC address is assigned,
just like before these patches), both are already part of -next:
- "nvmem: meson-mx-efuse: allow reading data smaller than word_size"
  from [1]
- "net: stmmac: manage errors returned by of_get_mac_address()" from [1]


Changes since v1 at [2]:
- only add the nvmem cell to meson8b-odroidc1.dts as suggested by Neil.
  It turns out that neither MXQ and EC-100 have the MAC address in eFuse
  (which means only 1/3 boards has it at the given eFuse offset, so it's
  not worth having it the common .dtsi)

Kevin: you already have v1 of this series in your tree. Feel free to
replace the two patches from v1 with this single one.


[0] https://patchwork.kernel.org/patch/11062659/
[1] https://patchwork.kernel.org/patch/11062657/
[2] https://patchwork.kernel.org/cover/11062663/


Martin Blumenstingl (1):
  ARM: dts: meson8b: odroidc1: use the MAC address stored in the eFuse

 arch/arm/boot/dts/meson8b-odroidc1.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

-- 
2.22.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] ARM: dts: meson8b: odroidc1: use the MAC address stored in the eFuse
  2019-08-12 17:50 [PATCH 0/1] ARM: dts: meson8b: persistent MAC address for Odroid-C1 Martin Blumenstingl
@ 2019-08-12 17:50 ` Martin Blumenstingl
  2019-08-12 20:47 ` [PATCH 0/1] ARM: dts: meson8b: persistent MAC address for Odroid-C1 Kevin Hilman
  1 sibling, 0 replies; 3+ messages in thread
From: Martin Blumenstingl @ 2019-08-12 17:50 UTC (permalink / raw)
  To: linux-amlogic, khilman
  Cc: narmstrong, linux.amoon, ottuzzi, linux-kernel,
	Martin Blumenstingl, linux-arm-kernel

Odroid-C1 uses the MAC address stored in eFuse at offset 0x1b4 (which is
defined as a "standard" offset for all Meson8 and Meson8b boards, but
testing shows that MXQ doesn't have the eFuse values programmed and
EC-100 stores it's MAC address in eMMC).

Add the nvmem cell which points to the MAC address and asssign it to the
Ethernet controller as "mac-address".
As result of this the MAC address which is stored in the eFuse is now
assigned to the Ethernet controller and consistent across reboots.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 arch/arm/boot/dts/meson8b-odroidc1.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
index 90f66dc45115..a24eccc354b9 100644
--- a/arch/arm/boot/dts/meson8b-odroidc1.dts
+++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
@@ -190,6 +190,12 @@
 	cpu-supply = <&vcck>;
 };
 
+&efuse {
+	ethernet_mac_address: mac@1b4 {
+		reg = <0x1b4 0x6>;
+	};
+};
+
 &ethmac {
 	status = "okay";
 
@@ -200,6 +206,9 @@
 	phy-handle = <&eth_phy>;
 	amlogic,tx-delay-ns = <4>;
 
+	nvmem-cells = <&ethernet_mac_address>;
+	nvmem-cell-names = "mac-address";
+
 	mdio {
 		compatible = "snps,dwmac-mdio";
 		#address-cells = <1>;
-- 
2.22.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 0/1] ARM: dts: meson8b: persistent MAC address for Odroid-C1
  2019-08-12 17:50 [PATCH 0/1] ARM: dts: meson8b: persistent MAC address for Odroid-C1 Martin Blumenstingl
  2019-08-12 17:50 ` [PATCH 1/1] ARM: dts: meson8b: odroidc1: use the MAC address stored in the eFuse Martin Blumenstingl
@ 2019-08-12 20:47 ` Kevin Hilman
  1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2019-08-12 20:47 UTC (permalink / raw)
  To: Martin Blumenstingl, linux-amlogic
  Cc: narmstrong, linux.amoon, ottuzzi, linux-kernel,
	Martin Blumenstingl, linux-arm-kernel

Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:

> This series makes Odroid-C1 use the MAC address which is programmed into
> the eFuse.
>
> build-time dependencies:
> none
>
> runtime dependencies (without these a random MAC address is assigned,
> just like before these patches), both are already part of -next:
> - "nvmem: meson-mx-efuse: allow reading data smaller than word_size"
>   from [1]
> - "net: stmmac: manage errors returned by of_get_mac_address()" from [1]
>
>
> Changes since v1 at [2]:
> - only add the nvmem cell to meson8b-odroidc1.dts as suggested by Neil.
>   It turns out that neither MXQ and EC-100 have the MAC address in eFuse
>   (which means only 1/3 boards has it at the given eFuse offset, so it's
>   not worth having it the common .dtsi)
>
> Kevin: you already have v1 of this series in your tree. Feel free to
> replace the two patches from v1 with this single one.

Replaced.  Thanks for the update.

Kevin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-12 17:50 [PATCH 0/1] ARM: dts: meson8b: persistent MAC address for Odroid-C1 Martin Blumenstingl
2019-08-12 17:50 ` [PATCH 1/1] ARM: dts: meson8b: odroidc1: use the MAC address stored in the eFuse Martin Blumenstingl
2019-08-12 20:47 ` [PATCH 0/1] ARM: dts: meson8b: persistent MAC address for Odroid-C1 Kevin Hilman

Linux-Amlogic Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-amlogic/0 linux-amlogic/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-amlogic linux-amlogic/ https://lore.kernel.org/linux-amlogic \
		linux-amlogic@lists.infradead.org linux-amlogic@archiver.kernel.org
	public-inbox-index linux-amlogic


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-amlogic


AGPL code for this site: git clone https://public-inbox.org/ public-inbox