* [PATCH] pinctrl: meson: meson: Add of_node_put() before return
@ 2019-08-15 6:07 Nishka Dasgupta
2019-08-21 14:24 ` Neil Armstrong
2019-08-23 9:48 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Nishka Dasgupta @ 2019-08-15 6:07 UTC (permalink / raw)
To: khilman, linus.walleij, linux-arm-kernel, linux-gpio, linux-amlogic
Cc: Nishka Dasgupta
Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
drivers/pinctrl/meson/pinctrl-meson.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
index 596786926209..8bba9d053d9f 100644
--- a/drivers/pinctrl/meson/pinctrl-meson.c
+++ b/drivers/pinctrl/meson/pinctrl-meson.c
@@ -651,6 +651,7 @@ static int meson_pinctrl_parse_dt(struct meson_pinctrl *pc,
continue;
if (gpio_np) {
dev_err(pc->dev, "multiple gpio nodes\n");
+ of_node_put(np);
return -EINVAL;
}
gpio_np = np;
--
2.19.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: meson: meson: Add of_node_put() before return
2019-08-15 6:07 [PATCH] pinctrl: meson: meson: Add of_node_put() before return Nishka Dasgupta
@ 2019-08-21 14:24 ` Neil Armstrong
2019-08-23 9:48 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2019-08-21 14:24 UTC (permalink / raw)
To: Nishka Dasgupta, khilman, linus.walleij, linux-arm-kernel,
linux-gpio, linux-amlogic
On 15/08/2019 08:07, Nishka Dasgupta wrote:
> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
> drivers/pinctrl/meson/pinctrl-meson.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
> index 596786926209..8bba9d053d9f 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson.c
> @@ -651,6 +651,7 @@ static int meson_pinctrl_parse_dt(struct meson_pinctrl *pc,
> continue;
> if (gpio_np) {
> dev_err(pc->dev, "multiple gpio nodes\n");
> + of_node_put(np);
> return -EINVAL;
> }
> gpio_np = np;
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: meson: meson: Add of_node_put() before return
2019-08-15 6:07 [PATCH] pinctrl: meson: meson: Add of_node_put() before return Nishka Dasgupta
2019-08-21 14:24 ` Neil Armstrong
@ 2019-08-23 9:48 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2019-08-23 9:48 UTC (permalink / raw)
To: Nishka Dasgupta
Cc: Kevin Hilman, open list:ARM/Amlogic Meson...,
Linux ARM, open list:GPIO SUBSYSTEM
On Thu, Aug 15, 2019 at 8:07 AM Nishka Dasgupta
<nishkadg.linux@gmail.com> wrote:
> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Patch applied with Neil's ACK.
Yours,
Linus Walleij
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-23 9:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-15 6:07 [PATCH] pinctrl: meson: meson: Add of_node_put() before return Nishka Dasgupta
2019-08-21 14:24 ` Neil Armstrong
2019-08-23 9:48 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).