From: Austin Kim <austindh.kim@gmail.com>
To: mchehab@kernel.org, khilman@baylibre.com
Cc: mjourdan@baylibre.com, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: [PATCH] media: meson: Add NULL check after the call to kmalloc()
Date: Wed, 4 Sep 2019 17:22:32 +0900 [thread overview]
Message-ID: <20190904082232.GA171180@LGEARND20B15> (raw)
If the kmalloc() return NULL, the NULL pointer dereference will occur.
new_ts->ts = ts;
Add exception check after the call to kmalloc() is made.
Signed-off-by: Austin Kim <austindh.kim@gmail.com>
---
drivers/staging/media/meson/vdec/vdec_helpers.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/media/meson/vdec/vdec_helpers.c b/drivers/staging/media/meson/vdec/vdec_helpers.c
index f16948b..e7e56d5 100644
--- a/drivers/staging/media/meson/vdec/vdec_helpers.c
+++ b/drivers/staging/media/meson/vdec/vdec_helpers.c
@@ -206,6 +206,10 @@ void amvdec_add_ts_reorder(struct amvdec_session *sess, u64 ts, u32 offset)
unsigned long flags;
new_ts = kmalloc(sizeof(*new_ts), GFP_KERNEL);
+ if (!new_ts) {
+ dev_err(sess->core->dev, "Failed to kmalloc()\n");
+ return;
+ }
new_ts->ts = ts;
new_ts->offset = offset;
--
2.6.2
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next reply other threads:[~2019-09-04 8:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 8:22 Austin Kim [this message]
2019-09-04 8:43 ` [PATCH] media: meson: Add NULL check after the call to kmalloc() Rasmus Villemoes
2019-09-04 22:47 ` Austin Kim
2019-09-04 8:45 ` Greg KH
2019-09-04 22:39 ` Austin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904082232.GA171180@LGEARND20B15 \
--to=austindh.kim@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mjourdan@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).