From: Rob Herring <robh@kernel.org>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: mjourdan@baylibre.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: media: amlogic,gx-vdec: add bindings for G12A family
Date: Tue, 3 Dec 2019 17:21:09 -0600 [thread overview]
Message-ID: <20191203232108.GA361@bogus> (raw)
In-Reply-To: <20191120111430.29552-3-narmstrong@baylibre.com>
On Wed, Nov 20, 2019 at 12:14:28PM +0100, Neil Armstrong wrote:
> Add bindings to support the Amlogic Video Decoder on the Amlogic G12A
> family.
>
> For the G12A family, a supplementary clock is needed to operate the
> HEVC/VP9 decoder.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> .../bindings/media/amlogic,gx-vdec.yaml | 57 +++++++++++++++----
> 1 file changed, 46 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/amlogic,gx-vdec.yaml b/Documentation/devicetree/bindings/media/amlogic,gx-vdec.yaml
> index 878944867d6e..8ea979bb97e6 100644
> --- a/Documentation/devicetree/bindings/media/amlogic,gx-vdec.yaml
> +++ b/Documentation/devicetree/bindings/media/amlogic,gx-vdec.yaml
> @@ -27,12 +27,15 @@ description: |
>
> properties:
> compatible:
> - items:
> + oneOf:
> + - items:
> + - enum:
> + - amlogic,gxbb-vdec # GXBB (S905)
> + - amlogic,gxl-vdec # GXL (S905X, S905D)
> + - amlogic,gxm-vdec # GXM (S912)
> + - const: amlogic,gx-vdec
> - enum:
> - - amlogic,gxbb-vdec # GXBB (S905)
> - - amlogic,gxl-vdec # GXL (S905X, S905D)
> - - amlogic,gxm-vdec # GXM (S912)
> - - const: amlogic,gx-vdec
> + - amlogic,g12a-vdec # G12A (S905X2, S905D2)
>
> interrupts:
> minItems: 2
> @@ -59,13 +62,9 @@ properties:
>
> clocks:
> minItems: 4
> + maxItems: 5
>
> - clock-names:
> - items:
> - - const: dos_parser
> - - const: dos
> - - const: vdec_1
> - - const: vdec_hevc
You can leave this here and add the 5th clock along with { minItems: 4,
maxItems: 5 }.
Then the 'if' schema just needs a 'maxItems: 4'.
> + clock-names: true
>
> amlogic,ao-sysctrl:
> description: should point to the AOBUS sysctrl node
> @@ -77,6 +76,42 @@ properties:
> allOf:
> - $ref: /schemas/types.yaml#/definitions/phandle
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - amlogic,gx-vdec
> +
> + then:
> + properties:
> + clock-names:
> + minItems: 4
> + items:
> + - const: dos_parser
> + - const: dos
> + - const: vdec_1
> + - const: vdec_hevc
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - amlogic,g12a-vdec
> +
> + then:
> + properties:
> + clock-names:
> + minItems: 5
> + items:
> + - const: dos_parser
> + - const: dos
> + - const: vdec_1
> + - const: vdec_hevc
> + - const: vdec_hevcf
> +
> required:
> - compatible
> - reg
> --
> 2.22.0
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-12-03 23:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 11:14 [PATCH 0/4] media: meson: vdec: add g12a platform Neil Armstrong
2019-11-20 11:14 ` [PATCH 1/4] dt-bindings: media: amlogic,vdec: convert to yaml Neil Armstrong
2019-12-03 23:21 ` Rob Herring
2019-11-20 11:14 ` [PATCH 2/4] dt-bindings: media: amlogic, gx-vdec: add bindings for G12A family Neil Armstrong
2019-12-03 23:21 ` Rob Herring [this message]
2019-11-20 11:14 ` [PATCH 3/4] media: meson: vdec: add g12a platform Neil Armstrong
2019-11-20 11:14 ` [PATCH 4/4] arm64: dts: meson-g12-common: add video decoder node Neil Armstrong
2019-12-13 16:51 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203232108.GA361@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mjourdan@baylibre.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).