From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: kstewart@linuxfoundation.org, ulf.hansson@linaro.org,
geert+renesas@glider.be, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com,
khilman@baylibre.com, jh80.chung@samsung.com, wens@csie.org,
agross@kernel.org, chaotian.jing@mediatek.com,
linux-arm-msm@vger.kernel.org, wsa+renesas@sang-engineering.com,
mripard@kernel.org, linux-mediatek@lists.infradead.org,
ben-linux@fluff.org, matthias.bgg@gmail.com,
linux-amlogic@lists.infradead.org, tglx@linutronix.de,
allison@lohutok.net, linux-arm-kernel@lists.infradead.org,
nico@fluxnic.net, gregkh@linuxfoundation.org,
yoshihiro.shimoda.uh@renesas.com, linux-mmc@vger.kernel.org,
adrian.hunter@intel.com, vireshk@kernel.org,
manuel.lauss@gmail.com
Subject: Re: [PATCH 10/13] mmc: sdhci-msm: convert to devm_platform_ioremap_resource
Date: Tue, 17 Dec 2019 22:30:28 -0800 [thread overview]
Message-ID: <20191218063028.GC3755841@builder> (raw)
In-Reply-To: <20191215175120.3290-10-tiny.windzz@gmail.com>
On Sun 15 Dec 09:51 PST 2019, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/mmc/host/sdhci-msm.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index 3d0bb5e2e09b..6daacef4ceec 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -1746,7 +1746,6 @@ static int sdhci_msm_probe(struct platform_device *pdev)
> struct sdhci_host *host;
> struct sdhci_pltfm_host *pltfm_host;
> struct sdhci_msm_host *msm_host;
> - struct resource *core_memres;
> struct clk *clk;
> int ret;
> u16 host_version, core_minor;
> @@ -1847,9 +1846,7 @@ static int sdhci_msm_probe(struct platform_device *pdev)
> }
>
> if (!msm_host->mci_removed) {
> - core_memres = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> - msm_host->core_mem = devm_ioremap_resource(&pdev->dev,
> - core_memres);
> + msm_host->core_mem = devm_platform_ioremap_resource(pdev, 1);
>
This would now look better without this empty line.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> if (IS_ERR(msm_host->core_mem)) {
> ret = PTR_ERR(msm_host->core_mem);
> --
> 2.17.1
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-12-18 6:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 17:51 [PATCH 01/13] mmc: sunxi-mmc: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-15 17:51 ` [PATCH 02/13] mmc: tmio: " Yangtao Li
2019-12-18 9:47 ` Wolfram Sang
2019-12-15 17:51 ` [PATCH 03/13] mmc: meson-mx-sdio: " Yangtao Li
2019-12-15 17:51 ` [PATCH 04/13] mmc: sdhci-s3c: " Yangtao Li
2019-12-15 17:51 ` [PATCH 05/13] mmc: sdhci-spear: " Yangtao Li
2019-12-15 17:51 ` [PATCH 06/13] mmc: sh_mmcif: " Yangtao Li
2019-12-18 9:49 ` Wolfram Sang
2019-12-15 17:51 ` [PATCH 07/13] mmc: sdhci_f_sdh30: " Yangtao Li
2019-12-15 17:51 ` [PATCH 08/13] mmc: sdhci_am654: " Yangtao Li
2019-12-15 17:51 ` [PATCH 09/13] mmc: sdhci-milbeaut: " Yangtao Li
2019-12-15 17:51 ` [PATCH 10/13] mmc: sdhci-msm: " Yangtao Li
2019-12-18 6:30 ` Bjorn Andersson [this message]
2019-12-15 17:51 ` [PATCH 11/13] mmc: mvsdio: " Yangtao Li
2019-12-15 17:51 ` [PATCH 12/13] mmc: mtk-sd: " Yangtao Li
2019-12-15 17:51 ` [PATCH 13/13] mmc: au1xmmc: switch to platform_get_irq Yangtao Li
2019-12-18 2:27 ` [PATCH 01/13] mmc: sunxi-mmc: convert to devm_platform_ioremap_resource Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218063028.GC3755841@builder \
--to=bjorn.andersson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=allison@lohutok.net \
--cc=ben-linux@fluff.org \
--cc=chaotian.jing@mediatek.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jh80.chung@samsung.com \
--cc=khilman@baylibre.com \
--cc=kstewart@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=manuel.lauss@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=nico@fluxnic.net \
--cc=tglx@linutronix.de \
--cc=tiny.windzz@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=vireshk@kernel.org \
--cc=wens@csie.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yamada.masahiro@socionext.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).