From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91510C2D0C8 for ; Wed, 25 Dec 2019 18:55:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66E072073B for ; Wed, 25 Dec 2019 18:55:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AuVJCCva"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="kHniXevL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66E072073B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=triplefau.lt Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=paQ7iq114SW47qy2o/CM6a//5pinHghWchDMG/2apgw=; b=AuVJCCva9zPdik FMRQMcFj8nu1nDIaRHqHubmcuDzpgZmN1XhYeWjv1L5XXhfztiG86C1oK1nP2lKHEONNttmdXfw6s KNtNyNHjNx2DrRjh5Xk3eg8Y1aDrIYhfLxwtepwZMZiq+wkXaIwnr1JpItXvbMONhgYO/UhkcDZSg NRA+inJeZEp+o4gi/yJH+uFGF8GQD7hOXOdVRIj97cQxxw476fAvxg9jn/b0SxBmNbQ/qKCJV60gy 1wfCvRzzTomRQCkos6x+HMtrXEexJBeQDjQ62X5c9SXksLNHhqGkPomXyprf+Q1qi1lz/xixj30YX 4ScR7Ay7sxZqThOklAHg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ikBoO-0001Pu-41; Wed, 25 Dec 2019 18:55:12 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ikBoM-0001Od-PY for linux-amlogic@bombadil.infradead.org; Wed, 25 Dec 2019 18:55:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=V5zqjNU8lWxhx4T8vgAchYsOb6MwZXLIgZ6zmI6PMTY=; b=kHniXevLPZPcl6Ui2/g6/I9OH iNTiiFJJERojciV+Nwqx+p02SQPCLKmA1ozn6IBxPeDZ4taPTklkICiY57V69Vo8jn+Zv71p7ezRy Tx4Err03gmHl3QVGK/9RZVcao+93lgsuQFAU1tChnjqqZx59eLbfJXUdD3jKcpBI7bdci4K8kf0o7 Twqp7U6b9fY8HpHahVmSo5xEANlJ9O7k2glDq/bUL/7x9YQXVoHrh0gjUSNQ7e31gJa5VoNTRZ81b 1Op4PE6TrcAHTBByzSoULLdIN8v8kZfYdtBO+wbn8/81VZI3lb0xEPn6BPP1uxFfcvrx9VkSy4QkL KE8fKCZGg==; Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ikBoI-0000QH-Iz for linux-amlogic@lists.infradead.org; Wed, 25 Dec 2019 18:55:08 +0000 X-Originating-IP: 88.190.179.123 Received: from localhost (unknown [88.190.179.123]) (Authenticated sender: repk@triplefau.lt) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id CF474240003; Wed, 25 Dec 2019 18:54:17 +0000 (UTC) Date: Wed, 25 Dec 2019 20:02:20 +0100 From: Remi Pommarel To: Kishon Vijay Abraham I , Yue Wang , Lorenzo Pieralisi , Andrew Murray , Neil Armstrong , Kevin Hilman , Martin Blumenstingl Subject: Re: [PATCH v3 5/5] dt-bindings: Add AXG PCIE PHY bindings Message-ID: <20191225190220.GF7304@voidbox> References: <20191224173942.18160-1-repk@triplefau.lt> <20191224173942.18160-6-repk@triplefau.lt> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191224173942.18160-6-repk@triplefau.lt> User-Agent: Mutt/1.12.2 (2019-09-21) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue, Dec 24, 2019 at 06:39:42PM +0100, Remi Pommarel wrote: > Add documentation for PCIE PHYs found in AXG SoCs. > > Signed-off-by: Remi Pommarel > --- > .../bindings/phy/amlogic,meson-axg-pcie.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml > new file mode 100644 > index 000000000000..c622a1b38ffc > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2019 BayLibre, SAS > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/amlogic,meson-axg-pcie.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic AXG PCIE PHY > + > +maintainers: > + - Remi Pommarel > + > +properties: > + compatible: > + enum: > + - amlogic,axg-pcie-phy > + > + reg: > + maxItems: 1 > + > + aml,hhi-gpr: > + maxItems: 1 My bad, I didn't know about devicetree schemas and their verification, I will fix the missing $ref: '/schemas/types.yaml#/definitions/phandle' here, add a description and add the missing include for reset in the example below in v4 along with upcoming comments on the other patches. Sorry about that. > + > + resets: > + maxItems: 1 > + > + reset-names: > + items: > + - const: phy > + > + "#phy-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - aml,hhi-gpr > + - resets > + - reset-names > + - "#phy-cells" > + > +examples: > + - | > + pcie_phy: pcie-phy@ff644000 { > + compatible = "amlogic,axg-pcie-phy"; > + reg = <0x0 0xff644000 0x0 0x2000>; > + aml,hhi-gpr = <&sysctrl>; > + resets = <&reset RESET_PCIE_PHY>; > + reset-names = "phy"; > + #phy-cells = <0>; > + }; > -- > 2.24.0 > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic