From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-pwm@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Thierry Reding <thierry.reding@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-riscv@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] pwm: Enable compile testing for some of drivers
Date: Tue, 7 Jan 2020 08:26:45 +0100 [thread overview]
Message-ID: <20200107072645.ko247bwhh3ibdu73@pengutronix.de> (raw)
In-Reply-To: <20191230172113.17222-2-krzk@kernel.org>
Hello Krzysztof,
On Mon, Dec 30, 2019 at 06:21:13PM +0100, Krzysztof Kozlowski wrote:
> Some of the PWM drivers can be compile tested to increase build
> coverage.
>
> The Meson PWM driver requires COMMON_CLK dependency.
I'm surprised that there are not more that need this. Is HAVE_CLK not
enough?
Also HAS_IOMEM is a typical requirement, but I tested with an ARCH=um
config (which does't have HAS_IOMEM) and they all compile fine.
> @@ -318,7 +319,7 @@ config PWM_MEDIATEK
>
> config PWM_MXS
> tristate "Freescale MXS PWM support"
> - depends on ARCH_MXS && OF
> + depends on (ARCH_MXS && OF) || COMPILE_TEST
> select STMP_DEVICE
> help
> Generic PWM framework driver for Freescale MXS.
> @@ -328,7 +329,8 @@ config PWM_MXS
>
> config PWM_OMAP_DMTIMER
> tristate "OMAP Dual-Mode Timer PWM support"
> - depends on OF && ARCH_OMAP && OMAP_DM_TIMER
> + depends on (ARCH_OMAP && OMAP_DM_TIMER) || COMPILE_TEST
> + depends on OF
I'm surprised that OF isn't required for PWM_MXS but is is for
PWM_OMAP_DMTIMER. pwm-mxs compiles without CONFIG_OF, didn't test
pwm-omap-dmtimer.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König | | https://www.pengutronix.de/ |
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-01-07 7:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 17:21 [PATCH 1/2] pwm: Fix minor Kconfig whitespace issues Krzysztof Kozlowski
2019-12-30 17:21 ` [PATCH 2/2] pwm: Enable compile testing for some of drivers Krzysztof Kozlowski
2019-12-30 19:30 ` Florian Fainelli
2019-12-31 14:52 ` Martin Blumenstingl
2020-01-06 9:53 ` Claudiu.Beznea
2020-01-07 7:26 ` Uwe Kleine-König [this message]
2020-01-07 8:25 ` Krzysztof Kozlowski
2020-01-07 10:42 ` Uwe Kleine-König
2020-01-07 11:03 ` Krzysztof Kozlowski
2020-01-07 11:33 ` Uwe Kleine-König
2020-01-07 11:54 ` Krzysztof Kozlowski
2020-01-07 12:09 ` Uwe Kleine-König
2020-01-07 12:15 ` Krzysztof Kozlowski
2020-01-08 13:00 ` [PATCH 1/2] pwm: Fix minor Kconfig whitespace issues Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107072645.ko247bwhh3ibdu73@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=krzk@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).