From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: dri-devel@lists.freedesktop.org, alyssa@rosenzweig.io,
steven.price@arm.com, tomeu.vizoso@collabora.com,
robh@kernel.org
Cc: airlied@linux.ie, linux-kernel@vger.kernel.org,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-rockchip@lists.infradead.org, daniel@ffwll.ch,
sudeep.holla@arm.com, linux-amlogic@lists.infradead.org,
robin.murphy@arm.com
Subject: [PATCH RFT v2 0/3] devfreq fixes for panfrost
Date: Sun, 12 Jan 2020 01:16:20 +0100 [thread overview]
Message-ID: <20200112001623.2121227-1-martin.blumenstingl@googlemail.com> (raw)
These are a bunch of devfreq fixes for panfrost that came up in a
discussion with Robin Murphy during the code-review of the lima
devfreq patches: [0]
I am only able to test patch #1 properly because the only boards with
panfrost GPU that I have are using an Amlogic SoC. We don't have
support for the OPP tables or dynamic clock changes there yet.
So patches #2 and #3 are compile-tested only.
Changes since v1 at [1]
- added Steven's Reviewed-by to patch #2 (thank you!)
- only use dev_pm_opp_put_regulators() to clean up in
panfrost_devfreq_init() if regulators_opp_table is not NULL to fix
a potential crash inside dev_pm_opp_put_regulators() as spotted by
Steven Price (thank you!). While here, I also switched to "goto err"
pattern to avoid lines with more than 80 characters.
Known discussion topics (I have no way to test either of these, so I am
looking for help here):
- Steven Price reported the following message on his firefly (RK3288)
board:
"debugfs: Directory 'ffa30000.gpu-mali' with parent 'vdd_gpu' already
present!"
- Robin Murphy suggested that patch #1 may not work once the OPP table
for the GPU comes from SCMI
[0] https://patchwork.freedesktop.org/patch/346898/
[1] https://patchwork.freedesktop.org/series/71744/
Martin Blumenstingl (3):
drm/panfrost: enable devfreq based the "operating-points-v2" property
drm/panfrost: call dev_pm_opp_of_remove_table() in all error-paths
drm/panfrost: Use the mali-supply regulator for control again
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 44 +++++++++++++++++----
drivers/gpu/drm/panfrost/panfrost_device.h | 1 +
2 files changed, 37 insertions(+), 8 deletions(-)
--
2.24.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next reply other threads:[~2020-01-12 0:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-12 0:16 Martin Blumenstingl [this message]
2020-01-12 0:16 ` [PATCH RFT v2 1/3] drm/panfrost: enable devfreq based the "operating-points-v2" property Martin Blumenstingl
2020-01-12 0:16 ` [PATCH RFT v2 2/3] drm/panfrost: call dev_pm_opp_of_remove_table() in all error-paths Martin Blumenstingl
2020-01-12 0:16 ` [PATCH RFT v2 3/3] drm/panfrost: Use the mali-supply regulator for control again Martin Blumenstingl
2020-02-22 19:42 ` [PATCH RFT v2 0/3] devfreq fixes for panfrost Martin Blumenstingl
2020-03-02 14:58 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200112001623.2121227-1-martin.blumenstingl@googlemail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=airlied@linux.ie \
--cc=alyssa@rosenzweig.io \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=steven.price@arm.com \
--cc=sudeep.holla@arm.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).