From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6200C11D2F for ; Mon, 24 Feb 2020 14:16:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 817D72072D for ; Mon, 24 Feb 2020 14:16:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Su52LNai" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 817D72072D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Tz08dscVIPKlgRkfTsiQTU2Bbv3FM0Oh830BYGM2h7I=; b=Su52LNairBZqIK CcESMPYE1x1O3h5d1bbmsTn3OQFyrEOo+ZBSJd6iZLHcz/9M7PwqhZBlzCRUSCpgTelRV3ZjEjMB6 kwGzjSmzb4XOTJNTPzsVP8TJ2Dj0kW0CcgrJAysArgmoyoGJHmn+E4PjEoknNxEDtqPOO6RQhyJtR fP+L+mozADKUh0z/f3UxWXDxwGea7Rq6FuhYodSkgquiDDGOmvJVLXNlmF/SXytGk+BXGXNIUXHoZ /AZXXs1BGnRnHbndw3tqfZi+kICDg/FRThI/FE7tKzFoYnc91zkoBQtfPyPMsiBEZzIzZo9iqrnrf +Tvoy5CEBcs9xJ5ZqI6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6EWf-0002Xy-Mn; Mon, 24 Feb 2020 14:16:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6EWZ-0002Bz-T4 for linux-amlogic@lists.infradead.org; Mon, 24 Feb 2020 14:16:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AC83730E; Mon, 24 Feb 2020 06:15:53 -0800 (PST) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0D6CA3F534; Mon, 24 Feb 2020 06:15:51 -0800 (PST) Date: Mon, 24 Feb 2020 14:15:49 +0000 From: Lorenzo Pieralisi To: Remi Pommarel Subject: Re: [PATCH v6 0/7] PCI: amlogic: Make PCIe working reliably on AXG platforms Message-ID: <20200224141549.GB15614@e121166-lin.cambridge.arm.com> References: <20200123232943.10229-1-repk@triplefau.lt> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200123232943.10229-1-repk@triplefau.lt> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200224_061556_031946_39F93FCE X-CRM114-Status: GOOD ( 16.53 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Neil Armstrong , Martin Blumenstingl , Kevin Hilman , linux-kernel@vger.kernel.org, Yue Wang , Rob Herring , linux-pci@vger.kernel.org, Bjorn Helgaas , linux-amlogic@lists.infradead.org, Kishon Vijay Abraham I , Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Fri, Jan 24, 2020 at 12:29:36AM +0100, Remi Pommarel wrote: > PCIe device probing failures have been seen on AXG platforms and were > due to unreliable clock signal output. Setting HHI_MIPI_CNTL0[26] bit > in MIPI's PHY registers solved the problem. This bit controls band gap > reference. > > As discussed here [1] one of these shared MIPI/PCIE analog PHY register > bits was implemented in the clock driver as CLKID_MIPI_ENABLE. This adds > a PHY driver to control this bit instead, as well as setting the band > gap one in order to get reliable PCIE communication. > > While at it add another PHY driver to control PCIE only PHY registers, > making AXG code more similar to G12A platform thus allowing to remove > some specific platform handling in pci-meson driver. > > Please note that CLKID_MIPI_ENABLE removable will be done in a different > serie. > > Changes since v5: > - Add additionalProperties in device tree binding documentation > - Make analog PHY required > > Changes since v4: > - Rename the shared MIPI/PCIe PHY to analog > - Chain the MIPI/PCIe PHY to the PCIe one > > Changes since v3: > - Go back to the shared MIPI/PCIe phy driver solution from v2 > - Remove syscon usage > - Add all dt-bindings documentation > > Changes since v2: > - Remove shared MIPI/PCIE device driver and use syscon to access register > in PCIE only driver instead > - Include devicetree documentation > > Changes sinve v1: > - Move HHI_MIPI_CNTL0 bit control in its own PHY driver > - Add a PHY driver for PCIE_PHY registers > - Modify pci-meson.c to make use of both PHYs and remove specific > handling for AXG and G12A > > [1] https://lkml.org/lkml/2019/12/16/119 > > Remi Pommarel (7): > dt-bindings: Add AXG PCIE PHY bindings > dt-bindings: Add AXG shared MIPI/PCIE analog PHY bindings > dt-bindings: PCI: meson: Update PCIE bindings documentation > arm64: dts: meson-axg: Add PCIE PHY nodes > phy: amlogic: Add Amlogic AXG MIPI/PCIE analog PHY Driver > phy: amlogic: Add Amlogic AXG PCIE PHY Driver > PCI: amlogic: Use AXG PCIE > > .../bindings/pci/amlogic,meson-pcie.txt | 22 +- > .../amlogic,meson-axg-mipi-pcie-analog.yaml | 35 ++++ > .../bindings/phy/amlogic,meson-axg-pcie.yaml | 52 +++++ > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 16 ++ > drivers/pci/controller/dwc/pci-meson.c | 116 ++--------- > drivers/phy/amlogic/Kconfig | 22 ++ > drivers/phy/amlogic/Makefile | 12 +- > .../amlogic/phy-meson-axg-mipi-pcie-analog.c | 188 +++++++++++++++++ > drivers/phy/amlogic/phy-meson-axg-pcie.c | 192 ++++++++++++++++++ > 9 files changed, 543 insertions(+), 112 deletions(-) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-axg-mipi-pcie-analog.yaml > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml > create mode 100644 drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c > create mode 100644 drivers/phy/amlogic/phy-meson-axg-pcie.c Hi Remi, I am ready to pull this series in, do you want me to ? Or you prefer it to go via a different tree upstream ? Thanks, Lorenzo _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic