From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63F5CC3F2CD for ; Wed, 4 Mar 2020 12:59:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 341E020870 for ; Wed, 4 Mar 2020 12:59:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lEzWNvmG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 341E020870 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=triplefau.lt Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5d4Ja9nVVOnJbUKBB70VvsNsMFKhTjQnRN20ffjudh0=; b=lEzWNvmGzkSbQi NG7V36XbkLcSpPEhTkAJ1CH7RchJndLUCxQiGhHRf047u50B48wVW6ZKCInvhyvnmUfIO+dPXApHx squGqNMTB03fGmYEXkjmPGythXXnBDiaCbbTf0vxvlsUSV+NFSYX9UEW02bGpaZXwomn/djWe5Z/o wp3p0lHhUmA8NM8LdIuVaGSqJl1BTe05QDxEoUYTSO6jLbFOeBx1jwOE46ddA1+fOpGrhrBqlt/+c tl9rSDD1ghQCJU3pzJ1z643MNOUShHB+2UIm91UMJ3MqU+iK2Xza3I7tjUcBIWQsFPRWMXLsEkonD TwG0cKIrZfk0q9nyzHlg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9Tcu-0003ys-4Z; Wed, 04 Mar 2020 12:59:52 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9Tcq-0003xc-9O for linux-amlogic@lists.infradead.org; Wed, 04 Mar 2020 12:59:50 +0000 Received: from localhost (unknown [82.66.179.123]) (Authenticated sender: repk@triplefau.lt) by relay12.mail.gandi.net (Postfix) with ESMTPSA id AE2A1200007; Wed, 4 Mar 2020 12:59:22 +0000 (UTC) Date: Wed, 4 Mar 2020 14:08:11 +0100 From: Remi Pommarel To: Kishon Vijay Abraham I Subject: Re: [PATCH v6 6/7] phy: amlogic: Add Amlogic AXG PCIE PHY Driver Message-ID: <20200304130811.GP2248@voidbox> References: <20200123232943.10229-1-repk@triplefau.lt> <20200123232943.10229-7-repk@triplefau.lt> <14627e42-4894-6674-4911-3205ea8f5e55@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <14627e42-4894-6674-4911-3205ea8f5e55@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200304_045948_604529_AEA99904 X-CRM114-Status: GOOD ( 22.97 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lorenzo Pieralisi , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , linux-kernel@vger.kernel.org, Yue Wang , Rob Herring , linux-pci@vger.kernel.org, Bjorn Helgaas , linux-amlogic@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed, Mar 04, 2020 at 04:31:24PM +0530, Kishon Vijay Abraham I wrote: > > > On 24/01/20 4:59 am, Remi Pommarel wrote: > > This adds support for the PCI PHY found in the Amlogic AXG SoC Family. > > This will allow to mutualize code in pci-meson.c between AXG and G12A > > SoC. > > > > This PHY also uses and chains an analog PHY, which on AXG platform > > is needed to have reliable PCIe communication. > > Is the analog PHY an independent block and can be used with other PHYs? It is documented as a separate block yes, but I think it is unlikely that it will be used with other PHYs than the PCIe or the MIPI one of the AXG SoC. Thanks, Remi > > For the patch itself > Acked-by: Kishon Vijay Abraham I > > Thanks > Kishon > > > > Signed-off-by: Remi Pommarel > > --- > > drivers/phy/amlogic/Kconfig | 11 ++ > > drivers/phy/amlogic/Makefile | 1 + > > drivers/phy/amlogic/phy-meson-axg-pcie.c | 192 +++++++++++++++++++++++ > > 3 files changed, 204 insertions(+) > > create mode 100644 drivers/phy/amlogic/phy-meson-axg-pcie.c > > > > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig > > index 8c9cf2403591..71801e30d601 100644 > > --- a/drivers/phy/amlogic/Kconfig > > +++ b/drivers/phy/amlogic/Kconfig > > @@ -60,6 +60,17 @@ config PHY_MESON_G12A_USB3_PCIE > > in Meson G12A SoCs. > > If unsure, say N. > > > > +config PHY_MESON_AXG_PCIE > > + tristate "Meson AXG PCIE PHY driver" > > + default ARCH_MESON > > + depends on OF && (ARCH_MESON || COMPILE_TEST) > > + select GENERIC_PHY > > + select REGMAP_MMIO > > + help > > + Enable this to support the Meson MIPI + PCIE PHY found > > + in Meson AXG SoCs. > > + If unsure, say N. > > + > > config PHY_MESON_AXG_MIPI_PCIE_ANALOG > > tristate "Meson AXG MIPI + PCIE analog PHY driver" > > default ARCH_MESON > > diff --git a/drivers/phy/amlogic/Makefile b/drivers/phy/amlogic/Makefile > > index 0aecf92d796a..e2baa133f7af 100644 > > --- a/drivers/phy/amlogic/Makefile > > +++ b/drivers/phy/amlogic/Makefile > > @@ -4,4 +4,5 @@ obj-$(CONFIG_PHY_MESON_GXL_USB2) += phy-meson-gxl-usb2.o > > obj-$(CONFIG_PHY_MESON_G12A_USB2) += phy-meson-g12a-usb2.o > > obj-$(CONFIG_PHY_MESON_GXL_USB3) += phy-meson-gxl-usb3.o > > obj-$(CONFIG_PHY_MESON_G12A_USB3_PCIE) += phy-meson-g12a-usb3-pcie.o > > +obj-$(CONFIG_PHY_MESON_AXG_PCIE) += phy-meson-axg-pcie.o > > obj-$(CONFIG_PHY_MESON_AXG_MIPI_PCIE_ANALOG) += phy-meson-axg-mipi-pcie-analog.o > > diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic/phy-meson-axg-pcie.c > > new file mode 100644 > > index 000000000000..377ed0dcd0d9 > > --- /dev/null > > +++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c > > @@ -0,0 +1,192 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Amlogic AXG PCIE PHY driver > > + * > > + * Copyright (C) 2020 Remi Pommarel > > + */ > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#define MESON_PCIE_REG0 0x00 > > +#define MESON_PCIE_COMMON_CLK BIT(4) > > +#define MESON_PCIE_PORT_SEL GENMASK(3, 2) > > +#define MESON_PCIE_CLK BIT(1) > > +#define MESON_PCIE_POWERDOWN BIT(0) > > + > > +#define MESON_PCIE_TWO_X1 FIELD_PREP(MESON_PCIE_PORT_SEL, 0x3) > > +#define MESON_PCIE_COMMON_REF_CLK FIELD_PREP(MESON_PCIE_COMMON_CLK, 0x1) > > +#define MESON_PCIE_PHY_INIT (MESON_PCIE_TWO_X1 | \ > > + MESON_PCIE_COMMON_REF_CLK) > > +#define MESON_PCIE_RESET_DELAY 500 > > + > > +struct phy_axg_pcie_priv { > > + struct phy *phy; > > + struct phy *analog; > > + struct regmap *regmap; > > + struct reset_control *reset; > > +}; > > + > > +static const struct regmap_config phy_axg_pcie_regmap_conf = { > > + .reg_bits = 8, > > + .val_bits = 32, > > + .reg_stride = 4, > > + .max_register = MESON_PCIE_REG0, > > +}; > > + > > +static int phy_axg_pcie_power_on(struct phy *phy) > > +{ > > + struct phy_axg_pcie_priv *priv = phy_get_drvdata(phy); > > + int ret; > > + > > + ret = phy_power_on(priv->analog); > > + if (ret != 0) > > + return ret; > > + > > + regmap_update_bits(priv->regmap, MESON_PCIE_REG0, > > + MESON_PCIE_POWERDOWN, 0); > > + return 0; > > +} > > + > > +static int phy_axg_pcie_power_off(struct phy *phy) > > +{ > > + struct phy_axg_pcie_priv *priv = phy_get_drvdata(phy); > > + int ret; > > + > > + ret = phy_power_off(priv->analog); > > + if (ret != 0) > > + return ret; > > + > > + regmap_update_bits(priv->regmap, MESON_PCIE_REG0, > > + MESON_PCIE_POWERDOWN, 1); > > + return 0; > > +} > > + > > +static int phy_axg_pcie_init(struct phy *phy) > > +{ > > + struct phy_axg_pcie_priv *priv = phy_get_drvdata(phy); > > + int ret; > > + > > + ret = phy_init(priv->analog); > > + if (ret != 0) > > + return ret; > > + > > + regmap_write(priv->regmap, MESON_PCIE_REG0, MESON_PCIE_PHY_INIT); > > + return reset_control_reset(priv->reset); > > +} > > + > > +static int phy_axg_pcie_exit(struct phy *phy) > > +{ > > + struct phy_axg_pcie_priv *priv = phy_get_drvdata(phy); > > + int ret; > > + > > + ret = phy_exit(priv->analog); > > + if (ret != 0) > > + return ret; > > + > > + return reset_control_reset(priv->reset); > > +} > > + > > +static int phy_axg_pcie_reset(struct phy *phy) > > +{ > > + struct phy_axg_pcie_priv *priv = phy_get_drvdata(phy); > > + int ret = 0; > > + > > + ret = phy_reset(priv->analog); > > + if (ret != 0) > > + goto out; > > + > > + ret = reset_control_assert(priv->reset); > > + if (ret != 0) > > + goto out; > > + udelay(MESON_PCIE_RESET_DELAY); > > + > > + ret = reset_control_deassert(priv->reset); > > + if (ret != 0) > > + goto out; > > + udelay(MESON_PCIE_RESET_DELAY); > > + > > +out: > > + return ret; > > +} > > + > > +static const struct phy_ops phy_axg_pcie_ops = { > > + .init = phy_axg_pcie_init, > > + .exit = phy_axg_pcie_exit, > > + .power_on = phy_axg_pcie_power_on, > > + .power_off = phy_axg_pcie_power_off, > > + .reset = phy_axg_pcie_reset, > > + .owner = THIS_MODULE, > > +}; > > + > > +static int phy_axg_pcie_probe(struct platform_device *pdev) > > +{ > > + struct phy_provider *pphy; > > + struct device *dev = &pdev->dev; > > + struct phy_axg_pcie_priv *priv; > > + struct device_node *np = dev->of_node; > > + struct resource *res; > > + void __iomem *base; > > + int ret; > > + > > + priv = devm_kmalloc(dev, sizeof(*priv), GFP_KERNEL); > > + if (!priv) > > + return -ENOMEM; > > + > > + priv->phy = devm_phy_create(dev, np, &phy_axg_pcie_ops); > > + if (IS_ERR(priv->phy)) { > > + ret = PTR_ERR(priv->phy); > > + if (ret != -EPROBE_DEFER) > > + dev_err(dev, "failed to create PHY\n"); > > + return ret; > > + } > > + > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + base = devm_ioremap_resource(dev, res); > > + if (IS_ERR(base)) > > + return PTR_ERR(base); > > + > > + priv->regmap = devm_regmap_init_mmio(dev, base, > > + &phy_axg_pcie_regmap_conf); > > + if (IS_ERR(priv->regmap)) > > + return PTR_ERR(priv->regmap); > > + > > + priv->reset = devm_reset_control_array_get(dev, false, false); > > + if (IS_ERR(priv->reset)) > > + return PTR_ERR(priv->reset); > > + > > + priv->analog = devm_phy_get(dev, "analog"); > > + if (IS_ERR(priv->analog)) > > + return PTR_ERR(priv->analog); > > + > > + phy_set_drvdata(priv->phy, priv); > > + dev_set_drvdata(dev, priv); > > + pphy = devm_of_phy_provider_register(dev, of_phy_simple_xlate); > > + > > + return PTR_ERR_OR_ZERO(pphy); > > +} > > + > > +static const struct of_device_id phy_axg_pcie_of_match[] = { > > + { > > + .compatible = "amlogic,axg-pcie-phy", > > + }, > > + { }, > > +}; > > +MODULE_DEVICE_TABLE(of, phy_axg_pcie_of_match); > > + > > +static struct platform_driver phy_axg_pcie_driver = { > > + .probe = phy_axg_pcie_probe, > > + .driver = { > > + .name = "phy-axg-pcie", > > + .of_match_table = phy_axg_pcie_of_match, > > + }, > > +}; > > +module_platform_driver(phy_axg_pcie_driver); > > + > > +MODULE_AUTHOR("Remi Pommarel "); > > +MODULE_DESCRIPTION("Amlogic AXG PCIE PHY driver"); > > +MODULE_LICENSE("GPL v2"); > > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic