* [PATCH] clk: meson: meson8b: Drop CLK_IS_CRITICAL from fclk_div2
@ 2020-06-20 16:14 Martin Blumenstingl
2020-06-25 6:30 ` Jerome Brunet
2020-08-17 17:48 ` patchwork-bot+linux-amlogic
0 siblings, 2 replies; 3+ messages in thread
From: Martin Blumenstingl @ 2020-06-20 16:14 UTC (permalink / raw)
To: jbrunet, linux-amlogic
Cc: Martin Blumenstingl, linux-kernel, linux-clk, linux-arm-kernel,
narmstrong
Drop CLK_IS_CRITICAL from fclk_div2. This was added because we didn't
know the relation between this clock and RGMII Ethernet. It turns out
that fclk_div2 is used as "timing adjustment clock" to generate the RX
delay on the MAC side - which was enabled by u-boot on Odriod-C1. When
using the RX delay on the PHY side or not using a RX delay at all then
this clock can be disabled.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
drivers/clk/meson/meson8b.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c
index edc09d050ecf..3d826711c820 100644
--- a/drivers/clk/meson/meson8b.c
+++ b/drivers/clk/meson/meson8b.c
@@ -293,13 +293,6 @@ static struct clk_regmap meson8b_fclk_div2 = {
&meson8b_fclk_div2_div.hw
},
.num_parents = 1,
- /*
- * FIXME: Ethernet with a RGMII PHYs is not working if
- * fclk_div2 is disabled. it is currently unclear why this
- * is. keep it enabled until the Ethernet driver knows how
- * to manage this clock.
- */
- .flags = CLK_IS_CRITICAL,
},
};
--
2.27.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: meson: meson8b: Drop CLK_IS_CRITICAL from fclk_div2
2020-06-20 16:14 [PATCH] clk: meson: meson8b: Drop CLK_IS_CRITICAL from fclk_div2 Martin Blumenstingl
@ 2020-06-25 6:30 ` Jerome Brunet
2020-08-17 17:48 ` patchwork-bot+linux-amlogic
1 sibling, 0 replies; 3+ messages in thread
From: Jerome Brunet @ 2020-06-25 6:30 UTC (permalink / raw)
To: Martin Blumenstingl, linux-amlogic
Cc: linux-kernel, linux-clk, linux-arm-kernel, narmstrong
On Sat 20 Jun 2020 at 18:14, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Drop CLK_IS_CRITICAL from fclk_div2. This was added because we didn't
> know the relation between this clock and RGMII Ethernet. It turns out
> that fclk_div2 is used as "timing adjustment clock" to generate the RX
> delay on the MAC side - which was enabled by u-boot on Odriod-C1. When
> using the RX delay on the PHY side or not using a RX delay at all then
> this clock can be disabled.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Applied. Thx
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: meson: meson8b: Drop CLK_IS_CRITICAL from fclk_div2
2020-06-20 16:14 [PATCH] clk: meson: meson8b: Drop CLK_IS_CRITICAL from fclk_div2 Martin Blumenstingl
2020-06-25 6:30 ` Jerome Brunet
@ 2020-08-17 17:48 ` patchwork-bot+linux-amlogic
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-amlogic @ 2020-08-17 17:48 UTC (permalink / raw)
To: Martin Blumenstingl; +Cc: linux-amlogic, khilman
Hello:
This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next).
On Sat, 20 Jun 2020 18:14:22 +0200 you wrote:
> Drop CLK_IS_CRITICAL from fclk_div2. This was added because we didn't
> know the relation between this clock and RGMII Ethernet. It turns out
> that fclk_div2 is used as "timing adjustment clock" to generate the RX
> delay on the MAC side - which was enabled by u-boot on Odriod-C1. When
> using the RX delay on the PHY side or not using a RX delay at all then
> this clock can be disabled.
>
> [...]
Here is a summary with links:
- clk: meson: meson8b: Drop CLK_IS_CRITICAL from fclk_div2
https://git.kernel.org/khilman/linux-amlogic/c/d4db5721f3c847df43b967d9f02994b15e4a48e6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/pwbot
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-17 17:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-20 16:14 [PATCH] clk: meson: meson8b: Drop CLK_IS_CRITICAL from fclk_div2 Martin Blumenstingl
2020-06-25 6:30 ` Jerome Brunet
2020-08-17 17:48 ` patchwork-bot+linux-amlogic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).