* [PATCH] drm: meson_drv add shutdown function
@ 2021-03-02 4:22 Artem Lapkin
2021-03-08 9:00 ` Neil Armstrong
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Artem Lapkin @ 2021-03-02 4:22 UTC (permalink / raw)
To: narmstrong
Cc: gouwa, martin.blumenstingl, khilman, christianshewitt,
linux-kernel, dri-devel, nick, linux-amlogic, art,
linux-arm-kernel, jbrunet
Problem: random stucks on reboot stage about 1/20 stuck/reboots
// debug kernel log
[ 4.496660] reboot: kernel restart prepare CMD:(null)
[ 4.498114] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown begin
[ 4.503949] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown domain 0:VPU...
...STUCK...
Solution: add shutdown function to meson_drm driver
// debug kernel log
[ 5.231896] reboot: kernel restart prepare CMD:(null)
[ 5.246135] [drm:meson_drv_shutdown]
...
[ 5.259271] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown begin
[ 5.274688] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown domain 0:VPU...
[ 5.338331] reboot: Restarting system
[ 5.358293] psci: PSCI_0_2_FN_SYSTEM_RESET reboot_mode:0 cmd:(null)
bl31 reboot reason: 0xd
bl31 reboot reason: 0x0
system cmd 1.
...REBOOT...
Tested: on VIM1 VIM2 VIM3 VIM3L khadas sbcs - 1000+ successful reboots
and Odroid boards, WeTek Play2 (GXBB)
Tested-by: Christian Hewitt <christianshewitt@gmail.com>
Signed-off-by: Artem Lapkin <art@khadas.com>
---
drivers/gpu/drm/meson/meson_drv.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
index 42c5d3246..693bb1293 100644
--- a/drivers/gpu/drm/meson/meson_drv.c
+++ b/drivers/gpu/drm/meson/meson_drv.c
@@ -482,6 +482,16 @@ static int meson_probe_remote(struct platform_device *pdev,
return count;
}
+static void meson_drv_shutdown(struct platform_device *pdev)
+{
+ struct meson_drm *priv = dev_get_drvdata(&pdev->dev);
+ struct drm_device *drm = priv->drm;
+
+ DRM_DEBUG_DRIVER("\n");
+ drm_kms_helper_poll_fini(drm);
+ drm_atomic_helper_shutdown(drm);
+}
+
static int meson_drv_probe(struct platform_device *pdev)
{
struct component_match *match = NULL;
@@ -553,6 +563,7 @@ static const struct dev_pm_ops meson_drv_pm_ops = {
static struct platform_driver meson_drm_platform_driver = {
.probe = meson_drv_probe,
+ .shutdown = meson_drv_shutdown,
.driver = {
.name = "meson-drm",
.of_match_table = dt_match,
--
2.25.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] drm: meson_drv add shutdown function
2021-03-02 4:22 [PATCH] drm: meson_drv add shutdown function Artem Lapkin
@ 2021-03-08 9:00 ` Neil Armstrong
2021-03-08 17:30 ` Kevin Hilman
2021-03-09 8:23 ` Neil Armstrong
2 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2021-03-08 9:00 UTC (permalink / raw)
To: Artem Lapkin
Cc: khilman, jbrunet, martin.blumenstingl, dri-devel,
linux-arm-kernel, linux-amlogic, linux-kernel, christianshewitt,
art, nick, gouwa
On 02/03/2021 05:22, Artem Lapkin wrote:
> Problem: random stucks on reboot stage about 1/20 stuck/reboots
> // debug kernel log
> [ 4.496660] reboot: kernel restart prepare CMD:(null)
> [ 4.498114] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown begin
> [ 4.503949] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown domain 0:VPU...
> ...STUCK...
>
> Solution: add shutdown function to meson_drm driver
> // debug kernel log
> [ 5.231896] reboot: kernel restart prepare CMD:(null)
> [ 5.246135] [drm:meson_drv_shutdown]
> ...
> [ 5.259271] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown begin
> [ 5.274688] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown domain 0:VPU...
> [ 5.338331] reboot: Restarting system
> [ 5.358293] psci: PSCI_0_2_FN_SYSTEM_RESET reboot_mode:0 cmd:(null)
> bl31 reboot reason: 0xd
> bl31 reboot reason: 0x0
> system cmd 1.
> ...REBOOT...
>
> Tested: on VIM1 VIM2 VIM3 VIM3L khadas sbcs - 1000+ successful reboots
> and Odroid boards, WeTek Play2 (GXBB)
>
Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller")
> Tested-by: Christian Hewitt <christianshewitt@gmail.com>
> Signed-off-by: Artem Lapkin <art@khadas.com>
>
> ---
> drivers/gpu/drm/meson/meson_drv.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
> index 42c5d3246..693bb1293 100644
> --- a/drivers/gpu/drm/meson/meson_drv.c
> +++ b/drivers/gpu/drm/meson/meson_drv.c
> @@ -482,6 +482,16 @@ static int meson_probe_remote(struct platform_device *pdev,
> return count;
> }
>
> +static void meson_drv_shutdown(struct platform_device *pdev)
> +{
> + struct meson_drm *priv = dev_get_drvdata(&pdev->dev);
> + struct drm_device *drm = priv->drm;
> +
> + DRM_DEBUG_DRIVER("\n");
> + drm_kms_helper_poll_fini(drm);
> + drm_atomic_helper_shutdown(drm);
> +}
> +
> static int meson_drv_probe(struct platform_device *pdev)
> {
> struct component_match *match = NULL;
> @@ -553,6 +563,7 @@ static const struct dev_pm_ops meson_drv_pm_ops = {
>
> static struct platform_driver meson_drm_platform_driver = {
> .probe = meson_drv_probe,
> + .shutdown = meson_drv_shutdown,
> .driver = {
> .name = "meson-drm",
> .of_match_table = dt_match,
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm: meson_drv add shutdown function
2021-03-02 4:22 [PATCH] drm: meson_drv add shutdown function Artem Lapkin
2021-03-08 9:00 ` Neil Armstrong
@ 2021-03-08 17:30 ` Kevin Hilman
2021-03-09 8:23 ` Neil Armstrong
2 siblings, 0 replies; 7+ messages in thread
From: Kevin Hilman @ 2021-03-08 17:30 UTC (permalink / raw)
To: Artem Lapkin, narmstrong
Cc: jbrunet, martin.blumenstingl, dri-devel, linux-arm-kernel,
linux-amlogic, linux-kernel, christianshewitt, art, nick, gouwa
Artem Lapkin <email2tema@gmail.com> writes:
> Problem: random stucks on reboot stage about 1/20 stuck/reboots
> // debug kernel log
> [ 4.496660] reboot: kernel restart prepare CMD:(null)
> [ 4.498114] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown begin
> [ 4.503949] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown domain 0:VPU...
> ...STUCK...
>
> Solution: add shutdown function to meson_drm driver
> // debug kernel log
> [ 5.231896] reboot: kernel restart prepare CMD:(null)
> [ 5.246135] [drm:meson_drv_shutdown]
> ...
> [ 5.259271] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown begin
> [ 5.274688] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown domain 0:VPU...
> [ 5.338331] reboot: Restarting system
> [ 5.358293] psci: PSCI_0_2_FN_SYSTEM_RESET reboot_mode:0 cmd:(null)
> bl31 reboot reason: 0xd
> bl31 reboot reason: 0x0
> system cmd 1.
> ...REBOOT...
>
> Tested: on VIM1 VIM2 VIM3 VIM3L khadas sbcs - 1000+ successful reboots
> and Odroid boards, WeTek Play2 (GXBB)
>
> Tested-by: Christian Hewitt <christianshewitt@gmail.com>
> Signed-off-by: Artem Lapkin <art@khadas.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm: meson_drv add shutdown function
2021-03-02 4:22 [PATCH] drm: meson_drv add shutdown function Artem Lapkin
2021-03-08 9:00 ` Neil Armstrong
2021-03-08 17:30 ` Kevin Hilman
@ 2021-03-09 8:23 ` Neil Armstrong
2021-03-09 17:13 ` Kevin Hilman
2 siblings, 1 reply; 7+ messages in thread
From: Neil Armstrong @ 2021-03-09 8:23 UTC (permalink / raw)
To: Artem Lapkin
Cc: khilman, jbrunet, martin.blumenstingl, dri-devel,
linux-arm-kernel, linux-amlogic, linux-kernel, christianshewitt,
art, nick, gouwa
On 02/03/2021 05:22, Artem Lapkin wrote:
> Problem: random stucks on reboot stage about 1/20 stuck/reboots
> // debug kernel log
> [ 4.496660] reboot: kernel restart prepare CMD:(null)
> [ 4.498114] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown begin
> [ 4.503949] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown domain 0:VPU...
> ...STUCK...
>
> Solution: add shutdown function to meson_drm driver
> // debug kernel log
> [ 5.231896] reboot: kernel restart prepare CMD:(null)
> [ 5.246135] [drm:meson_drv_shutdown]
> ...
> [ 5.259271] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown begin
> [ 5.274688] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown domain 0:VPU...
> [ 5.338331] reboot: Restarting system
> [ 5.358293] psci: PSCI_0_2_FN_SYSTEM_RESET reboot_mode:0 cmd:(null)
> bl31 reboot reason: 0xd
> bl31 reboot reason: 0x0
> system cmd 1.
> ...REBOOT...
>
> Tested: on VIM1 VIM2 VIM3 VIM3L khadas sbcs - 1000+ successful reboots
> and Odroid boards, WeTek Play2 (GXBB)
>
> Tested-by: Christian Hewitt <christianshewitt@gmail.com>
> Signed-off-by: Artem Lapkin <art@khadas.com>
>
> ---
> drivers/gpu/drm/meson/meson_drv.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
> index 42c5d3246..693bb1293 100644
> --- a/drivers/gpu/drm/meson/meson_drv.c
> +++ b/drivers/gpu/drm/meson/meson_drv.c
> @@ -482,6 +482,16 @@ static int meson_probe_remote(struct platform_device *pdev,
> return count;
> }
>
> +static void meson_drv_shutdown(struct platform_device *pdev)
> +{
> + struct meson_drm *priv = dev_get_drvdata(&pdev->dev);
> + struct drm_device *drm = priv->drm;
> +
> + DRM_DEBUG_DRIVER("\n");
> + drm_kms_helper_poll_fini(drm);
> + drm_atomic_helper_shutdown(drm);
> +}
> +
> static int meson_drv_probe(struct platform_device *pdev)
> {
> struct component_match *match = NULL;
> @@ -553,6 +563,7 @@ static const struct dev_pm_ops meson_drv_pm_ops = {
>
> static struct platform_driver meson_drm_platform_driver = {
> .probe = meson_drv_probe,
> + .shutdown = meson_drv_shutdown,
> .driver = {
> .name = "meson-drm",
> .of_match_table = dt_match,
>
Applied to drm-misc-fixes,
Thanks !
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm: meson_drv add shutdown function
2021-03-09 8:23 ` Neil Armstrong
@ 2021-03-09 17:13 ` Kevin Hilman
2021-03-09 17:22 ` Neil Armstrong
0 siblings, 1 reply; 7+ messages in thread
From: Kevin Hilman @ 2021-03-09 17:13 UTC (permalink / raw)
To: Neil Armstrong, Artem Lapkin
Cc: jbrunet, martin.blumenstingl, dri-devel, linux-arm-kernel,
linux-amlogic, linux-kernel, christianshewitt, art, nick, gouwa
Hi Neil,
Neil Armstrong <narmstrong@baylibre.com> writes:
> On 02/03/2021 05:22, Artem Lapkin wrote:
>> Problem: random stucks on reboot stage about 1/20 stuck/reboots
>> // debug kernel log
>> [ 4.496660] reboot: kernel restart prepare CMD:(null)
>> [ 4.498114] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown begin
>> [ 4.503949] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown domain 0:VPU...
>> ...STUCK...
>>
>> Solution: add shutdown function to meson_drm driver
>> // debug kernel log
>> [ 5.231896] reboot: kernel restart prepare CMD:(null)
>> [ 5.246135] [drm:meson_drv_shutdown]
>> ...
>> [ 5.259271] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown begin
>> [ 5.274688] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown domain 0:VPU...
>> [ 5.338331] reboot: Restarting system
>> [ 5.358293] psci: PSCI_0_2_FN_SYSTEM_RESET reboot_mode:0 cmd:(null)
>> bl31 reboot reason: 0xd
>> bl31 reboot reason: 0x0
>> system cmd 1.
>> ...REBOOT...
>>
>> Tested: on VIM1 VIM2 VIM3 VIM3L khadas sbcs - 1000+ successful reboots
>> and Odroid boards, WeTek Play2 (GXBB)
>>
>> Tested-by: Christian Hewitt <christianshewitt@gmail.com>
>> Signed-off-by: Artem Lapkin <art@khadas.com>
>>
>> ---
>> drivers/gpu/drm/meson/meson_drv.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
>> index 42c5d3246..693bb1293 100644
>> --- a/drivers/gpu/drm/meson/meson_drv.c
>> +++ b/drivers/gpu/drm/meson/meson_drv.c
>> @@ -482,6 +482,16 @@ static int meson_probe_remote(struct platform_device *pdev,
>> return count;
>> }
>>
>> +static void meson_drv_shutdown(struct platform_device *pdev)
>> +{
>> + struct meson_drm *priv = dev_get_drvdata(&pdev->dev);
>> + struct drm_device *drm = priv->drm;
>> +
>> + DRM_DEBUG_DRIVER("\n");
>> + drm_kms_helper_poll_fini(drm);
>> + drm_atomic_helper_shutdown(drm);
>> +}
>> +
>> static int meson_drv_probe(struct platform_device *pdev)
>> {
>> struct component_match *match = NULL;
>> @@ -553,6 +563,7 @@ static const struct dev_pm_ops meson_drv_pm_ops = {
>>
>> static struct platform_driver meson_drm_platform_driver = {
>> .probe = meson_drv_probe,
>> + .shutdown = meson_drv_shutdown,
>> .driver = {
>> .name = "meson-drm",
>> .of_match_table = dt_match,
>>
>
> Applied to drm-misc-fixes,
Could you submit this as a fix to stable (v5.10+) also?
Thanks,
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm: meson_drv add shutdown function
2021-03-09 17:13 ` Kevin Hilman
@ 2021-03-09 17:22 ` Neil Armstrong
2021-03-09 17:50 ` Kevin Hilman
0 siblings, 1 reply; 7+ messages in thread
From: Neil Armstrong @ 2021-03-09 17:22 UTC (permalink / raw)
To: Kevin Hilman, Artem Lapkin
Cc: jbrunet, martin.blumenstingl, dri-devel, linux-arm-kernel,
linux-amlogic, linux-kernel, christianshewitt, art, nick, gouwa
On 09/03/2021 18:13, Kevin Hilman wrote:
> Hi Neil,
>
> Neil Armstrong <narmstrong@baylibre.com> writes:
>
>> On 02/03/2021 05:22, Artem Lapkin wrote:
>>> Problem: random stucks on reboot stage about 1/20 stuck/reboots
>>> // debug kernel log
>>> [ 4.496660] reboot: kernel restart prepare CMD:(null)
>>> [ 4.498114] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown begin
>>> [ 4.503949] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown domain 0:VPU...
>>> ...STUCK...
>>>
>>> Solution: add shutdown function to meson_drm driver
>>> // debug kernel log
>>> [ 5.231896] reboot: kernel restart prepare CMD:(null)
>>> [ 5.246135] [drm:meson_drv_shutdown]
>>> ...
>>> [ 5.259271] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown begin
>>> [ 5.274688] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown domain 0:VPU...
>>> [ 5.338331] reboot: Restarting system
>>> [ 5.358293] psci: PSCI_0_2_FN_SYSTEM_RESET reboot_mode:0 cmd:(null)
>>> bl31 reboot reason: 0xd
>>> bl31 reboot reason: 0x0
>>> system cmd 1.
>>> ...REBOOT...
>>>
>>> Tested: on VIM1 VIM2 VIM3 VIM3L khadas sbcs - 1000+ successful reboots
>>> and Odroid boards, WeTek Play2 (GXBB)
>>>
>>> Tested-by: Christian Hewitt <christianshewitt@gmail.com>
>>> Signed-off-by: Artem Lapkin <art@khadas.com>
>>>
>>> ---
>>> drivers/gpu/drm/meson/meson_drv.c | 11 +++++++++++
>>> 1 file changed, 11 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
>>> index 42c5d3246..693bb1293 100644
>>> --- a/drivers/gpu/drm/meson/meson_drv.c
>>> +++ b/drivers/gpu/drm/meson/meson_drv.c
>>> @@ -482,6 +482,16 @@ static int meson_probe_remote(struct platform_device *pdev,
>>> return count;
>>> }
>>>
>>> +static void meson_drv_shutdown(struct platform_device *pdev)
>>> +{
>>> + struct meson_drm *priv = dev_get_drvdata(&pdev->dev);
>>> + struct drm_device *drm = priv->drm;
>>> +
>>> + DRM_DEBUG_DRIVER("\n");
>>> + drm_kms_helper_poll_fini(drm);
>>> + drm_atomic_helper_shutdown(drm);
>>> +}
>>> +
>>> static int meson_drv_probe(struct platform_device *pdev)
>>> {
>>> struct component_match *match = NULL;
>>> @@ -553,6 +563,7 @@ static const struct dev_pm_ops meson_drv_pm_ops = {
>>>
>>> static struct platform_driver meson_drm_platform_driver = {
>>> .probe = meson_drv_probe,
>>> + .shutdown = meson_drv_shutdown,
>>> .driver = {
>>> .name = "meson-drm",
>>> .of_match_table = dt_match,
>>>
>>
>> Applied to drm-misc-fixes,
>
> Could you submit this as a fix to stable (v5.10+) also?
It should be done automagically since I added the Fixes tag
neil
>
> Thanks,
>
> Kevin
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm: meson_drv add shutdown function
2021-03-09 17:22 ` Neil Armstrong
@ 2021-03-09 17:50 ` Kevin Hilman
0 siblings, 0 replies; 7+ messages in thread
From: Kevin Hilman @ 2021-03-09 17:50 UTC (permalink / raw)
To: Neil Armstrong, Artem Lapkin
Cc: jbrunet, martin.blumenstingl, dri-devel, linux-arm-kernel,
linux-amlogic, linux-kernel, christianshewitt, art, nick, gouwa
Neil Armstrong <narmstrong@baylibre.com> writes:
> On 09/03/2021 18:13, Kevin Hilman wrote:
>> Hi Neil,
>>
>> Neil Armstrong <narmstrong@baylibre.com> writes:
>>
>>> On 02/03/2021 05:22, Artem Lapkin wrote:
>>>> Problem: random stucks on reboot stage about 1/20 stuck/reboots
>>>> // debug kernel log
>>>> [ 4.496660] reboot: kernel restart prepare CMD:(null)
>>>> [ 4.498114] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown begin
>>>> [ 4.503949] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown domain 0:VPU...
>>>> ...STUCK...
>>>>
>>>> Solution: add shutdown function to meson_drm driver
>>>> // debug kernel log
>>>> [ 5.231896] reboot: kernel restart prepare CMD:(null)
>>>> [ 5.246135] [drm:meson_drv_shutdown]
>>>> ...
>>>> [ 5.259271] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown begin
>>>> [ 5.274688] meson_ee_pwrc c883c000.system-controller:power-controller: shutdown domain 0:VPU...
>>>> [ 5.338331] reboot: Restarting system
>>>> [ 5.358293] psci: PSCI_0_2_FN_SYSTEM_RESET reboot_mode:0 cmd:(null)
>>>> bl31 reboot reason: 0xd
>>>> bl31 reboot reason: 0x0
>>>> system cmd 1.
>>>> ...REBOOT...
>>>>
>>>> Tested: on VIM1 VIM2 VIM3 VIM3L khadas sbcs - 1000+ successful reboots
>>>> and Odroid boards, WeTek Play2 (GXBB)
>>>>
>>>> Tested-by: Christian Hewitt <christianshewitt@gmail.com>
>>>> Signed-off-by: Artem Lapkin <art@khadas.com>
>>>>
>>>> ---
>>>> drivers/gpu/drm/meson/meson_drv.c | 11 +++++++++++
>>>> 1 file changed, 11 insertions(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
>>>> index 42c5d3246..693bb1293 100644
>>>> --- a/drivers/gpu/drm/meson/meson_drv.c
>>>> +++ b/drivers/gpu/drm/meson/meson_drv.c
>>>> @@ -482,6 +482,16 @@ static int meson_probe_remote(struct platform_device *pdev,
>>>> return count;
>>>> }
>>>>
>>>> +static void meson_drv_shutdown(struct platform_device *pdev)
>>>> +{
>>>> + struct meson_drm *priv = dev_get_drvdata(&pdev->dev);
>>>> + struct drm_device *drm = priv->drm;
>>>> +
>>>> + DRM_DEBUG_DRIVER("\n");
>>>> + drm_kms_helper_poll_fini(drm);
>>>> + drm_atomic_helper_shutdown(drm);
>>>> +}
>>>> +
>>>> static int meson_drv_probe(struct platform_device *pdev)
>>>> {
>>>> struct component_match *match = NULL;
>>>> @@ -553,6 +563,7 @@ static const struct dev_pm_ops meson_drv_pm_ops = {
>>>>
>>>> static struct platform_driver meson_drm_platform_driver = {
>>>> .probe = meson_drv_probe,
>>>> + .shutdown = meson_drv_shutdown,
>>>> .driver = {
>>>> .name = "meson-drm",
>>>> .of_match_table = dt_match,
>>>>
>>>
>>> Applied to drm-misc-fixes,
>>
>> Could you submit this as a fix to stable (v5.10+) also?
>
> It should be done automagically since I added the Fixes tag
Oh, I didn't see the fixes tag, sorry.
Thanks!
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-03-09 17:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-02 4:22 [PATCH] drm: meson_drv add shutdown function Artem Lapkin
2021-03-08 9:00 ` Neil Armstrong
2021-03-08 17:30 ` Kevin Hilman
2021-03-09 8:23 ` Neil Armstrong
2021-03-09 17:13 ` Kevin Hilman
2021-03-09 17:22 ` Neil Armstrong
2021-03-09 17:50 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).