From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE9F8C433DB for ; Mon, 22 Feb 2021 09:02:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 335B664E61 for ; Mon, 22 Feb 2021 09:02:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 335B664E61 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wm5rhfohrzs80O4F1xq3zS4EGAktrXswnkajhCGhfdI=; b=OSJcd7OsRjNuj8WRHu75icW7x bMsJ7s3riGnV8orogm8LFKOdQrb05dudUuXD9c7rlqsar6s8RrC+fQO1maazq1lBIEygzLno4XrMJ yV7HKD4IFo9AypJIWstfZhfHN2/AqRi7xlghxxsl/qrEH229GRspfinckzpQAjv+u6zzQ90TalXwy B0hjcI3AO0r+G9c+WZpRurd/Qo7wAOfu8xRLfYjfmN5aKRUv2JZkJgWc4LZsgRf+9vj55UNdO4V7y 5Mn6Bqe29iOd/Bba/lJKr+kFuF4Pd6fuoIZJ+mUjGSAfr2NQojVM6RWc8S4mX40xzEJ/wU0HNgs2z Erro7J5Hg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lE76T-0005i8-Ue; Mon, 22 Feb 2021 09:02:05 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lE76R-0005gZ-79; Mon, 22 Feb 2021 09:02:04 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E218DAF99; Mon, 22 Feb 2021 09:02:01 +0000 (UTC) Subject: Re: [PATCH v3 02/11] drm: Rename plane atomic_check state names To: Maxime Ripard References: <20210219120032.260676-1-maxime@cerno.tech> <20210219120032.260676-2-maxime@cerno.tech> <51bb5aaf-f771-020b-9a48-77d8679de6a2@suse.de> <20210219151235.dsv4mujqyrzndhsn@gilmour> From: Thomas Zimmermann Message-ID: <2abb00b3-23d2-e652-4194-a10fbf171b88@suse.de> Date: Mon, 22 Feb 2021 10:01:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210219151235.dsv4mujqyrzndhsn@gilmour> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210222_040203_659532_D9B8A115 X-CRM114-Status: GOOD ( 22.50 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Xinliang Liu , dri-devel@lists.freedesktop.org, Anitha Chrisanthus , linux-stm32@st-md-mailman.stormreply.com, Jerome Brunet , linux-samsung-soc@vger.kernel.org, Kevin Hilman , Michal Simek , NXP Linux Team , VMware Graphics , Leo Li , Sascha Hauer , Roland Scheidegger , Inki Dae , Sean Paul , Hyun Kwon , Seung-Woo Kim , linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Alex Deucher , freedreno@lists.freedesktop.org, Zack Rusin , Gerd Hoffmann , David Airlie , nouveau@lists.freedesktop.org, Edmund Dea , virtualization@lists.linux-foundation.org, Eric Anholt , Thierry Reding , Daniel Vetter , Mihail Atanassov , Krzysztof Kozlowski , Jonathan Hunter , linux-rockchip@lists.infradead.org, "James \(Qian\) Wang" , Ben Skeggs , Dave Airlie , Alexandre Torgue , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, John Stultz , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rodrigo Siqueira , Sandy Huang , Yannick Fertre , Kyungmin Park , Maxime Coquelin , Brian Starkey , Haneen Mohammed , Neil Armstrong , Stefan Agner , Melissa Wen , linux-tegra@vger.kernel.org, Laurent Pinchart , Benjamin Gaignard , Fabio Estevam , Xinwei Kong , amd-gfx@lists.freedesktop.org, Chen-Yu Tsai , Harry Wentland , Chun-Kuang Hu , Chen Feng , Alison Wang , spice-devel@lists.freedesktop.org, Tomi Valkeinen , Philippe Cornu , Vincent Abriou , Kieran Bingham , Tian Tao , Shawn Guo , =?UTF-8?Q?Christian_K=c3=b6nig?= , Liviu Dudau , Paul Cercueil , linux-renesas-soc@vger.kernel.org, Joonyoung Shim , Russell King , Daniel Vetter , Maarten Lankhorst , linux-mediatek@lists.infradead.org, Laurentiu Palcu , Matthias Brugger , Jernej Skrabec , linux-mips@vger.kernel.org, Rob Clark , Philipp Zabel , Jyri Sarha , Lucas Stach Content-Type: multipart/mixed; boundary="===============2677964454529805277==" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============2677964454529805277== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="w1lSYWSR69EiDDUmRFseCwFhMSFWd2baX" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --w1lSYWSR69EiDDUmRFseCwFhMSFWd2baX Content-Type: multipart/mixed; boundary="sEqTb7DLvEQPgunNTOiF1zujXM8e72iqO"; protected-headers="v1" From: Thomas Zimmermann To: Maxime Ripard Cc: Maarten Lankhorst , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, Laurent Pinchart , Harry Wentland , Leo Li , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , Daniel Vetter , "James (Qian) Wang" , Liviu Dudau , Mihail Atanassov , Brian Starkey , Russell King , Dave Airlie , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Stefan Agner , Alison Wang , Xinliang Liu , Tian Tao , John Stultz , Xinwei Kong , Chen Feng , Laurentiu Palcu , Lucas Stach , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Paul Cercueil , Anitha Chrisanthus , Edmund Dea , Chun-Kuang Hu , Matthias Brugger , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Clark , Sean Paul , Ben Skeggs , Tomi Valkeinen , Gerd Hoffmann , Kieran Bingham , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Benjamin Gaignard , Vincent Abriou , Yannick Fertre , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Thierry Reding , Jonathan Hunter , Jyri Sarha , Eric Anholt , Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , VMware Graphics , Roland Scheidegger , Zack Rusin , Hyun Kwon , Michal Simek , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org Message-ID: <2abb00b3-23d2-e652-4194-a10fbf171b88@suse.de> Subject: Re: [PATCH v3 02/11] drm: Rename plane atomic_check state names References: <20210219120032.260676-1-maxime@cerno.tech> <20210219120032.260676-2-maxime@cerno.tech> <51bb5aaf-f771-020b-9a48-77d8679de6a2@suse.de> <20210219151235.dsv4mujqyrzndhsn@gilmour> In-Reply-To: <20210219151235.dsv4mujqyrzndhsn@gilmour> --sEqTb7DLvEQPgunNTOiF1zujXM8e72iqO Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 19.02.21 um 16:12 schrieb Maxime Ripard: > Hi Thomas, >=20 > Thanks for your review! >=20 > On Fri, Feb 19, 2021 at 03:49:22PM +0100, Thomas Zimmermann wrote: >>> diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/= ipuv3-plane.c >>> index 075508051b5f..1873a155bb26 100644 >>> --- a/drivers/gpu/drm/imx/ipuv3-plane.c >>> +++ b/drivers/gpu/drm/imx/ipuv3-plane.c >>> @@ -337,12 +337,12 @@ static const struct drm_plane_funcs ipu_plane_f= uncs =3D { >>> }; >>> static int ipu_plane_atomic_check(struct drm_plane *plane, >>> - struct drm_plane_state *state) >>> + struct drm_plane_state *new_state) >> >> This function uses a different naming convention then the others? >> >>> { >>> struct drm_plane_state *old_state =3D plane->state; >=20 > So, the function already had a variable named old_state, so I was > actually trying to make the drivers consistent here: having one variabl= e > with old_state and new_plane_state felt weird. >=20 > The heuristic is thus to use the convention of the driver if one exists= > already, and if there's none pick new_plane_state. >=20 > It makes it indeed inconsistent across drivers, but it felt more natura= l > to be consistent within a single driver. Makes sense. >=20 > Maxime >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=FCrnberg, Germany (HRB 36809, AG N=FCrnberg) Gesch=E4ftsf=FChrer: Felix Imend=F6rffer --sEqTb7DLvEQPgunNTOiF1zujXM8e72iqO-- --w1lSYWSR69EiDDUmRFseCwFhMSFWd2baX Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmAzcwQFAwAAAAAACgkQlh/E3EQov+BQ PRAApEdNgQ+vqv+VzwVCbZGvaYSJtb908qPub+x6G/TOtgTxy8nU/+4qswCNV1TRb47fJcScii5P muJ5755oRh4YUO4NVEtX8GKHOgjfCwpAUXuwlWMs7HX4yxmi5IlBj1w5nsFNF88DhVuB+2AEFXkd ata8+bV5tpBKfULJcNvMYIG/sYzusZAf2m8hmCGpNKXC5Y1MkdVAaNzoZDmjOMdvyC8YVmiyuQYm XH6RqvBNEdrVf8QpbecMX946GtVx/ZYhheMzeojAjs6BSN56nkEbFyeDTDZy5Dj2exfMb7r4c2Md yXh3NGjtYAZc9AYFG5Gm23hEioOh1NeLQm5V2YA7FxtDqonl3w1pTvIBSdb/6tBAPFUWfiMOZIkI FgBteGCFHY7zTITnY+R0RGDY6oFZApyVwiXtxj2bybCEyBG7dHBAJ7ga+tRvT7fG5T94Q6y1cyKj v86blGFaPEZYZfeRbwrKbmwq/fbT6/OFH7eZLxzn5fLH1NJora6NM5gDXssJ77KwbVhbra2uzHuB uzpM8wC0JU7YFsd8boCIoxlST7QHttvFX8pSd///+Hub0U1/QXZPfQ4t0J1AheysqA/onDRoyd8U k3hPMvUtSmZwZSAGSO/6jzkR1Tki5qIgqmKJ6VDh8w7gpWSnDWkXcPiQlrNo4sWJnQQgDrL11BMb e3E= =cO2r -----END PGP SIGNATURE----- --w1lSYWSR69EiDDUmRFseCwFhMSFWd2baX-- --===============2677964454529805277== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic --===============2677964454529805277==--