linux-amlogic.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Jiucheng Xu <jiucheng.xu@amlogic.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH v6 4/4] arm64: dts: meson: Add DDR PMU node
Date: Mon, 5 Sep 2022 09:16:30 +0200	[thread overview]
Message-ID: <35c2cf9f-ef18-f735-9869-0b70dc1e860b@baylibre.com> (raw)
In-Reply-To: <20220901024526.2833232-4-jiucheng.xu@amlogic.com>

On 01/09/2022 04:45, Jiucheng Xu wrote:
> Add DDR PMU device node for G12 series SoC
> 
> Signed-off-by: Jiucheng Xu <jiucheng.xu@amlogic.com>
> ---
> Changes v6 -> v5:
>    - No change
> 
> Changes v5 -> v4:
>    - Split reg into two items
>    - Alphabet order location
> 
> Changes v3 -> v4:
>    - No change
> 
> Changes v2 -> v3:
>    - No change
> 
> Changes v1 -> v2:
>    - Remove model, dmc_nr, chann_nr properties
>    - Add g12a-ddr-pmu, g12b-ddr-pmu, sm1-ddr-pmu compatibles as
>      identifier
> ---
>   arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 6 ++++++
>   arch/arm64/boot/dts/amlogic/meson-g12a.dtsi       | 4 ++++
>   arch/arm64/boot/dts/amlogic/meson-g12b.dtsi       | 4 ++++
>   arch/arm64/boot/dts/amlogic/meson-sm1.dtsi        | 4 ++++
>   4 files changed, 18 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 45947c1031c4..9dbd50820b1c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -1705,6 +1705,12 @@ internal_ephy: ethernet_phy@8 {
>   			};
>   		};
>   
> +		pmu: pmu@ff638000 {
> +			reg = <0x0 0xff638000 0x0 0x100>,
> +			      <0x0 0xff638c00 0x0 0x100>;
> +			interrupts = <GIC_SPI 52 IRQ_TYPE_EDGE_RISING>;
> +		};
> +
>   		aobus: bus@ff800000 {
>   			compatible = "simple-bus";
>   			reg = <0x0 0xff800000 0x0 0x100000>;
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi
> index fb0ab27d1f64..0e8b57283f31 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi
> @@ -133,3 +133,7 @@ map1 {
>   		};
>   	};
>   };
> +
> +&pmu {
> +	compatible = "amlogic,g12a-ddr-pmu";
> +};
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi
> index ee8fcae9f9f0..18791ef51f58 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b.dtsi
> @@ -139,3 +139,7 @@ map1 {
>   &mali {
>   	dma-coherent;
>   };
> +
> +&pmu {
> +	compatible = "amlogic,g12b-ddr-pmu";
> +};
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
> index 80737731af3f..c307b34ccd72 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
> @@ -520,6 +520,10 @@ &pcie {
>   	power-domains = <&pwrc PWRC_SM1_PCIE_ID>;
>   };
>   
> +&pmu {
> +	compatible = "amlogic,sm1-ddr-pmu";
> +};
> +
>   &pwrc {
>   	compatible = "amlogic,meson-sm1-pwrc";
>   };

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2022-09-05  7:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-01  2:45 [PATCH v6 1/4] perf/amlogic: Add support for Amlogic meson G12 SoC DDR PMU driver Jiucheng Xu
2022-09-01  2:45 ` [PATCH v6 2/4] docs/perf: Add documentation for the Amlogic G12 DDR PMU Jiucheng Xu
2022-09-03 17:35   ` Chris Healy
2022-09-05  4:25     ` Jiucheng Xu
2022-09-05  7:15   ` Neil Armstrong
2022-09-01  2:45 ` [PATCH v6 3/4] dt-binding: perf: Add Amlogic " Jiucheng Xu
2022-09-01  2:45 ` [PATCH v6 4/4] arm64: dts: meson: Add DDR PMU node Jiucheng Xu
2022-09-05  7:16   ` Neil Armstrong [this message]
2022-09-05  7:15 ` [PATCH v6 1/4] perf/amlogic: Add support for Amlogic meson G12 SoC DDR PMU driver Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35c2cf9f-ef18-f735-9869-0b70dc1e860b@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=cphealy@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=jiucheng.xu@amlogic.com \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=robh+dt@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).