From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 605ACC4CECD for ; Tue, 17 Sep 2019 10:28:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34A53214AF for ; Tue, 17 Sep 2019 10:28:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mMIxG7XC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34A53214AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LsCr71nA4OdmqlwIxKGepbwPRPoT0Tavsr4izo2yRJM=; b=mMIxG7XCbIJbRI jwK9ZQ0EhDEU5NVSTrBVivJkm12ADqounpCzqDAP8jbznlC4Farkr594rhMWau3X1FuznqDV0oBCY BSWPKK74s0P5srvwDDK2cPWUkFNtMna/81njhcJ3+Dkl0Szg6l+sy+cub6E7Md11tyclCG8kTodw2 MNZ7dqK8DsMYpghvq+EP5BbtJgiCdDl63YhprJxh5FVmZNgUcqRfSNvf5lWSLILkfnrD9Xu8B5ail YZx7b79qYuvOZ3lfl3ZLf7SPyytd0T/jwEhAta3xYXSRcYvwM8alKZB48PFjryp1bb6XTsSoBi/nq SsG9+3Cb/w1ahqGREZyA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAAip-0001YL-BD; Tue, 17 Sep 2019 10:28:35 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iAAik-0001XV-L1; Tue, 17 Sep 2019 10:28:33 +0000 Received: from [10.28.18.45] (10.28.18.45) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Tue, 17 Sep 2019 18:29:23 +0800 Subject: Re: [PATCH 1/3] pinctrl: add compatible for Amlogic Meson A1 pin controller To: Neil Armstrong , Linus Walleij , References: <1568700442-18540-1-git-send-email-qianggui.song@amlogic.com> <1568700442-18540-2-git-send-email-qianggui.song@amlogic.com> <131cf06f-2530-4524-9f86-3c07641bb460@baylibre.com> From: Qianggui Song Message-ID: <3a4bdcbf-883a-cf31-6af1-a692a10cb9a5@amlogic.com> Date: Tue, 17 Sep 2019 18:29:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <131cf06f-2530-4524-9f86-3c07641bb460@baylibre.com> Content-Language: en-US X-Originating-IP: [10.28.18.45] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190917_032830_692327_72E972CC X-CRM114-Status: GOOD ( 14.96 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Hanjie Lin , Jianxin Pan , Martin Blumenstingl , Kevin Hilman , linux-kernel@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Carlo Caione , linux-amlogic@lists.infradead.org, Xingyu Chen , Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi, Neil Thanks for your review On 2019/9/17 15:18, Neil Armstrong wrote: > Hi, > > On 17/09/2019 08:07, Qianggui Song wrote: >> Add new compatible name for Amlogic's Meson-A1 pin controller >> add a dt-binding header file which document the detail pin names. > > Please add in the commit log that A1 doesn't need the DS bank reg, > so when we will convert these bindings to yaml we will be aware of it. > OK, will add it in the next patch >> >> Signed-off-by: Qianggui Song >> Signed-off-by: Xingyu Chen >> Signed-off-by: Jianxin Pan >> --- >> .../devicetree/bindings/pinctrl/meson,pinctrl.txt | 1 + >> include/dt-bindings/gpio/meson-a1-gpio.h | 73 ++++++++++++++++++++++ >> 2 files changed, 74 insertions(+) >> create mode 100644 include/dt-bindings/gpio/meson-a1-gpio.h >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt >> index 10dc4f7..0aff1f2 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt >> +++ b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt >> @@ -15,6 +15,7 @@ Required properties for the root node: >> "amlogic,meson-axg-aobus-pinctrl" >> "amlogic,meson-g12a-periphs-pinctrl" >> "amlogic,meson-g12a-aobus-pinctrl" >> + "amlogic,meson-a1-periphs-pinctrl" >> - reg: address and size of registers controlling irq functionality >> >> === GPIO sub-nodes === >> diff --git a/include/dt-bindings/gpio/meson-a1-gpio.h b/include/dt-bindings/gpio/meson-a1-gpio.h >> new file mode 100644 >> index 0000000..40e57a5 >> --- /dev/null >> +++ b/include/dt-bindings/gpio/meson-a1-gpio.h >> @@ -0,0 +1,73 @@ >> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ >> +/* >> + * Copyright (c) 2019 Amlogic, Inc. All rights reserved. >> + * Author: Qianggui Song >> + */ >> + >> +#ifndef _DT_BINDINGS_MESON_A1_GPIO_H >> +#define _DT_BINDINGS_MESON_A1_GPIO_H >> + >> +#define GPIOP_0 0 >> +#define GPIOP_1 1 >> +#define GPIOP_2 2 >> +#define GPIOP_3 3 >> +#define GPIOP_4 4 >> +#define GPIOP_5 5 >> +#define GPIOP_6 6 >> +#define GPIOP_7 7 >> +#define GPIOP_8 8 >> +#define GPIOP_9 9 >> +#define GPIOP_10 10 >> +#define GPIOP_11 11 >> +#define GPIOP_12 12 >> +#define GPIOB_0 13 >> +#define GPIOB_1 14 >> +#define GPIOB_2 15 >> +#define GPIOB_3 16 >> +#define GPIOB_4 17 >> +#define GPIOB_5 18 >> +#define GPIOB_6 19 >> +#define GPIOX_0 20 >> +#define GPIOX_1 21 >> +#define GPIOX_2 22 >> +#define GPIOX_3 23 >> +#define GPIOX_4 24 >> +#define GPIOX_5 25 >> +#define GPIOX_6 26 >> +#define GPIOX_7 27 >> +#define GPIOX_8 28 >> +#define GPIOX_9 29 >> +#define GPIOX_10 30 >> +#define GPIOX_11 31 >> +#define GPIOX_12 32 >> +#define GPIOX_13 33 >> +#define GPIOX_14 34 >> +#define GPIOX_15 35 >> +#define GPIOX_16 36 >> +#define GPIOF_0 37 >> +#define GPIOF_1 38 >> +#define GPIOF_2 39 >> +#define GPIOF_3 40 >> +#define GPIOF_4 41 >> +#define GPIOF_5 42 >> +#define GPIOF_6 43 >> +#define GPIOF_7 44 >> +#define GPIOF_8 45 >> +#define GPIOF_9 46 >> +#define GPIOF_10 47 >> +#define GPIOF_11 48 >> +#define GPIOF_12 49 >> +#define GPIOA_0 50 >> +#define GPIOA_1 51 >> +#define GPIOA_2 52 >> +#define GPIOA_3 53 >> +#define GPIOA_4 54 >> +#define GPIOA_5 55 >> +#define GPIOA_6 56 >> +#define GPIOA_7 57 >> +#define GPIOA_8 58 >> +#define GPIOA_9 59 >> +#define GPIOA_10 60 >> +#define GPIOA_11 61 >> + >> +#endif /* _DT_BINDINGS_MESON_A1_GPIO_H */ >> > > > With that fixed, > > Reviewed-by: Neil Armstrong > > Neil > > . > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic