From: Neil Armstrong <narmstrong@baylibre.com>
To: Maxime Jourdan <mjourdan@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>
Cc: linux-amlogic@lists.infradead.org, Jian Hu <jian.hu@amlogic.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: meson: g12a: fix VPU clock muxes mask
Date: Tue, 19 Mar 2019 09:32:04 +0100 [thread overview]
Message-ID: <3d3b5eff-0b66-ba90-bf56-11c5df0af6ed@baylibre.com> (raw)
In-Reply-To: <20190319082611.6215-1-mjourdan@baylibre.com>
On 19/03/2019 09:26, Maxime Jourdan wrote:
> There are 8 parents, use 0x7
>
> Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
> Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com>
> ---
> drivers/clk/meson/g12a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
> index cfb91df884cb..e52b0b53f398 100644
> --- a/drivers/clk/meson/g12a.c
> +++ b/drivers/clk/meson/g12a.c
> @@ -1391,7 +1391,7 @@ static const char * const g12a_vpu_parent_names[] = {
> static struct clk_regmap g12a_vpu_0_sel = {
> .data = &(struct clk_regmap_mux_data){
> .offset = HHI_VPU_CLK_CNTL,
> - .mask = 0x3,
> + .mask = 0x7,
> .shift = 9,
> },
> .hw.init = &(struct clk_init_data){
> @@ -1435,7 +1435,7 @@ static struct clk_regmap g12a_vpu_0 = {
> static struct clk_regmap g12a_vpu_1_sel = {
> .data = &(struct clk_regmap_mux_data){
> .offset = HHI_VPU_CLK_CNTL,
> - .mask = 0x3,
> + .mask = 0x7,
> .shift = 25,
> },
> .hw.init = &(struct clk_init_data){
>
Good catch !
I'll apply on fixes/drivers
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2019-03-19 8:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 8:26 [PATCH] clk: meson: g12a: fix VPU clock muxes mask Maxime Jourdan
2019-03-19 8:32 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d3b5eff-0b66-ba90-bf56-11c5df0af6ed@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjourdan@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).