From: Neil Armstrong <narmstrong@baylibre.com>
To: Marc Zyngier <maz@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Lee Jones <lee.jones@linaro.org>
Cc: Andrew Lunn <andrew@lunn.ch>, Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module
Date: Thu, 2 Sep 2021 11:28:33 +0200 [thread overview]
Message-ID: <44e56b25-acbb-ce3c-3f99-53a809309250@baylibre.com> (raw)
In-Reply-To: <87o89vroec.wl-maz@kernel.org>
Hi,
On 18/08/2021 13:19, Marc Zyngier wrote:
> On Tue, 17 Aug 2021 19:12:34 +0100,
> Saravana Kannan <saravanak@google.com> wrote:
>>
>> On Tue, Aug 17, 2021 at 12:24 AM Lee Jones <lee.jones@linaro.org> wrote:
>>>
>>> On Mon, 16 Aug 2021, Saravana Kannan wrote:
>>>>>>> I sent out the proper fix as a series:
>>>>>>> https://lore.kernel.org/lkml/20210804214333.927985-1-saravanak@google.com/T/#t
>>>>>>>
>>>>>>> Marc, can you give it a shot please?
>>>>>>>
>>>>>>> -Saravana
>>>>>>
>>>>>> Superstar! Thanks for taking the time to rectify this for all of us.
>>>>>
>>>>> Just to clarify:
>>>>>
>>>>> Are we waiting on a subsequent patch submission at this point?
>>>>
>>>> Not that I'm aware of. Andrew added a "Reviewed-by" to all 3 of my
>>>> proper fix patches. I didn't think I needed to send any newer patches.
>>>> Is there some reason you that I needed to?
>>>
>>> Actually, I meant *this* patch.
>>
>> I think it'll be nice if Neil addresses the stuff Marc mentioned
>> (ideally) using the macros I suggested. Not sure if Marc is waiting on
>> that though. Marc also probably wants my mdio-mux series to merge
>> first before he takes this patch. So that it doesn't break networking
>> in his device.
>
> Yup. Two things need to happen here:
>
> - the MDIO fixes must be merged (I think they are queued, from what I
> can see)
>
> - the irqchip patch must be fixed so that the driver cannot be
> unloaded (Saravana did explain what needs to be done).
I'll post a re-spin of this serie with the suggested fixes.
Neil
>
> Once these two condition are met, I'll happily take this patch.
>
> M.
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2021-09-02 9:28 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 7:25 [PATCH 0/2] irq-meson-gpio: make it possible to build as a module Neil Armstrong
2020-10-20 7:25 ` [PATCH 1/2] irqchip: " Neil Armstrong
2020-10-20 18:23 ` Kevin Hilman
[not found] ` <CAF2Aj3g6c8FEZb3e1by6sd8LpKLaeN5hsKrrQkZUvh8hosiW9A@mail.gmail.com>
2021-05-24 10:11 ` Marc Zyngier
2021-05-25 16:17 ` Kevin Hilman
2021-05-25 16:30 ` Lee Jones
2021-06-14 22:30 ` Kevin Hilman
2021-07-13 9:05 ` Lee Jones
2021-08-03 9:44 ` Marc Zyngier
2021-08-03 9:51 ` Marc Zyngier
2021-08-04 2:11 ` Saravana Kannan
2021-08-03 9:51 ` Neil Armstrong
2021-08-04 1:36 ` Saravana Kannan
2021-08-04 8:50 ` Marc Zyngier
2021-08-04 18:20 ` Saravana Kannan
2021-08-04 21:47 ` Saravana Kannan
2021-08-05 6:31 ` Neil Armstrong
2021-08-06 23:55 ` Saravana Kannan
2021-08-05 7:57 ` Lee Jones
2021-08-16 12:47 ` Lee Jones
2021-08-16 20:27 ` Saravana Kannan
2021-08-16 20:46 ` Andrew Lunn
2021-08-16 21:02 ` Saravana Kannan
2021-08-16 21:18 ` Andrew Lunn
2021-08-17 7:24 ` Lee Jones
2021-08-17 18:12 ` Saravana Kannan
2021-08-18 11:19 ` Marc Zyngier
2021-09-02 9:28 ` Neil Armstrong [this message]
2020-10-20 7:25 ` [PATCH 2/2] arm64: meson: remove MESON_IRQ_GPIO selection Neil Armstrong
2020-10-20 23:18 ` Kevin Hilman
2020-10-25 11:51 ` [PATCH 0/2] irq-meson-gpio: make it possible to build as a module Marc Zyngier
2020-10-26 16:18 ` Kevin Hilman
2020-10-26 17:00 ` Marc Zyngier
2020-10-26 17:28 ` Kevin Hilman
2020-10-26 17:33 ` Kevin Hilman
2020-10-26 18:30 ` Marc Zyngier
2020-10-26 23:45 ` Kevin Hilman
2021-09-02 13:49 Neil Armstrong
2021-09-02 13:49 ` [PATCH 1/2] irqchip: " Neil Armstrong
2021-09-02 17:00 ` Saravana Kannan
2021-09-28 10:45 ` Lee Jones
2021-09-28 23:27 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44e56b25-acbb-ce3c-3f99-53a809309250@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=andrew@lunn.ch \
--cc=jbrunet@baylibre.com \
--cc=kernel-team@android.com \
--cc=khilman@baylibre.com \
--cc=lee.jones@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).