From: Qianggui Song <qianggui.song@amlogic.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Hanjie Lin <hanjie.lin@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Carlo Caione <carlo@caione.org>,
linux-amlogic@lists.infradead.org,
Xingyu Chen <xingyu.chen@amlogic.com>
Subject: Re: [PATCH 2/3] pinctrl: meson-a1: add pinctrl driver for Meson A1 Soc
Date: Wed, 18 Sep 2019 14:36:22 +0800 [thread overview]
Message-ID: <45b97927-c771-808a-b214-509af6c16931@amlogic.com> (raw)
In-Reply-To: <1j8sqn3tjt.fsf@starbuckisacylon.baylibre.com>
On 2019/9/17 22:07, Jerome Brunet wrote:
>
> On Tue 17 Sep 2019 at 13:51, Qianggui Song <qianggui.song@amlogic.com> wrote:
>>>> diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
>>>> index 8bba9d0..885b89d 100644
>>>> --- a/drivers/pinctrl/meson/pinctrl-meson.c
>>>> +++ b/drivers/pinctrl/meson/pinctrl-meson.c
>>>> @@ -688,8 +688,12 @@ static int meson_pinctrl_parse_dt(struct meson_pinctrl *pc,
>>>>
>>>> pc->reg_ds = meson_map_resource(pc, gpio_np, "ds");
>>>> if (IS_ERR(pc->reg_ds)) {
>>>> - dev_dbg(pc->dev, "ds registers not found - skipping\n");
>>>> - pc->reg_ds = NULL;
>>>> + if (pc->data->reg_layout == A1_LAYOUT) {
>>>> + pc->reg_ds = pc->reg_pullen;
>>>
>>> IMO, this kind of ID based init fixup is not going to scale and will
>>> lead to something difficult to maintain in the end.
>>>
>>> The way the different register sets interract with each other is already
>>> pretty complex to follow.
>>>
>>> You could rework this in 2 different ways:
>>> #1 - Have the generic function parse all the register sets and have all
>>> drivers provide a specific (as in gxbb, gxl, axg, etc ...) function to :
>>> - Verify the expected sets have been provided
>>> - Make assignement fixup as above if necessary
>>>
>>> #2 - Rework the driver to have only one single register region
>>> I think one of your colleague previously mentionned this was not
>>> possible. It is still unclear to me why ...
>>>
>> Appreciate your advice. I have an idea based on #1, how about providing
>> only two dt parse function, one is for chips before A1(the old one),
>> another is for A1 and later chips that share the same layout. Assign
>> these two functions to their own driver.
>
> That's roughly the same thing as your initial proposition with function
> pointer instead of IDs ... IMO, this would still be a quick fix to
> address your immediate topic instead of dealing with the driver as
> whole, which is my concern here.
>
For #1. It would be like
generic_parse_dt()
{
1. parse all register regions (mux gpio pull pull_en ds)
2. call specific function through function pointer in
meson_pinctrl_data.(each platform should have AO and EE two
specific functions for they are not the same)
{
do work you mentioned above
}
}
right ?
If that so, maybe there are a lot of duplicated codes for most Socs
share the same reg layout. So I guess five specific functions are
enough: AXG and before(ao,ee), G12A(ao,ee) and A1(will place them in
pinctrl_meson.c). Since m8 to AXG are the same register layout for both
ee and ao, G12A with new feature ds and new ao register layout.
Or I misunderstood the #1 ?
>>>> + } else {
>>>> + dev_dbg(pc->dev, "ds registers not found - skipping\n");
>>>> + pc->reg_ds = NULL;
>>>> + }
>>>> }
>>>>
>>>> return 0;
>>>> diff --git a/drivers/pinctrl/meson/pinctrl-meson.h b/drivers/pinctrl/meson/pinctrl-meson.h
>>>> index c696f32..3d0c58d 100644
>>>> --- a/drivers/pinctrl/meson/pinctrl-meson.h
>>>> +++ b/drivers/pinctrl/meson/pinctrl-meson.h
>>>> @@ -80,6 +80,14 @@ enum meson_pinconf_drv {
>>>> };
>>>>
>>>> /**
>>>> + * enum meson_reg_layout - identify two types of reg layout
>>>> + */
>>>> +enum meson_reg_layout {
>>>> + LEGACY_LAYOUT,
>>>> + A1_LAYOUT,
>>>> +};
>>>> +
>>>> +/**
>>>> * struct meson bank
>>>> *
>>>> * @name: bank name
>>>> @@ -114,6 +122,7 @@ struct meson_pinctrl_data {
>>>> unsigned int num_banks;
>>>> const struct pinmux_ops *pmx_ops;
>>>> void *pmx_data;
>>>> + unsigned int reg_layout;
>>>> };
>>>>
>>>> struct meson_pinctrl {
>>>
>>> .
>>>
>
> .
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-09-18 6:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 6:07 [PATCH 0/3] pinctrl: meson-a1: add pinctrl driver Qianggui Song
2019-09-17 6:07 ` [PATCH 1/3] pinctrl: add compatible for Amlogic Meson A1 pin controller Qianggui Song
2019-09-17 7:18 ` Neil Armstrong
2019-09-17 10:29 ` Qianggui Song
2019-09-30 22:47 ` Rob Herring
2019-09-17 6:07 ` [PATCH 2/3] pinctrl: meson-a1: add pinctrl driver for Meson A1 Soc Qianggui Song
2019-09-17 7:15 ` Neil Armstrong
2019-09-17 10:59 ` Qianggui Song
2019-09-17 9:29 ` Jerome Brunet
2019-09-17 11:51 ` Qianggui Song
2019-09-17 14:07 ` Jerome Brunet
2019-09-18 6:36 ` Qianggui Song [this message]
2019-09-19 16:26 ` Jerome Brunet
2019-09-23 7:29 ` Qianggui Song
2019-09-17 6:07 ` [PATCH 3/3] arm64: dts: meson: a1: add pinctrl controller support Qianggui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45b97927-c771-808a-b214-509af6c16931@amlogic.com \
--to=qianggui.song@amlogic.com \
--cc=carlo@caione.org \
--cc=hanjie.lin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=xingyu.chen@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).