Linux-Amlogic Archive on lore.kernel.org
 help / color / Atom feed
* GPIO Interrupts
@ 2020-07-23 18:40 honsch@telus.net
  2020-07-24  8:03 ` Jerome Brunet
  2020-07-24  8:05 ` Neil Armstrong
  0 siblings, 2 replies; 4+ messages in thread
From: honsch@telus.net @ 2020-07-23 18:40 UTC (permalink / raw)
  To: linux-amlogic

Hi there,
I've been working on a ODroid C2 project for a while, (meson, gxbb) and I cannot get gpio interrupts working from the devicetree.

I'm trying to hook up the PPS gpio driver as well as some gpio IIO triggers.  I had it all working on a 4.x kernel a couple of years ago but on the 5.7 it's a no-go.

The pinctrl-meson driver is missing the hook for gpiod_to_irq(), and the irq-meson-gpio driver is missing the activate function for platform_get_irq() to function.

Has either of these paths ever been implemented or tested?  Am I missing something simple?
Thanks.

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: GPIO Interrupts
  2020-07-23 18:40 GPIO Interrupts honsch@telus.net
@ 2020-07-24  8:03 ` Jerome Brunet
  2020-07-24  8:05 ` Neil Armstrong
  1 sibling, 0 replies; 4+ messages in thread
From: Jerome Brunet @ 2020-07-24  8:03 UTC (permalink / raw)
  To: honsch@telus.net, linux-amlogic


On Thu 23 Jul 2020 at 20:40, honsch@telus.net <a6b04393@telus.net> wrote:

> Hi there,
> I've been working on a ODroid C2 project for a while, (meson, gxbb) and I cannot get gpio interrupts working from the devicetree.
>
> I'm trying to hook up the PPS gpio driver as well as some gpio IIO triggers.  I had it all working on a 4.x kernel a couple of years ago but on the 5.7 it's a no-go.
>
> The pinctrl-meson driver is missing the hook for gpiod_to_irq(), and the irq-meson-gpio driver is missing the activate function for platform_get_irq() to function.
>
> Has either of these paths ever been implemented or tested?  Am I missing something simple?

Yes, Look at the eth0_phy0 DT node of your odroid-c2, it does use a gpio interrupt.

> Thanks.
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: GPIO Interrupts
  2020-07-23 18:40 GPIO Interrupts honsch@telus.net
  2020-07-24  8:03 ` Jerome Brunet
@ 2020-07-24  8:05 ` Neil Armstrong
  2020-07-25  6:00   ` E Honsch
  1 sibling, 1 reply; 4+ messages in thread
From: Neil Armstrong @ 2020-07-24  8:05 UTC (permalink / raw)
  To: linux-amlogic

Hi,

On 23/07/2020 20:40, honsch@telus.net wrote:
> Hi there,
> I've been working on a ODroid C2 project for a while, (meson, gxbb) and I cannot get gpio interrupts working from the devicetree.
> 
> I'm trying to hook up the PPS gpio driver as well as some gpio IIO triggers.  I had it all working on a 4.x kernel a couple of years ago but on the 5.7 it's a no-go.
> 
> The pinctrl-meson driver is missing the hook for gpiod_to_irq(), and the irq-meson-gpio driver is missing the activate function for platform_get_irq() to function.
> 
> Has either of these paths ever been implemented or tested?  Am I missing something simple?

The only available driver for GPIO interrupts is irq-meson-gpio and should be enough for most of your use-cases
if you pass the GPIO interrupt as `interrupt = ` and `interrupt-parent =` as we do for the Ethernet PHY on some
boards.

For historical & HW architecture reasons, it's not possible to implement upstream support for the gpiod_to_irq() in the pinctrl driver.

Neil

> Thanks.
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
> 


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: GPIO Interrupts
  2020-07-24  8:05 ` Neil Armstrong
@ 2020-07-25  6:00   ` E Honsch
  0 siblings, 0 replies; 4+ messages in thread
From: E Honsch @ 2020-07-25  6:00 UTC (permalink / raw)
  To: linux-amlogic

Neil,

Thanks for the verification of the state of the system.  Are there 
interesting stories behind the historical reasons it's broken?

I did get the interrupts to work tonight, so there's that.

I just wish I didn't have to modify the drivers to get it to work.

Thanks again.


Eric

On 2020-07-24 1:05 a.m., Neil Armstrong wrote:
> Hi,
>
> On 23/07/2020 20:40, honsch@telus.net wrote:
>> Hi there,
>> I've been working on a ODroid C2 project for a while, (meson, gxbb) and I cannot get gpio interrupts working from the devicetree.
>>
>> I'm trying to hook up the PPS gpio driver as well as some gpio IIO triggers.  I had it all working on a 4.x kernel a couple of years ago but on the 5.7 it's a no-go.
>>
>> The pinctrl-meson driver is missing the hook for gpiod_to_irq(), and the irq-meson-gpio driver is missing the activate function for platform_get_irq() to function.
>>
>> Has either of these paths ever been implemented or tested?  Am I missing something simple?
> The only available driver for GPIO interrupts is irq-meson-gpio and should be enough for most of your use-cases
> if you pass the GPIO interrupt as `interrupt = ` and `interrupt-parent =` as we do for the Ethernet PHY on some
> boards.
>
> For historical & HW architecture reasons, it's not possible to implement upstream support for the gpiod_to_irq() in the pinctrl driver.
>
> Neil
>
>> Thanks.
>>
>> _______________________________________________
>> linux-amlogic mailing list
>> linux-amlogic@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 18:40 GPIO Interrupts honsch@telus.net
2020-07-24  8:03 ` Jerome Brunet
2020-07-24  8:05 ` Neil Armstrong
2020-07-25  6:00   ` E Honsch

Linux-Amlogic Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-amlogic/0 linux-amlogic/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-amlogic linux-amlogic/ https://lore.kernel.org/linux-amlogic \
		linux-amlogic@lists.infradead.org
	public-inbox-index linux-amlogic

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-amlogic


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git