From: Neil Armstrong <narmstrong@baylibre.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-media@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: cec: ao-cec: Make use of the helper function devm_platform_ioremap_resource()
Date: Wed, 1 Sep 2021 10:14:42 +0200 [thread overview]
Message-ID: <4b41b556-b2cd-5ffa-0462-5f41f2d33f85@baylibre.com> (raw)
In-Reply-To: <20210901054535.6215-1-caihuoqing@baidu.com>
On 01/09/2021 07:45, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/media/cec/platform/meson/ao-cec-g12a.c | 4 +---
> drivers/media/cec/platform/meson/ao-cec.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/cec/platform/meson/ao-cec-g12a.c b/drivers/media/cec/platform/meson/ao-cec-g12a.c
> index 891533060d49..68fe6d6a8178 100644
> --- a/drivers/media/cec/platform/meson/ao-cec-g12a.c
> +++ b/drivers/media/cec/platform/meson/ao-cec-g12a.c
> @@ -633,7 +633,6 @@ static int meson_ao_cec_g12a_probe(struct platform_device *pdev)
> {
> struct meson_ao_cec_g12a_device *ao_cec;
> struct device *hdmi_dev;
> - struct resource *res;
> void __iomem *base;
> int ret, irq;
>
> @@ -664,8 +663,7 @@ static int meson_ao_cec_g12a_probe(struct platform_device *pdev)
>
> ao_cec->adap->owner = THIS_MODULE;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(&pdev->dev, res);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(base)) {
> ret = PTR_ERR(base);
> goto out_probe_adapter;
> diff --git a/drivers/media/cec/platform/meson/ao-cec.c b/drivers/media/cec/platform/meson/ao-cec.c
> index 09aff82c3773..6b440f0635d9 100644
> --- a/drivers/media/cec/platform/meson/ao-cec.c
> +++ b/drivers/media/cec/platform/meson/ao-cec.c
> @@ -602,7 +602,6 @@ static int meson_ao_cec_probe(struct platform_device *pdev)
> {
> struct meson_ao_cec_device *ao_cec;
> struct device *hdmi_dev;
> - struct resource *res;
> int ret, irq;
>
> hdmi_dev = cec_notifier_parse_hdmi_phandle(&pdev->dev);
> @@ -626,8 +625,7 @@ static int meson_ao_cec_probe(struct platform_device *pdev)
>
> ao_cec->adap->owner = THIS_MODULE;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ao_cec->base = devm_ioremap_resource(&pdev->dev, res);
> + ao_cec->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(ao_cec->base)) {
> ret = PTR_ERR(ao_cec->base);
> goto out_probe_adapter;
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2021-09-01 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 5:45 [PATCH] media: cec: ao-cec: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-01 8:14 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b41b556-b2cd-5ffa-0462-5f41f2d33f85@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=caihuoqing@baidu.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).