From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A2FC43381 for ; Mon, 18 Mar 2019 13:12:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2049B20850 for ; Mon, 18 Mar 2019 13:12:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="W7cHZmlN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="uWW2Eai6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2049B20850 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8c1UZ7l30r7aaAInhBZfyPFzn453wIGWUDYHs4W+wAo=; b=W7cHZmlNYxRItv jUuoRO60PjuJiy98zRQZcVXkrM5go4PfYH/4TTnHaAjsZAT36dF9myyD0vvE9cq3hUvTJtzuYyRQg /rGM4wU5ZtkywO1CA/v5o+lh3BSd5puDwULKC83KG1n60hNKZj++AXeQ6jxcuv7vMN/dkDhaWmH6l GoZ30Er2JWc90oE/H+EcJ9W7O/Ev2O82Ezsqr0xHB6VkZmGuuT7ik3mDNNuLEuq40fWzGJ6eMnGRK Gpzol4AJuFBB4kHffVIq9JeILdjo4yhdDM3kOOmWfd1PbyKuTtm08wEviyEdtYaBwdirba1sjdDwD rWZx3SoYyv2G55zmoqEQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5s4D-0007Bw-0z; Mon, 18 Mar 2019 13:12:37 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5s49-0007BM-JV for linux-amlogic@lists.infradead.org; Mon, 18 Mar 2019 13:12:35 +0000 Received: by mail-wr1-x441.google.com with SMTP id w2so16952007wrt.11 for ; Mon, 18 Mar 2019 06:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:openpgp:autocrypt:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Q/JQhFJ5Svuh20tw7qoSD6HJZGagg4+WAnpmNurNylc=; b=uWW2Eai6mpmcWK7nVjsU1jCFqn2qTWPYFQi7Vi3jvx+H+EKjqeGQgwY40QThK/LvDO bhMdZe5N7NQLW0GCVwKUT+qL6oFx0iZFCZo5LRo3rlarfIFpDG4ViXvKXrSJ5uHFdDkH BqilEZjRcvse7b+SO2ehHQ2FakekKgdn4SOB/myFE+N3rXy3QWggMbvT9b7ng1u7KHD1 hEZ5oGx695YPuws0+HVBZ1htWESrgoUTvFRTlT91asNL2brgu45SbSWXZBDVzmMFTgyP MUGl8D1ZvLSTfqicaevg0GpUKMRmReyZi88F1K39KF8bmkkPSGi2zh8wZug72Sa415dh 9XHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Q/JQhFJ5Svuh20tw7qoSD6HJZGagg4+WAnpmNurNylc=; b=pY8gdrBwX64QeoCWzNh4jT/eBsflLZ1r6YOmiKLH4qRzJ/GEMou9URngR5G2CFTatw PE0wQTVRcK/3OJMq0vVWLAuD5KBReGr0RtEZJ8I0U8r105Wc2knwpSGuYzSsortXuJL7 PCsUU50P3hFnFNxGPhsILU0LqFwWvcsvsqM7hl2ZjaveEPFBUa1YYqE3IQrflM7mzRwC ob+Sihp60iJJpx8aug2kVFtugUWK0h10eHMxOUjl/1jp21nursBqQV8kWBlq8A/LYbtC CH7PXmVHIs7GcrG0nhWCVhpTh95EVCf7CNnwjnNrQyYvX5jA23NaSBQDhtGljinZu/aP pSGQ== X-Gm-Message-State: APjAAAWnj2bbohyYiRREB7KAfcKw2/fk9uy+UxZnqyT+VmTFrT7n3mGC xUPhDSrmJ7rrH1zqQwBTGqDhZu5/LinYJg== X-Google-Smtp-Source: APXvYqzh8oVuwdWQjvJTRTCoDXD1wz9XY4WbNN8/4aASEDbeCEkorEeaL4kKPLMOU3EH25Kq8k5sWw== X-Received: by 2002:a5d:644a:: with SMTP id d10mr11581876wrw.308.1552914751271; Mon, 18 Mar 2019 06:12:31 -0700 (PDT) Received: from [10.1.2.12] (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id z20sm15550138wma.9.2019.03.18.06.12.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Mar 2019 06:12:29 -0700 (PDT) Subject: Re: [PATCH 2/2] pinctrl: meson: add support of drive-strength To: Jerome Brunet , Linus Walleij , Kevin Hilman References: <20190314163725.7918-1-jbrunet@baylibre.com> <20190314163725.7918-3-jbrunet@baylibre.com> From: Neil Armstrong Openpgp: preference=signencrypt Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= mQENBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAG0KE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT6JATsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIW5AQ0ETVkGzwEIALyKDN/O GURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYpQTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXM coJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hi SvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY4yG6xI99NIPEVE9lNBXBKIlewIyVlkOa YvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoMMtsyw18YoX9BqMFInxqYQQ3j/HpVgTSv mo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUXoUk33HEAEQEAAYkBHwQYAQIACQUCTVkG zwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfnM7IbRuiSZS1unlySUVYu3SD6YBYnNi3G 5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa33eDIHu/zr1HMKErm+2SD6PO9umRef8V8 2o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCSKmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+ RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJ C3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTTQbM0WUIBIcGmq38+OgUsMYu4NzLu7uZF Acmp6h8guQINBFYnf6QBEADQ+wBYa+X2n/xIQz/RUoGHf84Jm+yTqRT43t7sO48/cBW9vAn9 GNwnJ3HRJWKATW0ZXrCr40ES/JqM1fUTfiFDB3VMdWpEfwOAT1zXS+0rX8yljgsWR1UvqyEP 3xN0M/40Zk+rdmZKaZS8VQaXbveaiWMEmY7sBV3QvgOzB7UF2It1HwoCon5Y+PvyE3CguhBd 9iq5iEampkMIkbA3FFCpQFI5Ai3BywkLzbA3ZtnMXR8Qt9gFZtyXvFQrB+/6hDzEPnBGZOOx zkd/iIX59SxBuS38LMlhPPycbFNmtauOC0DNpXCv9ACgC9tFw3exER/xQgSpDVc4vrL2Cacr wmQp1k9E0W+9pk/l8S1jcHx03hgCxPtQLOIyEu9iIJb27TjcXNjiInd7Uea195NldIrndD+x 58/yU3X70qVY+eWbqzpdlwF1KRm6uV0ZOQhEhbi0FfKKgsYFgBIBchGqSOBsCbL35f9hK/JC 6LnGDtSHeJs+jd9/qJj4WqF3x8i0sncQ/gszSajdhnWrxraG3b7/9ldMLpKo/OoihfLaCxtv xYmtw8TGhlMaiOxjDrohmY1z7f3rf6njskoIXUO0nabun1nPAiV1dpjleg60s3OmVQeEpr3a K7gR1ljkemJzM9NUoRROPaT7nMlNYQL+IwuthJd6XQqwzp1jRTGG26J97wARAQABiQM+BBgB AgAJBQJWJ3+kAhsCAikJEBaat7Gkz/iuwV0gBBkBAgAGBQJWJ3+kAAoJEHfc29rIyEnRk6MQ AJDo0nxsadLpYB26FALZsWlN74rnFXth5dQVQ7SkipmyFWZhFL8fQ9OiIoxWhM6rSg9+C1w+ n45eByMg2b8H3mmQmyWztdI95OxSREKwbaXVapCcZnv52JRjlc3DoiiHqTZML5x1Z7lQ1T3F 8o9sKrbFO1WQw1+Nc91+MU0MGN0jtfZ0Tvn/ouEZrSXCE4K3oDGtj3AdC764yZVq6CPigCgs 6Ex80k6QlzCdVP3RKsnPO2xQXXPgyJPJlpD8bHHHW7OLfoR9DaBNympfcbQJeekQrTvyoASw EOTPKE6CVWrcQIztUp0WFTdRGgMK0cZB3Xfe6sOp24PQTHAKGtjTHNP/THomkH24Fum9K3iM /4Wh4V2eqGEgpdeSp5K+LdaNyNgaqzMOtt4HYk86LYLSHfFXywdlbGrY9+TqiJ+ZVW4trmui NIJCOku8SYansq34QzYM0x3UFRwff+45zNBEVzctSnremg1mVgrzOfXU8rt+4N1b2MxorPF8 619aCwVP7U16qNSBaqiAJr4e5SNEnoAq18+1Gp8QsFG0ARY8xp+qaKBByWES7lRi3QbqAKZf yOHS6gmYo9gBmuAhc65/VtHMJtxwjpUeN4Bcs9HUpDMDVHdfeRa73wM+wY5potfQ5zkSp0Jp bxnv/cRBH6+c43stTffprd//4Hgz+nJcCgZKtCYIAPkUxABC85ID2CidzbraErVACmRoizhT KR2OiqSLW2x4xdmSiFNcIWkWJB6Qdri0Fzs2dHe8etD1HYaht1ZhZ810s7QOL7JwypO8dscN KTEkyoTGn6cWj0CX+PeP4xp8AR8ot4d0BhtUY34UPzjE1/xyrQFAdnLd0PP4wXxdIUuRs0+n WLY9Aou/vC1LAdlaGsoTVzJ2gX4fkKQIWhX0WVk41BSFeDKQ3RQ2pnuzwedLO94Bf6X0G48O VsbXrP9BZ6snXyHfebPnno/te5XRqZTL9aJOytB/1iUna+1MAwBxGFPvqeEUUyT+gx1l3Acl ZaTUOEkgIor5losDrePdPgE= Organization: Baylibre Message-ID: <544af6b6-acf4-9904-3b32-9a99567e6ac9@baylibre.com> Date: Mon, 18 Mar 2019 14:12:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190314163725.7918-3-jbrunet@baylibre.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190318_061233_688739_048A0B6B X-CRM114-Status: GOOD ( 19.20 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, Guillaume La Roque , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 14/03/2019 17:37, Jerome Brunet wrote: > From: Guillaume La Roque > > drive-strength is a new feature needed for G12A SoC. > the default DS setting after boot is usually 0.5mA and it is not enough for > many functions. We need to be able to set the drive strength to reliably > enable things like MMC, I2C, etc ... > > Signed-off-by: Guillaume La Roque > Signed-off-by: Jerome Brunet > --- > drivers/pinctrl/meson/pinctrl-meson-g12a.c | 36 ++--- > drivers/pinctrl/meson/pinctrl-meson.c | 166 ++++++++++++++++----- > drivers/pinctrl/meson/pinctrl-meson.h | 20 ++- > 3 files changed, 162 insertions(+), 60 deletions(-) > > diff --git a/drivers/pinctrl/meson/pinctrl-meson-g12a.c b/drivers/pinctrl/meson/pinctrl-meson-g12a.c > index d494492e98e9..3475cd7bd2af 100644 > --- a/drivers/pinctrl/meson/pinctrl-meson-g12a.c > +++ b/drivers/pinctrl/meson/pinctrl-meson-g12a.c [...] > static int meson_pinconf_get(struct pinctrl_dev *pcdev, unsigned int pin, > unsigned long *config) > { > struct meson_pinctrl *pc = pinctrl_dev_get_drvdata(pcdev); > enum pin_config_param param = pinconf_to_config_param(*config); > u16 arg; > + int ret; > > switch (param) { > case PIN_CONFIG_BIAS_DISABLE: > @@ -291,6 +373,10 @@ static int meson_pinconf_get(struct pinctrl_dev *pcdev, unsigned int pin, > else > return -EINVAL; > break; > + case PIN_CONFIG_DRIVE_STRENGTH: > + ret = meson_pinconf_get_drive_strength(pc, pin, &arg); > + if (ret) > + return ret; Missing break here ! Neil > default: > return -ENOTSUPP; > } > diff --git a/drivers/pinctrl/meson/pinctrl-meson.h b/drivers/pinctrl/meson/pinctrl-meson.h > index 5eaab925f427..1a88103dcb9b 100644 > --- a/drivers/pinctrl/meson/pinctrl-meson.h > +++ b/drivers/pinctrl/meson/pinctrl-meson.h > @@ -71,9 +71,20 @@ enum meson_reg_type { > REG_DIR, > REG_OUT, > REG_IN, > + REG_DS, > NUM_REG, > }; > > +/** > + * enum meson_pinconf_drv - value of drive-strength supported > + */ > +enum meson_pinconf_drv { > + MESON_PINCONF_DRV_500UA, > + MESON_PINCONF_DRV_2500UA, > + MESON_PINCONF_DRV_3000UA, > + MESON_PINCONF_DRV_4000UA, > +}; > + > /** > * struct meson bank > * > @@ -132,7 +143,8 @@ struct meson_pinctrl { > .num_groups = ARRAY_SIZE(fn ## _groups), \ > } > > -#define BANK(n, f, l, fi, li, per, peb, pr, pb, dr, db, or, ob, ir, ib) \ > +#define BANK_DS(n, f, l, fi, li, per, peb, pr, pb, dr, db, or, ob, ir, ib, \ > + dsr, dsb) \ > { \ > .name = n, \ > .first = f, \ > @@ -145,8 +157,12 @@ struct meson_pinctrl { > [REG_DIR] = { dr, db }, \ > [REG_OUT] = { or, ob }, \ > [REG_IN] = { ir, ib }, \ > + [REG_DS] = { dsr, dsb }, \ > }, \ > - } > + } > + > +#define BANK(n, f, l, fi, li, per, peb, pr, pb, dr, db, or, ob, ir, ib) \ > + BANK_DS(n, f, l, fi, li, per, peb, pr, pb, dr, db, or, ob, ir, ib, 0, 0) > > #define MESON_PIN(x) PINCTRL_PIN(x, #x) > > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic