From: Neil Armstrong <narmstrong@baylibre.com>
To: Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
jbrunet@baylibre.com, linux-amlogic@lists.infradead.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
robh+dt@kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] dt-bindings: clock: meson8b: drop the "ABP" clock definition
Date: Sat, 23 Mar 2019 10:54:34 +0100 [thread overview]
Message-ID: <5C96025A.1010005@baylibre.com> (raw)
In-Reply-To: <7hmulmzcsi.fsf@baylibre.com>
Le 23/03/2019 00:53, Kevin Hilman a écrit :
> Neil Armstrong <narmstrong@baylibre.com> writes:
>
>> On 19/03/2019 22:41, Martin Blumenstingl wrote:
>>> Commit 8e1dd17c8b0e3f ("dt-bindings: clock: meson8b: export the CPU post
>>> dividers") added a new clock ID "CLKID_ABP" which contains a typo. This
>>> was fixed by adding a new (typo-free) #define CLKID_APB in
>>> commit 40d08f774c17ad ("dt-bindings: clock: meson8b: add APB clock
>>> definition").
>>> Now that the new #define is used by the driver we can remove the old
>>> one (because the old one is not used anywhere).
>>>
>>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>>> ---
>>> include/dt-bindings/clock/meson8b-clkc.h | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/include/dt-bindings/clock/meson8b-clkc.h b/include/dt-bindings/clock/meson8b-clkc.h
>>> index 8067077a62ca..cd11628f50f8 100644
>>> --- a/include/dt-bindings/clock/meson8b-clkc.h
>>> +++ b/include/dt-bindings/clock/meson8b-clkc.h
>>> @@ -103,7 +103,6 @@
>>> #define CLKID_MPLL1 94
>>> #define CLKID_MPLL2 95
>>> #define CLKID_NAND_CLK 112
>>> -#define CLKID_ABP 124
>>> #define CLKID_APB 124
>>> #define CLKID_PERIPH 126
>>> #define CLKID_AXI 128
>>>
>>
>> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
>
> Neil / Jerome, I'm assuming you will queue this via the clk-meson tree?
Yes,
Neil
>
> Kevin
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-03-23 9:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 21:41 [PATCH 0/1] clk: meson8b: remove CLKID with typo ("ABP" -> "APB") Martin Blumenstingl
2019-03-19 21:41 ` [PATCH 1/1] dt-bindings: clock: meson8b: drop the "ABP" clock definition Martin Blumenstingl
2019-03-20 8:12 ` Neil Armstrong
2019-03-22 23:53 ` Kevin Hilman
2019-03-23 9:54 ` Neil Armstrong [this message]
2019-03-31 6:41 ` Rob Herring
2019-04-01 8:34 ` [PATCH 0/1] clk: meson8b: remove CLKID with typo ("ABP" -> "APB") Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C96025A.1010005@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).