From: Rob Herring <robh@kernel.org>
To: Jianxin Pan <jianxin.pan@amlogic.com>
Cc: devicetree@vger.kernel.org, Hanjie Lin <hanjie.lin@amlogic.com>,
Victor Wan <victor.wan@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhiqiang Liang <zhiqiang.liang@amlogic.com>,
Jian Hu <jian.hu@amlogic.com>,
Xingyu Chen <xingyu.chen@amlogic.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH 1/3] dt-bindings: power: add Amlogic secure power domains bindings
Date: Tue, 01 Oct 2019 17:09:09 -0500 [thread overview]
Message-ID: <5d93ce88.1c69fb81.aec64.6b1b@mx.google.com> (raw)
In-Reply-To: <1568895064-4116-2-git-send-email-jianxin.pan@amlogic.com>
On Thu, Sep 19, 2019 at 08:11:02AM -0400, Jianxin Pan wrote:
> Add the bindings for the Amlogic Secure power domains, controlling the
> secure power domains.
>
> The bindings targets the Amlogic A1 and C1 compatible SoCs, in which the
> power domain registers are in secure world.
>
> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
> Signed-off-by: Zhiqiang Liang <zhiqiang.liang@amlogic.com>
> ---
> .../bindings/power/amlogic,meson-sec-pwrc.yaml | 32 ++++++++++++++++++++++
> include/dt-bindings/power/meson-a1-power.h | 32 ++++++++++++++++++++++
> 2 files changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> create mode 100644 include/dt-bindings/power/meson-a1-power.h
>
> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> new file mode 100644
> index 00000000..327e0d9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +# Copyright (c) 2019 Amlogic, Inc
> +# Author: Jianxin Pan <jianxin.pan@amlogic.com>
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/power/amlogic,meson-sec-pwrc.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Amlogic Meson Secure Power Domains
> +
> +maintainers:
> + - Jianxin Pan <jianxin.pan@amlogic.com>
> +
> +description: |+
> + A1/C1 series The Secure Power Domains node should be the child of a syscon
> + node with the required property.
'a syscon node' is not specific enough. It must be a specific node.
> +
> +properties:
> + compatible:
> + enum:
> + - amlogic,meson-a1-pwrc
> +
> +required:
> + - compatible
> +
> +examples:
> + - |
> + pwrc: power-controller {
> + compatible = "amlogic,meson-a1-pwrc";
But why do you need this node? It has no resources.
#power-domain-cells needed?
> + };
> +
> +
> diff --git a/include/dt-bindings/power/meson-a1-power.h b/include/dt-bindings/power/meson-a1-power.h
> new file mode 100644
> index 00000000..6cf50bf
> --- /dev/null
> +++ b/include/dt-bindings/power/meson-a1-power.h
> @@ -0,0 +1,32 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ or MIT) */
> +/*
> + * Copyright (c) 2019 Amlogic, Inc.
> + * Author: Jianxin Pan <jianxin.pan@amlogic.com>
> + */
> +
> +#ifndef _DT_BINDINGS_MESON_A1_POWER_H
> +#define _DT_BINDINGS_MESON_A1_POWER_H
> +
> +#define PWRC_DSPA_ID 8
> +#define PWRC_DSPB_ID 9
> +#define PWRC_UART_ID 10
> +#define PWRC_DMC_ID 11
> +#define PWRC_I2C_ID 12
> +#define PWRC_PSRAM_ID 13
> +#define PWRC_ACODEC_ID 14
> +#define PWRC_AUDIO_ID 15
> +#define PWRC_OTP_ID 16
> +#define PWRC_DMA_ID 17
> +#define PWRC_SD_EMMC_ID 18
> +#define PWRC_RAMA_ID 19
> +#define PWRC_RAMB_ID 20
> +#define PWRC_IR_ID 21
> +#define PWRC_SPICC_ID 22
> +#define PWRC_SPIFC_ID 23
> +#define PWRC_USB_ID 24
> +#define PWRC_NIC_ID 25
> +#define PWRC_PDMIN_ID 26
> +#define PWRC_RSA_ID 27
> +#define PWRC_MAX_ID 28
> +
> +#endif
> --
> 2.7.4
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-10-01 22:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 12:11 [PATCH 0/3] arm64: meson: add support for A1 Power Domains Jianxin Pan
2019-09-19 12:11 ` [PATCH 1/3] dt-bindings: power: add Amlogic secure power domains bindings Jianxin Pan
2019-09-19 20:06 ` Martin Blumenstingl
2019-09-20 7:37 ` Jianxin Pan
2019-10-01 22:09 ` Rob Herring [this message]
2019-10-10 3:31 ` Jianxin Pan
2019-09-19 12:11 ` [PATCH 2/3] soc: amlogic: Add support for Secure power domains controller Jianxin Pan
2019-09-19 20:03 ` Martin Blumenstingl
2019-09-20 7:58 ` Jianxin Pan
2019-09-25 22:41 ` Kevin Hilman
2019-09-26 9:17 ` Jianxin Pan
2019-09-26 16:23 ` Kevin Hilman
2019-09-19 12:11 ` [PATCH 3/3] arm64: dts: meson: a1: add secure power domain controller Jianxin Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d93ce88.1c69fb81.aec64.6b1b@mx.google.com \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hanjie.lin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=victor.wan@amlogic.com \
--cc=xingyu.chen@amlogic.com \
--cc=zhiqiang.liang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).