From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BA0AC4727D for ; Tue, 29 Sep 2020 13:34:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AB962075A for ; Tue, 29 Sep 2020 13:34:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MoeIN3/B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AB962075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+1vNYTlcDryZYx8kQzopBXK6gZsQA/4nvToVW2ywttY=; b=MoeIN3/BtcwR4WyUEKDJlB3Ze JqM93BUyV/aF3Nc7VLaTppqOYYRsZRKCWZ7joQs8xcEcjgVEuUTxFLO+kZCYxHOfgNaiAuJJd6tnn bggK+ymvgjqJ9/wUinb1yXtdb4zFqO32iRFOoALCtTyyJo7/o0ifJSHa3G5fRibU+Hwh9GgX4lIQM 5sU6C2c1bNKMzzjBkXtwqpz7JUptLzABIyN3p6JAB5E9FSrv/hr4YIFonuuiStW8JZbWqZWFRGX7i wUazXA4Gz1NBwgXEKWJisIJed3VhYaKxtQGMJtbjkrNwrICxUrsVuDeGsyE8kpokpk5QKDEz+tdQX FFnqKCPLQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNFll-0001qz-K7; Tue, 29 Sep 2020 13:34:13 +0000 Received: from smtprelay0076.hostedemail.com ([216.40.44.76] helo=smtprelay.hostedemail.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNFli-0001pq-N5; Tue, 29 Sep 2020 13:34:12 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 472EC180A7FFF; Tue, 29 Sep 2020 13:34:08 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: event48_4a081af2718a X-Filterd-Recvd-Size: 2674 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf20.hostedemail.com (Postfix) with ESMTPA; Tue, 29 Sep 2020 13:34:03 +0000 (UTC) Message-ID: <5f0d2b20f5088281363bb4a35c5652a2c087f159.camel@perches.com> Subject: Re: [PATCH 00/18] use semicolons rather than commas to separate statements From: Joe Perches To: Julia Lawall , Dan Carpenter , Shuah Khan Date: Tue, 29 Sep 2020 06:34:02 -0700 In-Reply-To: References: <1601233948-11629-1-git-send-email-Julia.Lawall@inria.fr> <20200929124108.GY4282@kadam> User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200929_093410_788229_31F1993F X-CRM114-Status: GOOD ( 10.15 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, Jerome Brunet , "Rafael J. Wysocki" , linux-stm32@st-md-mailman.stormreply.com, ACPI Devel Maling List , Ard Biesheuvel , David Lechner , Martin Blumenstingl , linux-block@vger.kernel.org, drbd-dev@tron.linbit.com, linux-amlogic@lists.infradead.org, Thomas Gleixner , Linux ARM , Valdis =?UTF-8?Q?Kl=C4=93tnieks?= , linux-wireless@vger.kernel.org, Linux Kernel Mailing List , Linux Crypto Mailing List , openipmi-developer@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote: > On Tue, 29 Sep 2020, Dan Carpenter wrote: > > The times where commas are used deliberately to replace curly braces are > > just evil. Either way the code is cleaner with semi-colons. > > I also found exaamples like the following to be particularly unforunate: > > fprintf(stderr, > "page_nr %lu wrong count %Lu %Lu\n", > page_nr, count, > count_verify[page_nr]), exit(1); > > The exit is very hard to see, unless you know to look for it. I sent that patch last month. https://patchwork.kernel.org/patch/11734877/ It's still not applied. _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic