From: Neil Armstrong <neil.armstrong@linaro.org>
To: Jiucheng Xu <jiucheng.xu@amlogic.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Chris Healy <cphealy@gmail.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Kelvin Zhang <kelvin.zhang@amlogic.com>
Subject: Re: [PATCH v8 1/4] perf/amlogic: Add support for Amlogic meson G12 SoC DDR PMU driver
Date: Tue, 27 Sep 2022 11:28:32 +0200 [thread overview]
Message-ID: <6fe2be1b-faaf-86cd-8fcc-a919d30d65c6@linaro.org> (raw)
In-Reply-To: <20220916020320.2455580-1-jiucheng.xu@amlogic.com>
Hi Will, Mark,
On 16/09/2022 04:03, Jiucheng Xu wrote:
> This patch adds support Amlogic meson G12 series SoC
> DDR bandwidth PMU driver framework and interfaces.
>
> The PMU not only can monitor the total DDR bandwidth,
> but also the bandwidth which is from individual IP module.
>
> Example usage:
>
> $ perf stat -a -e meson_ddr_bw/total_rw_bytes/ -I 1000 sleep 10
>
> - or -
>
> $ perf stat -a -e \
> meson_ddr_bw/total_rw_bytes/,\
> meson_ddr_bw/chan_1_rw_bytes,arm=1/ -I 1000 \
> sleep 10
>
> g12 SoC support 4 channels to monitor DDR bandwidth
> simultaneously. Each channel can monitor up to 4 IP modules
> simultaneously.
>
> For Instance, If you want to get the sum of DDR bandwidth
> from CPU, GPU, USB3.0 and VDEC. You can use the following
> command parameters to display.
>
> $ perf stat -a -e \
> meson_ddr_bw/chan_2_rw_bytes,arm=1,gpu=1,usb3_0=1,nna=1/ -I 1000 \
> sleep 10
>
> Other events are supported, and advertised via perf list.
>
> Signed-off-by: Jiucheng Xu <jiucheng.xu@amlogic.com>
> ---
> Changes v7 -> v8:
> - Add linux-amlogic@lists.infradead.org maillist for MAINTAINERS
> - Change driver name from "amlogic,g12-ddr-pmu" to "meson-g12-ddr-pmu"
>
> Changes v6 -> v7:
> - Drop the Reported-by tag
>
> Changes v5 -> v6:
> - Add const for driver data
>
> Changes v4 -> v5:
> - Remove error message
> - Use smp_processor_id() instead of raw_smp_processor_id()
> - Remove EXPORT_SYMBOL()
> - Use variant specific driver data for compatible
> - Use module_platform_driver for modules_init/exit
> - Change location of driver structures from .h to .c
>
> Changes v3 -> v4:
> - No change
>
> Changes v2 -> v3:
> - Fix sh GCC 12.1.0 compiling warning
> - Rename prefix aml to meson for files and code
>
> Changes v1 -> v2:
> - Remove inline to let GCC make the decisions
> - Remove spinlock
> - Remove ddr_cnt_accumulate()
> - Remove the message which only indicate a bug
> - Remove all dev_warn() message
> - Use hweight64() helper instead of whole loop
> - Remove setting of hwc
> - Use for_each_set_bit() helper for bit loop
> - Use sysfs_emit() in sysfs show
> - Remove checking for bugs
> - Replace irq_set_affinity_hint() to irq_set_affinity()
> - Remove #ifdef CONFIG_OF
> - Use devm_platform_ioremap_resource() instead of
> platform_get_resource()&ioremap()
> - Use platform_get_irq() instead of platform_get_resource()&ioremap()
> - Replace IRQF_SHARED to IRQF_NOBALANCING
> - Remove meaningless log like "init ok"
> - Use compatible instead of creating new property to distinguish
> different platform.
> - Use the is_visible callback to avoid exposing unsupported fmt_attr
> - Use module_platform_driver_probe() instead of module_init/exit
<snip>
Gentle ping, it seems all previous review comments were addressed, could you do another review round on this v8 ?
Thanks,
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2022-09-27 9:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 2:03 [PATCH v8 1/4] perf/amlogic: Add support for Amlogic meson G12 SoC DDR PMU driver Jiucheng Xu
2022-09-16 2:03 ` [PATCH v8 2/4] docs/perf: Add documentation for the Amlogic G12 DDR PMU Jiucheng Xu
2022-09-16 2:03 ` [PATCH v8 3/4] dt-binding: perf: Add Amlogic " Jiucheng Xu
2022-09-16 2:03 ` [PATCH v8 4/4] arm64: dts: meson: Add DDR PMU node Jiucheng Xu
2022-09-27 9:28 ` Neil Armstrong [this message]
2022-10-18 20:58 ` [PATCH v8 1/4] perf/amlogic: Add support for Amlogic meson G12 SoC DDR PMU driver Chris Healy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fe2be1b-faaf-86cd-8fcc-a919d30d65c6@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=cphealy@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=jiucheng.xu@amlogic.com \
--cc=kelvin.zhang@amlogic.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).