From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6E56C433F5 for ; Thu, 6 Oct 2022 14:12:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oAFulSa+M81a+KW2ruNFIixnJw3/QXwaaorBkqIuJbg=; b=azxyPgBTwKRn05 PGtoCDFgRpyJtY3Mmc9qq0Yr9d2BB9lUrW5Z9hu398Kd86OjW7nPFHnhHLlLUUZPkB+Iv4g9VrTh1 MQJZvYYbXydXL4cuyOVHyL1oM68CbojAonSpQQdbbbte48RDMEJaCMKDgPgK21xokS/GtoHwu8lDS 8OTjN5G9wAFOcNDVVRRTtIaBtnJZqXf9zTYlqyasAzfB39SYCjISmAWvTYdI+zKu5eHS2nhVzQg2I 9vrwCCV07V0e/7kktKhz8KAGsPY9PmZEVwEKNiVysELUrJwytkgwO4GiXSNSU9xPzfcVH14S7gSWR Q8n5fPDGia+0oQ9BrVGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogRbI-002v7R-DS; Thu, 06 Oct 2022 14:11:48 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogRbF-002v5t-SY for linux-amlogic@lists.infradead.org; Thu, 06 Oct 2022 14:11:47 +0000 Received: by mail-lf1-x136.google.com with SMTP id j4so3003068lfk.0 for ; Thu, 06 Oct 2022 07:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=n77JB3v5NQQWYXMjQE9mQos/CzAUaBxNKKkh7H62z+s=; b=LErqkYQ3SKuNYCFFC05liT3/69AynMf1KtPpKCZaBCGgTDRYRpQMD+PACtiHdUHNVI CvL7H/8TXvtFKsOimAKz9j64XVLhx++47eDDb4XoEJHNRQ4A1yei0XH+pHhZ/nuCbToP QnT6vhg+DQWa0u+MCmqLMJX7KlspTevR+QOJ/exQD7s+yqOU9jDMeonj0iIrBJ7dF6GK +XDbYeLQ9pUwvE+s97XqKmB3SsHEs5se1x5e6mSZGwuKp5/UvT+ejwzFzCpZXHUi4IEM rciTiYPNX+VBCe04KFWxwdPqiRhlwgi0aD3xSse+ZGkoUdleRcyiWu60qAEtHCBiWSAN 9ldQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=n77JB3v5NQQWYXMjQE9mQos/CzAUaBxNKKkh7H62z+s=; b=7zbbDrwnuTRlWE17KqMgaYB9D1qpYyiiG+kOpWHJ6KnWkwxZsck9HQueCkmzj0EzWG TbIuadUr3wDK0P7WU1o0i7TdDVfemm5QZlEP7xdWqWXc6ZeWSG8z+AFNQaNTrWIvVKNs kcG96gJAK0HrxmNfhHsv67/+2J3Ui8dFfLR+HbgRin3LbnD4BcB8rzqKyMrfKKxp/olU hHYC6iwzwHADeO4S/r03KGeHZ1aNfI7glmU2JqOZ6T6gti8Kj2X1o53XeAArP17mQyQ4 Y8rlAkk/vAq+kBgwaHd08vhatWAzm2sGPmeQpq0NmB04m2cbIPKkU01WjGXxEBCkbUiZ tK0w== X-Gm-Message-State: ACrzQf2/5TcVtNzwxFLm9cWD545hJBGBdEyYyY4dDR+y6W6mB/bt/Fdt 3WKxO/g9xD5qFGQsxfDn9qJC7w== X-Google-Smtp-Source: AMsMyM4ylZPoyJycfqTxZLE/wBpDPIPW+NjZKnv18zVYR3Uj+em69HKE9roVPotUhNN1V5zutAzBpw== X-Received: by 2002:a05:6512:261c:b0:49f:af36:d47 with SMTP id bt28-20020a056512261c00b0049faf360d47mr65017lfb.284.1665065502063; Thu, 06 Oct 2022 07:11:42 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id be25-20020a05651c171900b0026c1cbbf461sm1922973ljb.80.2022.10.06.07.11.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Oct 2022 07:11:40 -0700 (PDT) Message-ID: <7bcb9ef1-6b56-2f5f-3ac9-acc9ed9370df@linaro.org> Date: Thu, 6 Oct 2022 16:11:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 1/2] spi: dt-bindings: amlogic, meson-gx-spicc: Add pinctrl names for SPI signal states Content-Language: en-US To: Amjad Ouled-Ameur , Krzysztof Kozlowski , Neil Armstrong , Rob Herring , Martin Blumenstingl , Kevin Hilman , Jerome Brunet , Mark Brown Cc: Da Xue , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20221004-up-aml-fix-spi-v2-0-3e8ae91a1925@baylibre.com> <20221004-up-aml-fix-spi-v2-1-3e8ae91a1925@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221006_071145_957743_2388BC8B X-CRM114-Status: GOOD ( 17.87 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 06/10/2022 12:57, Amjad Ouled-Ameur wrote: > Hi Krzysztof, > > Thank you for the review. > > On 10/5/22 10:14, Krzysztof Kozlowski wrote: >> On 04/10/2022 13:10, Amjad Ouled-Ameur wrote: >>> SPI pins of the SPICC Controller in Meson-GX needs to be controlled by >>> pin biais when idle. Therefore define three pinctrl names: >>> - default: SPI pins are controlled by spi function. >>> - idle-high: SCLK pin is pulled-up, but MOSI/MISO are still controlled >>> by spi function. >>> - idle-low: SCLK pin is pulled-down, but MOSI/MISO are still controlled >>> by spi function. >>> >>> Reported-by: Da Xue >>> Signed-off-by: Neil Armstrong >>> Signed-off-by: Amjad Ouled-Ameur >>> --- >>> .../devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml >>> index 0c10f7678178..53013e27f507 100644 >>> --- a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml >>> +++ b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml >>> @@ -43,6 +43,14 @@ properties: >>> minItems: 1 >>> maxItems: 2 >>> >>> + pinctrl-0: >>> + minItems: 1 >> maxItems? >> > Will fill it in next version. >>> + >>> + pinctrl-1: >>> + maxItems: 1 >>> + >>> + pinctrl-names: true >> Why do you need all these in the bindings? > > SPI clock bias needs to change at runtime depending on SPI mode, here is an example of > > how this is supposed to be used ("spi_idle_low_pins" and "spi_idle_low_pins" are defined > > in the second patch of this series): I know what it the point in general of pinctrl configuration... But the question is why do you need to specify them in the bindings? Core handles that. IOW, do you require them and missing/incomplete pinctrl should be reported? Best regards, Krzysztof _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic