From: Neil Armstrong <narmstrong@baylibre.com>
To: Christian Hewitt <christianshewitt@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kevin Hilman <khilman@baylibre.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] soc: amlogic: meson-gx-socinfo: Fix S905D3 ID for VIM3L
Date: Mon, 21 Oct 2019 10:22:29 +0200 [thread overview]
Message-ID: <7d8e80b5-0b37-691a-3375-6a37cc774a95@baylibre.com> (raw)
In-Reply-To: <1571646004-21269-1-git-send-email-christianshewitt@gmail.com>
On 21/10/2019 10:20, Christian Hewitt wrote:
> Chip on the board is S905D3 not S905X3:
>
> [ 0.098998] soc soc0: Amlogic Meson SM1 (S905D3) Revision 2b:c (b0:2) Detected
>
> Change from v1: use 0xf0 mask instead of 0xf2 as advised by Neil Armstrong.
>
> Fixes: 1d7c541b8a5b ("soc: amlogic: meson-gx-socinfo: Add S905X3 ID for VIM3L")
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
> drivers/soc/amlogic/meson-gx-socinfo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
> index 87ed558..01fc0d2 100644
> --- a/drivers/soc/amlogic/meson-gx-socinfo.c
> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c
> @@ -69,7 +69,7 @@ static const struct meson_gx_package_id {
> { "S922X", 0x29, 0x40, 0xf0 },
> { "A311D", 0x29, 0x10, 0xf0 },
> { "S905X3", 0x2b, 0x5, 0xf },
> - { "S905X3", 0x2b, 0xb0, 0xf2 },
> + { "S905D3", 0x2b, 0xb0, 0xf0 },
> { "A113L", 0x2c, 0x0, 0xf8 },
> };
>
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-10-21 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 8:20 [PATCH v2] soc: amlogic: meson-gx-socinfo: Fix S905D3 ID for VIM3L Christian Hewitt
2019-10-21 8:22 ` Neil Armstrong [this message]
2019-11-06 19:13 ` Kevin Hilman
2019-11-07 7:41 ` patchwork-bot+linux-amlogic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d8e80b5-0b37-691a-3375-6a37cc774a95@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).