linux-amlogic.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Carlo Caione <carlo@caione.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: meson: libretech-cc: switch eMMC to 1.8v
Date: Thu, 10 Jan 2019 16:53:35 -0800	[thread overview]
Message-ID: <7h5zuwqak0.fsf@baylibre.com> (raw)
In-Reply-To: <f4fa4226a508d563d1a77eaafa5590fd84577c15.camel@baylibre.com>

Jerome Brunet <jbrunet@baylibre.com> writes:

> On Sat, 2018-12-22 at 18:01 +0100, Martin Blumenstingl wrote:
>> Hi Jerome,
>> 
>> On Thu, Dec 20, 2018 at 5:11 PM Jerome Brunet <jbrunet@baylibre.com> wrote:
>> > While some 3.3v eMMC 4.0 are available from libretech, the default
>> > option for the aml-s905x-cc seems to 1.8v 5.0 modules.
>> nit-pick:
>> can you please state which module (storage size) you used for testing?
>> you probably still remember that we had some confusion on Odroid-C2
>> which eMMC module works and which doesn't, so let's be explicit here
>> 
>> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>> > ---
>> >  .../boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts    | 9 +++++----
>> >  1 file changed, 5 insertions(+), 4 deletions(-)
>> > 
>> > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts
>> > b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts
>> > index daad007fac1f..d0d202cf7161 100644
>> > --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts
>> > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts
>> > @@ -118,8 +118,8 @@
>> >         vddio_boot: regulator-vddio_boot {
>> >                 compatible = "regulator-fixed";
>> >                 regulator-name = "VDDIO_BOOT";
>> > -               regulator-min-microvolt = <3300000>;
>> > -               regulator-max-microvolt = <3300000>;
>> > +               regulator-min-microvolt = <1800000>;
>> > +               regulator-max-microvolt = <1800000>;
>> is there a 3.3V -> 1.8V regulator on the eMMC module?
>> I'm not sure about the schematics but it seems to be that the board
>> itself supplies only 3.3V to the eMMC connector, so I'm not sure where
>> 1.8V come from in this case
>
> The module is indeed fed by 3.3v only but it has embedded LDOs add will feed
> back the supply of the BOOT gpio bank.
>
> I tried the following modules:
> * 8 GB samsung - v1.0-170420
> * 32 GB toshiba - v1.0-170421
>
> I think you can't get them here [0].
>
> In theory, these 4.x modules [1] could also work. They don't have the LDOs and
> are directly feeding back the 3.3v to the BOOT bank. Since the modules are
> advertised as being compatible with the Allwinner boards only, and not the AML
> ones, it should not be the default option.
>
> [0] : 
> https://www.loverpi.com/collections/libre-computer-project/products/libre-computer-board-emmc-5-x-module?variant=4173557729
> [1] : 
> https://www.loverpi.com/collections/libre-computer-project/products/libre-computer-board-emmc-4-x-module?variant=761282232333
>
>> can you please add a comment to the .dts about this?
>
> Sure
>

OK, I'll wait for a v2 of this series.

Kevin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

      reply	other threads:[~2019-01-11  0:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-20 16:10 [PATCH 0/2] arm64: dts: meson: libretech-cc: emmc update Jerome Brunet
2018-12-20 16:10 ` [PATCH 1/2] arm64: dts: meson: libretech-cc: set eMMC as removable Jerome Brunet
2018-12-20 16:10 ` [PATCH 2/2] arm64: dts: meson: libretech-cc: switch eMMC to 1.8v Jerome Brunet
2018-12-22 17:01   ` Martin Blumenstingl
2019-01-02 10:51     ` Jerome Brunet
2019-01-11  0:53       ` Kevin Hilman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7h5zuwqak0.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=carlo@caione.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).