[PATCH v2 1/2] dt-bindings: arm: amlogic: add amediatech x96-max bindings

[PATCH v2 1/2] dt-bindings: arm: amlogic: add amediatech x96-max bindings

[Kevin Hilman]

Add new vendor for amediatech, and initial board: x96-max

Signed-off-by: Kevin Hilman <khilman@baylibre.com>
---
 Documentation/devicetree/bindings/arm/amlogic.txt     | 1 +
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt
index 8dbc259081e4..c50b084b6c59 100644
--- a/Documentation/devicetree/bindings/arm/amlogic.txt
+++ b/Documentation/devicetree/bindings/arm/amlogic.txt
@@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC):
   - "amlogic,p281" (Meson gxl s905w)
   - "oranth,tx3-mini" (Meson gxl s905w)
 
+  - "amediatech,x96-max" (Meson gxm s912)
   - "amlogic,q200" (Meson gxm s912)
   - "amlogic,q201" (Meson gxm s912)
   - "khadas,vim2" (Meson gxm s912)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 8c413d8cc2a5..c1bb0c220429 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -24,6 +24,7 @@ amarula	Amarula Solutions
 amazon	Amazon.com, Inc.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
 amd	Advanced Micro Devices (AMD), Inc.
+amediatech	Shenzhen Amediatech Technology Co., Ltd
 amlogic	Amlogic, Inc.
 ampire	Ampire Co., Ltd.
 ams	AMS AG
-- 
2.19.2


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

[PATCH v2 2/2] arm64: dts: meson: add g12a x96 max board

[Kevin Hilman]

Add the G12a (S905X2) based X96 Max board[1].

There is no branding for the manufacturer anywhere on the product, so it
took some digging to find the manufacturer.  But since there's nothing
about the maker on the product I've left it out of the DT name because
1) nobody will know that name and 2) keeps the DT filename shorter.

[1] https://www.cnx-software.com/2018/09/25/x96-max-amlogic-s905x2-tv-box/

Signed-off-by: Kevin Hilman <khilman@baylibre.com>
---
 .../boot/dts/amlogic/meson-g12a-x96-max.dts   | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
new file mode 100644
index 000000000000..c62d3d5706ff
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
@@ -0,0 +1,28 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2018 BayLibre SAS. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "meson-g12a.dtsi"
+
+/ {
+	compatible = "amediatech,x96-max", "amlogic,u200", "amlogic,g12a";
+	model = "Shenzhen Amediatech Technology Co., Ltd X96 Max";
+
+	aliases {
+		serial0 = &uart_AO;
+	};
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+	memory@0 {
+		device_type = "memory";
+		reg = <0x0 0x0 0x0 0x40000000>;
+	};
+};
+
+&uart_AO {
+	status = "okay";
+};
-- 
2.19.2


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add amediatech x96-max bindings

[Chris Moore]

Hi,

Sorry for the repeat : I replied previously to v1 as I hadn't noticed 
that there was already a v2.

Le 20/12/2018 à 00:35, Kevin Hilman a écrit :
> Add new vendor for amediatech, and initial board: x96-max
>
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
> ---
>   Documentation/devicetree/bindings/arm/amlogic.txt     | 1 +
>   Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt
> index 8dbc259081e4..c50b084b6c59 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.txt
> +++ b/Documentation/devicetree/bindings/arm/amlogic.txt
> @@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC):
>     - "amlogic,p281" (Meson gxl s905w)
>     - "oranth,tx3-mini" (Meson gxl s905w)
>   
> +  - "amediatech,x96-max" (Meson gxm s912)

Shouldn't that be Meson g12a s905x2 ?

Cheers,
Chris



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add amediatech x96-max bindings

[Kevin Hilman]

Chris Moore <moore@free.fr> writes:

> Hi,
>
> Sorry for the repeat : I replied previously to v1 as I hadn't noticed 
> that there was already a v2.
>
> Le 20/12/2018 à 00:35, Kevin Hilman a écrit :
>> Add new vendor for amediatech, and initial board: x96-max
>>
>> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
>> ---
>>   Documentation/devicetree/bindings/arm/amlogic.txt     | 1 +
>>   Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt
>> index 8dbc259081e4..c50b084b6c59 100644
>> --- a/Documentation/devicetree/bindings/arm/amlogic.txt
>> +++ b/Documentation/devicetree/bindings/arm/amlogic.txt
>> @@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC):
>>     - "amlogic,p281" (Meson gxl s905w)
>>     - "oranth,tx3-mini" (Meson gxl s905w)
>>   
>> +  - "amediatech,x96-max" (Meson gxm s912)
>
> Shouldn't that be Meson g12a s905x2 ?

Ugh, yes.  Lazy copy/paste bug.  Will fix that in a v3 next year. :)

Thanks for the review,

Kevin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add amediatech x96-max bindings

[Martin Blumenstingl]

Hi Kevin,

On Thu, Dec 20, 2018 at 12:35 AM Kevin Hilman <khilman@baylibre.com> wrote:
>
> Add new vendor for amediatech, and initial board: x96-max
as we have seen there is no "amediatech" branding anywhere on the board itself
however, FCC gave us a clue about the manufacturer: [0]
can you please add this info to the patch description when re-sending?

> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
(with the two comments below)

>  Documentation/devicetree/bindings/arm/amlogic.txt     | 1 +
>  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
if Rob is fine with vendor-prefixes.txt being updated together with
adding a new board then I'm as well :)

>  2 files changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt
> index 8dbc259081e4..c50b084b6c59 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.txt
> +++ b/Documentation/devicetree/bindings/arm/amlogic.txt
> @@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC):
>    - "amlogic,p281" (Meson gxl s905w)
>    - "oranth,tx3-mini" (Meson gxl s905w)
>
> +  - "amediatech,x96-max" (Meson gxm s912)
I assume that you'll not only fix the SoC here (G12A) as reported by
Chris Moore but also the ordering


Regards
Martin


[0] https://fccid.io/2AI6D-X96MAX

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH v2 2/2] arm64: dts: meson: add g12a x96 max board

[Neil Armstrong]

Hi Kevin,

On 20/12/2018 00:35, Kevin Hilman wrote:
> Add the G12a (S905X2) based X96 Max board[1].
> 
> There is no branding for the manufacturer anywhere on the product, so it
> took some digging to find the manufacturer.  But since there's nothing
> about the maker on the product I've left it out of the DT name because
> 1) nobody will know that name and 2) keeps the DT filename shorter.
> 
> [1] https://www.cnx-software.com/2018/09/25/x96-max-amlogic-s905x2-tv-box/
> 
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
> ---
>  .../boot/dts/amlogic/meson-g12a-x96-max.dts   | 28 +++++++++++++++++++

Just found out you forgot to update the Makefile !!

Neil

[snip]

> +
> +&uart_AO {
> +	status = "okay";
> +};
> 


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add amediatech x96-max bindings

[Kevin Hilman]

Chris Moore <moore@free.fr> writes:

> Hi,
>
> Sorry for the repeat : I replied previously to v1 as I hadn't noticed 
> that there was already a v2.
>
> Le 20/12/2018 à 00:35, Kevin Hilman a écrit :
>> Add new vendor for amediatech, and initial board: x96-max
>>
>> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
>> ---
>>   Documentation/devicetree/bindings/arm/amlogic.txt     | 1 +
>>   Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt
>> index 8dbc259081e4..c50b084b6c59 100644
>> --- a/Documentation/devicetree/bindings/arm/amlogic.txt
>> +++ b/Documentation/devicetree/bindings/arm/amlogic.txt
>> @@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC):
>>     - "amlogic,p281" (Meson gxl s905w)
>>     - "oranth,tx3-mini" (Meson gxl s905w)
>>   
>> +  - "amediatech,x96-max" (Meson gxm s912)
>
> Shouldn't that be Meson g12a s905x2 ?

Yes indeed.

Kevin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH v2 2/2] arm64: dts: meson: add g12a x96 max board

[Kevin Hilman]

Neil Armstrong <narmstrong@baylibre.com> writes:

> Hi Kevin,
>
> On 20/12/2018 00:35, Kevin Hilman wrote:
>> Add the G12a (S905X2) based X96 Max board[1].
>> 
>> There is no branding for the manufacturer anywhere on the product, so it
>> took some digging to find the manufacturer.  But since there's nothing
>> about the maker on the product I've left it out of the DT name because
>> 1) nobody will know that name and 2) keeps the DT filename shorter.
>> 
>> [1] https://www.cnx-software.com/2018/09/25/x96-max-amlogic-s905x2-tv-box/
>> 
>> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
>> ---
>>  .../boot/dts/amlogic/meson-g12a-x96-max.dts   | 28 +++++++++++++++++++
>
> Just found out you forgot to update the Makefile !!

D'oh, fixing for v3.

Kevin


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add amediatech x96-max bindings

[Kevin Hilman]

Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:

> Hi Kevin,
>
> On Thu, Dec 20, 2018 at 12:35 AM Kevin Hilman <khilman@baylibre.com> wrote:
>>
>> Add new vendor for amediatech, and initial board: x96-max
> as we have seen there is no "amediatech" branding anywhere on the board itself
> however, FCC gave us a clue about the manufacturer: [0]
> can you please add this info to the patch description when re-sending?

Yes, will add.

>> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> (with the two comments below)
>
>>  Documentation/devicetree/bindings/arm/amlogic.txt     | 1 +
>>  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> if Rob is fine with vendor-prefixes.txt being updated together with
> adding a new board then I'm as well :)
>
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt
>> index 8dbc259081e4..c50b084b6c59 100644
>> --- a/Documentation/devicetree/bindings/arm/amlogic.txt
>> +++ b/Documentation/devicetree/bindings/arm/amlogic.txt
>> @@ -99,6 +99,7 @@ Board compatible values (alphabetically, grouped by SoC):
>>    - "amlogic,p281" (Meson gxl s905w)
>>    - "oranth,tx3-mini" (Meson gxl s905w)
>>
>> +  - "amediatech,x96-max" (Meson gxm s912)
> I assume that you'll not only fix the SoC here (G12A) as reported by
> Chris Moore but also the ordering

Yes, will fix.

Kevin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic