From: Kevin Hilman <khilman@baylibre.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: reset: meson-g12a: Add missing USB2 PHY resets
Date: Fri, 22 Mar 2019 15:53:40 -0700 [thread overview]
Message-ID: <7hbm2234i3.fsf@baylibre.com> (raw)
In-Reply-To: <1553078122.7071.6.camel@pengutronix.de>
Hi Philip,
Philipp Zabel <p.zabel@pengutronix.de> writes:
> On Mon, 2019-03-04 at 11:49 +0100, Neil Armstrong wrote:
>> The G12A Documentation lacked these 2 reset lines, but they are present and
>> used for each USB 2 PHYs.
>>
>> Add them to the dt-bindings for the upcoming USB support.
>>
>> Fixes: dbfc54534dfc ("dt-bindings: reset: meson: add g12a bindings")
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> include/dt-bindings/reset/amlogic,meson-g12a-reset.h | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/dt-bindings/reset/amlogic,meson-g12a-reset.h b/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
>> index 8063e8314eef..6d487c5eba2c 100644
>> --- a/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
>> +++ b/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
>> @@ -51,7 +51,10 @@
>> #define RESET_SD_EMMC_A 44
>> #define RESET_SD_EMMC_B 45
>> #define RESET_SD_EMMC_C 46
>> -/* 47-60 */
>> +/* 47 */
>> +#define RESET_USB_PHY20 48
>> +#define RESET_USB_PHY21 49
>> +/* 50-60 */
>> #define RESET_AUDIO_CODEC 61
>> /* 62-63 */
>> /* RESET2 */
>
> Thank you, applied to reset/fixes with Martin's review tag.
Could ou make a immtable tag for this in your tree? This is needed for
some upcoming DT users we'd like to queue for the next cycle.
Thanks,
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-03-22 22:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 10:49 [PATCH] dt-bindings: reset: meson-g12a: Add missing USB2 PHY resets Neil Armstrong
2019-03-05 22:02 ` Martin Blumenstingl
2019-03-07 12:23 ` Neil Armstrong
2019-03-20 10:35 ` Philipp Zabel
2019-03-22 22:53 ` Kevin Hilman [this message]
2019-03-26 11:33 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hbm2234i3.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).