From: Kevin Hilman <khilman@baylibre.com>
To: Jerome Brunet <jbrunet@baylibre.com>, linux-amlogic@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] soc: mx-socinfo: only build for arm
Date: Tue, 20 Oct 2020 07:47:19 -0700 [thread overview]
Message-ID: <7himb5kl8o.fsf@baylibre.com> (raw)
In-Reply-To: <1jk0vlmiqb.fsf@starbuckisacylon.baylibre.com>
Jerome Brunet <jbrunet@baylibre.com> writes:
> On Tue 20 Oct 2020 at 00:46, Kevin Hilman <khilman@baylibre.com> wrote:
>
>> This driver only supports 32-bit ARM SoCs. Only build it for those.
>>
>> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
>> ---
>> drivers/soc/amlogic/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/amlogic/Kconfig b/drivers/soc/amlogic/Kconfig
>> index 321c5e26a268..2d7ee1397d59 100644
>> --- a/drivers/soc/amlogic/Kconfig
>> +++ b/drivers/soc/amlogic/Kconfig
>> @@ -63,7 +63,7 @@ config MESON_SECURE_PM_DOMAINS
>>
>> config MESON_MX_SOCINFO
>> bool "Amlogic Meson MX SoC Information driver"
>> - depends on ARCH_MESON || COMPILE_TEST
>> + depends on (ARM && ARCH_MESON) || COMPILE_TEST
>
> Would to it make sense to apply the same to the GX soc info ? depends on
> ARM64 ?
Yes, good point. I'll update that.
>> default ARCH_MESON
>> select SOC_BUS
>> help
>
> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
Thanks for the review,
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-10-20 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 22:46 [PATCH 1/2] soc: mx-socinfo: only build for arm Kevin Hilman
2020-10-19 22:46 ` [PATCH 2/2] soc: meson: enable building drivers as modules Kevin Hilman
2020-10-20 19:44 ` Martin Blumenstingl
2020-10-20 21:00 ` Kevin Hilman
2020-10-20 7:58 ` [PATCH 1/2] soc: mx-socinfo: only build for arm Jerome Brunet
2020-10-20 14:47 ` Kevin Hilman [this message]
2020-10-20 19:40 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7himb5kl8o.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).